2 Commits

Include renames

Author	SHA1	Message	Date
3 people	cea3e56628	feat(lifecycle): revision findings ledger — structured failure feedback, persisted and delivered down the chain (#486) ... * feat(lifecycle): revision findings ledger — structured QA/PR/PM/CEO failure feedback, persisted and delivered down the chain Every bounce used to survive only as flattened prose: rounds overwrote each other in notes_structured, request_changes persisted nothing, two raw dev_notes appends were silently destroyed by the next handoff note, and the dev prompt pointed at fields (qa_notes via evidence(), pm_notes) the API never delivered. Agents re-interpreted and re-discovered every failure before they could start fixing it. - task_review_findings (migration 071, append-only): file/line/severity/ criterion(AC-id-validated)/expected/actual/fix/evidence per finding, with origin (qa|pr_gate|pm|ceo), round, and an open->addressed->verified lifecycle (waived reserved); new tasks.pm_notes + PmReviewContent give request_changes a structured home - producers: fail_review/pr_fail/request_changes take findings=[...] (prose issues shimmed+merged for one release, deprecation-logged); ceo_reject validates its reason (no 500), lands an origin=ceo finding, and bumps round+audit on branchless coordination roots; guardrails at the verb chokepoint (nudge >5, hard reject >10, field caps, traversal-safe file); the dev_notes data-loss appends are removed; new task.request_changes + task.ceo_reject audit events close rework attribution - delivery: qa_notes/pr_reviewer_notes/pm_notes carry the deterministic [F-id8] rendering; claim briefings, evidence(), the REVISION_REQUIRED spawn prompt, PM triage bounced-blocks, and A2A bodies deliver open findings; round-N+1 QA and gate reviewers get the full prior ledger; panel Findings tab + bounced-xN chip; metrics pm_rejects/ceo_rejects + findings counts; vault task notes render a Findings section (fail-open) - resolution closes for every origin: i_am_done and submit_up/submit_root take resolved_findings gated by FINDINGS_ADDRESSED (owner-gated so a stale non-owner PM can never mutate the ledger); pass_review/pr_pass/ complete verify-stamp same-transaction; ceo_approve stamps best-effort - 24 real-DB integration tests drive the full loop through the real choreographer; full suite 12856 green * docs: revision findings ledger sweep — CLAUDE.md, map, RAG corpus - CLAUDE.md: new ledger section + corrected request_changes row - docs/map/review-findings.md (new subsystem map) + surgical updates to task-service/pr-gate-review/metrics-observability/vault/panel maps - docs/rag: producers' findings contract across qa/pr-reviewer/developer/ cell-pm/main-pm/ceo role docs (the PM docs were missing request_changes entirely), verb references, and a new architecture/review-findings.md disambiguating ledger findings from convention findings * test(e2e): resubmit resolves the pr_fail finding per the ledger contract The scripted pr_fail revision loop resubmitted submit_up without resolved_findings — correctly rejected now that FINDINGS_ADDRESSED gates the PM resubmit verbs (green locally, red only in CI since the e2e suite skips without ROBOCO_E2E_SMOKE=1). The scripted PM now reads the open ledger row pr_fail persisted (new open_finding_ids arc helper) and resolves it on resubmit, asserting the open set drains — exercising the coordinator half of the new contract end to end. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-07-11 22:54:42 +02:00
3 people	d1cf6ecbf3	Wave 1: PR-gate turn cut, task search, trace timestamps, Secretary edits + e2e scenarios 2–3 (#295) ... * feat(tests): e2e scenario 2 — the PM merge chain through the PR gate Shared arcs extracted (arcs.py: canonical-company seeding + dev/qa/doc segments); scenario 2 seeds a root->cell->dev hierarchy mid-flight, rides the child through the scenario-1 arc into the cell branch (real squash via the fake GitHub), then submit_up -> claim_gate_review/pr_pass -> dispatcher re-claim (mirrored) -> PM complete merging cell->root. This is the exact PM->reviewer->PM turn sequence the wave-1 turn cut shortens — the BEFORE-net. Learned seams scripted: commit-subject validator (>=20 chars), reviewer learning-note gate, pr_pass clears ownership by design. * feat(runtime): PR-gate turn cut — assembled parents auto-submit to the reviewer When every child of an assembled parent is terminal, the closure dispatcher now runs the real submit_up/submit_root through the internal API as the owning PM (_try_auto_submit) instead of spawning the PM for that turn — the submit's substance is deterministic gate code. Any gate refusal falls back to the classic PM closure spawn; pr_fail routing and the PM's final merge turn are unchanged; umbrellas never auto-submit. ROBOCO_PR_GATE_AUTO_SUBMIT_ENABLED default-on; task.auto_submitted audit row per cut. Proven by e2e scenario 2b (real API, real gates, real git) against scenario 2 as the before-net. * feat(notes): structured note sections carry a written_at trace stamp Sections are overwrite-in-place, so without a stamp there was no way to reconstruct WHEN a dev/qa/doc/reviewer note landed (CEO reMarkable item: trace TIMESTAMPS). apply_structured_note stamps ISO written_at beside the model fields; the panel notes tab renders it next to each card title (pre-stamp rows render nothing). Progress updates, commits, and journal entries already carried timestamps — this was the one gap. * feat(tasks): server-side task search — title, details, and id prefix The task list's search box only matched titles client-side, and the trimmed summary payload deliberately carries no description — so keyword/details/id search was impossible in the browser by design. GET /tasks/summary gains q (ILIKE over title+description, id-prefix match, composed with team/status and the view-permission scoping); the panel debounces the box into the summary fetch and drops the title-only client filter that would have hidden description matches. * feat(wave-1): trace timestamps, real task search, Secretary task edits - apply_structured_note stamps written_at per section; the panel notes tab shows it (the one trace surface without a timestamp). - GET /tasks/summary?q= searches title+description+id-prefix server-side (summaries carry no description by design); panel debounces into the fetch and drops the title-only client filter. - Secretary control_task gains a CEO-gated edit action over the content allowlist, and GET /secretary/tasks?q= resolves task names to ids for the chat. PM-side expansion deferred per the CEO's 'not that much'. * fix(workspace): dep-update probe scrubs the inherited venv pin Under uv run the orchestrator's process tree carries VIRTUAL_ENV, and a uv-based dep_update_command in the throwaway probe clone would target that venv instead of the clone's — the same hazard _uv_subprocess_env already guards on the install path. * build: private per-repo uv cache — isolate from machine-wide uvx servers Root cause of the recurring rich/pip/bandit rot, with evidence: uv cache clean timed out on the ~/.cache/uv lock ('is another uv process running?') — three uvx mcp-server-fetch processes (Claude Code fetch MCP, one alive since Wednesday) share that cache and race repo syncs on it; poisoned entries then survive venv rebuilds because rm -rf .venv never touches the cache, and every re-link reproduces the breakage. UV_CACHE_DIR now pins <repo>/.uv-cache (gitignored). The earlier UV_NO_SYNC serialization stays as defense-in-depth but was not the whole story. * feat(tests): e2e scenario 3 — pr_fail revision loop + root→CEO chain 3a: reviewer pr_fail with a concrete issue -> needs_revision -> i_will_plan re-entry (full plan gates) -> real fix lands on the cell branch (the unchanged-PR hard gate refuses resubmit until it does) -> clean second pass -> merge. 3b: submit_root -> gate -> Main PM complete escalates the root to the CEO -> the REAL approve-and-merge endpoint squash-merges to the origin's master. Harness gains the tasks router, a seeded CEO identity, origin_commit, and a fake GitHub whose head.sha is recomputed live (real-GitHub semantics the unchanged gate reads). Seeds now encode the real shape: delivery roots are team=main_pm and planning-typed. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-07-02 21:05:50 +02:00