2 Commits

Include renames

Author	SHA1	Message	Date
3 people	5f32d8760a	feat(forge): Phase 4 — GitLab + Gitea repo-provisioning parity (#581) ... GitLab's create_org_repo (services/forge/gitlab.py) replaces the Phase-3 synthetic 501 with a real implementation: resolves org (a group's full path, subgroups included) to a numeric namespace id via GET /groups/{path}, falling back to the token's own namespace on a 404 (personal-namespace projects); POSTs /projects with the name/path/description/visibility/initialize_with_readme payload (visibility mapped private->"private"/"internal"); reshapes the 201 onto the GitHub fields callers read (full_name/clone_url/html_url) and GitLab's duplicate-path 400 "has already been taken" onto GitHub's 422 shape, text preserved. Gitea's create_org_repo was already real but untested — added transport-level coverage. GitHubProvisioningService (services/github_provisioning.py) is now provider-aware: ROBOCO_PROVISIONING_PROVIDER (github default / gitlab / gitea) and ROBOCO_PROVISIONING_HOST (self-hosted instance, required for gitlab/gitea or the service stays disabled exactly like a missing token/org) pick the target forge; the class/factory names stay GitHub-flavored for backward compatibility (pitch.py and existing imports untouched). A shared _is_already_exists() helper recognizes GitHub's "already exists" (422), Gitea's (409/422 "already exists"), and GitLab's reshaped "has already been taken" (422). The existing-repo re-fetch now builds a provider-aware RepoRef (GitLab packs org/name into the owner field; GitHub/Gitea keep the owner,repo pair). Default behavior (no new env set) is byte-for-byte the Phase-1 GitHub path, pinned by a regression test. Gates: ruff format/check clean, mypy roboco/+tests/ clean (1235 files), xenon A/A/B clean, targeted suite (forge + provisioning + pitch) 79/79 green. Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-07-19 11:50:47 +02:00
3 people	96401f4c10	feat(forge): Phases 2+2.1+3 — Gitea + GitLab providers, per-call routing, local-merge fallback (#575) ... * feat(forge): Phase 2 — Gitea provider, per-call routing, host registry Gitea support lands behind the Phase-1 seam: - GiteaProvider (services/forge/gitea.py): Gitea v1 transport addressed by instance host (api base from the project's git_url). Where Gitea's wire contract diverges from GitHub's, the provider adapts responses back into the shapes GitService already classifies (ShapedResponse): `token` auth scheme, duplicate-PR 409→422 with the "already exists" text GitService keys on, commit statuses reshaped into check_runs / workflow_runs envelopes, APPROVE→APPROVED review mapping, Do-keyed POST merge, merge-method repo keys, label-color '#' prefix, client-side head/base PR filtering. Deliberate postures per the spec: zero-workflows fail-open (statuses-free repo → no_ci_configured) and merge_branch as a shaped 501 (env-sync cascade lands on missing_ref; the shared local-git fallback is Phase-2.1). - ForgeRouter (services/forge/router.py): GitService._forge now routes per call from RepoRef.host — every existing call site unchanged in shape. RepoRef gains an optional host; _parse_git_url returns the host-stamped ref and it is threaded through GitService/release executor instead of being rebuilt from strings (helpers re-signatured to take RepoRef). - Host registry (services/forge/registry.py): in-memory host→provider map, self-healing — ProjectService.get/get_by_slug re-register on every read; provider_for resolves gitea projects by git_url host. - Registration validation now accepts git_provider="gitea"; GitLab remains recognized-but-rejected. Panel: the read-only Forge badge becomes a real picker (Auto-detect / GitHub-GHE / Gitea / GitLab disabled). Plain git (clone/fetch/push) needs no changes — the Basic-auth extraheader works on Gitea unchanged. Gates: mypy 392 files, xenon A, full unit suite 6356 green, integration suite 2257 green. * feat(forge): live-Gitea contract suite + scheme support + slash-safe refs Hardening from running the provider against a real dockerized Gitea 1.22.6 (the spec's Phase-2 contract suite, now committed as the env-gated tests/e2e_smoke/test_gitea_live.py — self-seeding: creates its own repo, pushes real commits, and drives PR open → duplicate reshape → list/filter → diff → review → labels → commit-status CI reshapes → squash merge → branch delete → release, plus a live verification of the x-access-token Basic-auth git-CLI claim). Two real findings fixed: - Branch refs weren't URL-encoded — every RoboCo branch carries slashes (feature/backend/...), and Gitea's router 404s on the extra path segments. list_ci_runs + delete_branch_ref now quote the ref (regression-pinned in the unit suite). - The API base hardcoded https; a LAN instance serving plain http is a real deployment shape. GiteaProvider gains a scheme (recorded per host by the registry from the project's git_url). ShapedResponse moves to forge/shaping.py (shared by the upcoming GitLab transport, which needs its text override for diff reassembly). * feat(forge): Phase 3 GitLab provider + Phase 2.1 local-merge fallback GitLabProvider (services/forge/gitlab.py): GitLab v4 transport addressed by host+scheme, subgroup-safe (the MR project path packs into RepoRef.owner, URL-encoded per call). Adapters translate MR semantics into the GitHub shapes GitService classifies: iid→number, source/target_branch→head/base with a merged bool, per-file diffs reassembled into unified-diff text (ShapedResponse text override, 3-page cap), approve-vs-note review routing (GitLab has no request-changes verb), pipelines/statuses reshaped into workflow_runs/check_runs, merge-method repo-key mapping, duplicate-MR 409→422. Reviewer mirroring is skipped (needs numeric ids RoboCo doesn't store); provisioning stays Phase 4. gitlab.com now auto-detects at registration like github.com; self-hosted GitLab sets the provider explicitly (panel picker enabled). Phase 2.1: neither Gitea nor GitLab has GitHub's server-side merges API — their merge_branch returns a shaped 501 and GitService.sync_env_branch now runs the shared local-git fallback (_local_merge_branch: throwaway clone → ancestor check → merge → push; a conflict aborts with the remote untouched; same status vocabulary as the merges-API path). Also aligns the whole tree with the full gate's tests/-scoped mypy (provider-test responder typing, e2e_smoke's stale owner/repo shapes). Gates: mypy 1229 files clean, xenon A, unit suite 6393 green, forge suites 85 green, panel typecheck/lint clean. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-07-19 08:12:34 +02:00