roboco

External/roboco

Fork 0

mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00

Commit Graph

Author	SHA1	Message	Date
Renn F	c093996efc	fix(ceo-approve): require substantive notes; panel collects them ceo-approve was bound to QANotes (notes required), so the panel's one-click approve (posts {}) 422'd. The wrong fix is to waive notes — that empties the audit record for a production merge. Instead require substantive notes (>=20 chars, mirroring pass-qa) and make the panel COLLECT them: a new CeoApproveDialog (mirrors the reject dialog) gates the 'Approve & Merge' action, and the dashboard approval-queue enforces the same before POSTing. The CEO sign-off note is now always captured.	2026-05-24 06:59:37 +02:00
Renn F	8e201901c0	I mean, it's at a good place rn...	2026-04-20 15:10:54 +02:00

Author

SHA1

Message

Date

Renn F

c093996efc

fix(ceo-approve): require substantive notes; panel collects them

ceo-approve was bound to QANotes (notes required), so the panel's
one-click approve (posts {}) 422'd. The wrong fix is to waive notes —
that empties the audit record for a production merge. Instead require
substantive notes (>=20 chars, mirroring pass-qa) and make the panel
COLLECT them: a new CeoApproveDialog (mirrors the reject dialog) gates
the 'Approve & Merge' action, and the dashboard approval-queue enforces
the same before POSTing. The CEO sign-off note is now always captured.

2026-05-24 06:59:37 +02:00

Renn F

8e201901c0

I mean, it's at a good place rn...

2026-04-20 15:10:54 +02:00