2 Commits

Include renames

Author	SHA1	Message	Date
3 people	a036c97985	fix(tg): cockpit data correctness — real GLM pricing, display timezone, agent activity tracking (#666) ... * fix(tg): cockpit data correctness — real GLM pricing, display timezone, agent activity tracking Three root causes behind the Mini App/bot showing wrong numbers: Pricing: glm-5.2 gets a grounded per-token rate (z.ai published pricing, $1.40/$4.40/$0.26 per 1M, source+date in the table comment) so a GLM fleet day stops reporting $0.00 for half a million tokens; ungrounded Ollama-Cloud models render "subscription (untracked)" instead of a bare zero (is_ollama_cloud_model, consumed directly by the cockpit). Side effect, intended and documented: honestly-priced GLM now trips the downgrade-only comparator for new qa/documenter complexity pins. Display timezone: the cockpit bucketed days in UTC for a GMT+2 operator. New pure foundation module display_time (resolve_zone/local_date/ trailing_dates/day_bounds_utc, DST-correct with tests for the 23h/25h days) + ROBOCO_DISPLAY_TIMEZONE (IANA-validated, default UTC); the cockpit's spend/velocity series bucket raw session/completion rows by the display zone. The UTC-keyed rollup table and the main dashboard are deliberately untouched. Agent activity: AgentTable.status was never set to ACTIVE and current_task_id was never written anywhere — "active: 0, working: []" was structurally permanent. Every claim path now marks the claimant ACTIVE with rollback symmetry (_finalize_claim for dev/PM claims, _qa_or_doc_claim for QA/doc/PR-gate claims, pr_review_claim for external review) and every release path clears it (pass/fail QA, pr_pass/pr_fail, complete_review, advance-to-PM-review, reaper unclaim, voluntary unclaim, reassign retarget, pool divert, admin transitions, unblock restore-to-in-progress). The bot's /status shares the cockpit's fleet derivation so the two surfaces can't disagree. Known ceiling, commented: one current_task_id column shows a multi-root coordinator PM's most recent claim only. Drill: sonnet develop -> sonnet adversarial (refuted the original chokepoint coverage claim; QA/doc/reviewer paths were unwired) -> correction round (wired them all + restored a dropped assertion, deleted a dead helper and the dead subscription_billed field) -> review. * fix(db): post_update on AgentTable.current_task breaks the flush cycle agents.current_task_id and tasks.assigned_to reference each other, so a flush touching both rows — every claim now marks its agent ACTIVE — is an instance-level circular dependency SQLAlchemy cannot topologically sort. The e2e smoke's full verb paths (12 tests) hit it; the unit and integration suites never flush both dirty rows with relationships loaded. post_update emits the FK as a second UPDATE, the canonical fix for mutually-referencing rows. * fix(budgets): enforce only explicitly-set budgets — no per-TaskType defaults The per-TaskType default cap table blocked an unbudgeted coordination root one opus planning turn in ($1.50 PLANNING default vs. real coordination spend) — a false positive by design the moment the fleet runs a priced model. Budgets are now explicit-input only: effective_task_budget_usd returns None for an unset budget_usd, the budget sweep skips enforcement (and never prices spend) on None, and the unblock re-check passes on None so clearing the budget field is itself a valid resolution. The project monthly cap stays as the explicit-input fleet-wide backstop. Panel copy tells the truth ("No cap" placeholder; empty = uncapped), and the TaskType default table plus its resolver are deleted. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-07-23 21:09:50 +02:00
3 people	baa87d584a	feat(tg): Mini App V4 — Today brief, native approvals, live data, bot tier, chat bridges (#576) ... * feat(tg): P0 — dev mock bridge + Telegram-native foundations Mini App V4 phase 0. The (tg) shell gains the groundwork every later phase builds on: - Dev mock bridge: outside Telegram, a development build falls back to a no-op WebApp object and skips the webapp-auth POST (the regular panel session cookie authorizes API calls), so the cockpit is workable in a plain browser. Production keeps the "Open from Telegram" wall. - Telegram theme adoption: themeParams map onto the shadcn CSS variables scoped to #tg-shell (desktop dashboard untouched), colorScheme drives the dark class, themeChanged re-applies live. Non-hex values are dropped at the trust boundary. - Viewport/swipe correctness: shell height rides Telegram's own --tg-viewport-stable-height (100dvh fallback), vertical swipe-to-close disabled so list scrolling can't dismiss the app. - Native chrome bindings: TgWebAppProvider context plus useMainButton / useBackButton declarative hooks and a null-safe haptics helper — consumers never touch window.Telegram directly. * feat(tg): P1 — Today home tab + one-round-trip /telegram/today brief Mini App V4 phase 1: the cockpit now opens on a "Today" brief answering "does anything need me?" in one glance. Backend: GET /api/telegram/today (CEO-gated, rate-limited) returns the whole brief in one round trip via the new TgCockpitService — needs-you items (awaiting-CEO + blocked tasks capped for a phone screen, held-draft counts across release/X/video/roadmap queues), a fleet snapshot with per-agent current-task titles, today's spend from the day rollup (degrading to zeros on a usage hiccup, mirroring the CEO overview), and ship state. Deliberately DB-only: no live GitHub calls, no readiness snapshot (that path clones), no orchestrator singleton — the CI red/green proxy is the set of open ci_watch fix tasks. Panel: TgTodayTab is the new default tab (Gauge icon) — needs-you rows and draft chips deep-link into the tab that acts on them (with a haptic tap), fleet/spend/ship render as dense cards, 45s refetch until the P3 WebSocket wiring lands. * fix(tg): dev mock engages when the CDN bridge loads outside Telegram Live browser smoke caught it: a bare tab still loads telegram-web-app.js, so window.Telegram.WebApp EXISTS outside Telegram — just with empty initData. The dev fallback keyed on a null bridge only, so a dev browser went down the real-auth path and posted empty initData instead of mounting the mock. The fallback now treats bridge-with-no-initData the same as no bridge (a real Telegram launch always carries initData); production behavior is unchanged. * feat(tg): P2 — native approvals card stack Mini App V4 phase 2: the Approvals tab stops stacking the four desktop queue cards and becomes a phone-native flow — one normalized list across release proposal / X drafts / video drafts / proposed roadmap items, and a full-context detail per item: - Release: version/bump/gate badges, changelog draft, gaps, migration notes, in-flight + failed-execute banners; approve runs the fail-closed executor, reject requires a substantive change request (10 chars). - X: editable body with the live 280 counter, replied-to mention quoted; approve sends the edited body only when actually edited. - Video: cut-toggled player (blob-fetched through the authed client — a bare <video src> would 401), per-platform caption edits with 280/2200 counters; approve sends only checked-in edits. - Roadmap: the PO's full pitch (description, rationale, ACs); approve materializes into the backlog per item. The detail's primary action rides Telegram's native MainButton and back navigation rides the BackButton, with visible fallbacks outside Telegram (dev mock, old clients). Haptics fire on outcomes. An acted-on item vanishes from the refetched queue, popping back to the list by construction. A failed queue source is surfaced ("list may be incomplete" / "couldn't load") instead of masquerading as an empty queue — caught live in the browser smoke. * feat(tg): dev demo mode — /tg?demo=1 renders canned cockpit data Development-only: with the flag param present, the Today brief and the four approval queues resolve typed fixtures (dynamically imported, so production bundles never carry them) instead of hitting the backend — the cockpit is fully browsable with zero stack running. Mutations still go to the real API and fail loudly; it's a showroom, not a simulator. * feat(tg): P3 — cockpit rides /ws/system live Chat adopts the desktop A2A invalidate-on-frame idiom over the shared ref-counted /ws/system socket: every a2a.message frame refreshes the conversation list and the affected thread, missed-frame gaps are healed by a reconnect refetch, and the 10s thread poll turns off entirely while the socket is up (it remains the fallback). The Today brief refreshes on each USAGE_SNAPSHOT push so the spend line tracks the sweeper live, with the 45s poll as the socket-down fallback. No new sockets, no backend changes — the WS gate already accepts the cloud-auth session cookie. * feat(tg): P4 — deterministic bot command tier + self-syncing menu Mini App V4 phase 4 (deterministic half): three new bot commands beside /status /queue /task — - /agents: who's mid-task right now, from the same TgCockpitService fleet snapshot the Today brief renders (now public `fleet()`). - /usage: today's spend from the day rollup. - /blocked: awaiting-you + blocked tasks, deep-linked into the panel, capped per section, titles HTML-escaped. BOT_COMMANDS is the single registry driving /help AND a once-per-process Bot API setMyCommands sync on the first poll cycle (new client method, best-effort), so the Telegram command menu can never drift from what the code implements. The interactive tier (/secretary, /newtask riding a live Intake interview in-thread) is specced but not in this commit. * feat(tg): direction-C styling pass — Telegram palette, RoboCo voice The cockpit stops wearing default-shadcn and gets its own visual language on top of the P0 themeParams bridge (colors stay CSS-variable driven, so inside Telegram everything still adopts the user's theme): - Shared primitives (components/tg/ui.tsx): TgSection grouped cards with tracked micro-label headers, TgRow list rows (44px targets, press feedback, 1/2-line clamp), TgRowIcon glyph tiles, TgStat tabular-nums figures. Every tab composes the same three, so density and rhythm are identical across the surface. - Shell renders a centered 430px column (sm:border-x) — the phone UI no longer stretches across a desktop dev browser. - Tab bar: tighter type, active stroke-weight shift, backdrop blur. - Today: needs-you count badge, divided task rows with inline blocked marker, fleet as mono-named rows, spend/ship as stat tiles. - Approvals rows as icon-tile cards; detail header gains the kind glyph. - Inbox/Chat rows aligned to the same card language. * feat(tg): P5 — /secretary and /newtask live-chat bridges The bot's interactive tier: both commands bridge the CEO's Telegram chat into the same in-process runtimes the panel drives — the persistent Secretary container and the scoped Intake interview. There is no synchronous send→reply seam (replies land on the session's single-consumer relay queue), so each bridged session runs one long-lived consumer task (roboco/services/telegram_bridge.py) that drains PrompterLiveRegistry.stream and pushes one Telegram message per completed turn. While a session is live, plain chat text IS the conversation; /end closes it. /newtask resolves the intake scope (single project auto-picked, multiple offered as a tap-to-pick keyboard holding the initial text), and the interview happens in-thread. A draft proposal renders as a card with Send-to-Board / Discard buttons: confirm routes through the normal board-review path (PrompterService.confirm_live_draft, route=board) and PARKS the session — board feedback later streams straight back into the same thread, closing the redraft loop from the phone. MegaTask batches still confirm in the panel only. The consumer's open stream arms the registry's 60s keepalive, so the bridge runs its own idle TTL (same setting, parked sessions exempt). State is per-process in-memory by design (the _PENDING_REPLIES posture); intake/secretary containers are process-wide singletons, so a bridged session preempts a live panel session of the same kind by construction. * feat(tg): cockpit skin — RoboCo dark deck with a constant amber accent The cockpit no longer inherits the dashboard's white default outside Telegram: #tg-shell carries its own standing skin (deep slate surfaces, amber primary) so the Mini App looks like RoboCo everywhere. Inside Telegram the themeParams bridge now overrides SURFACE tokens only — background/card/text/hint/border repaint to the user's Telegram theme while --primary/--ring stay RoboCo amber: Telegram's surfaces, RoboCo's voice. Demo fixtures also rewritten to neutral content (they previously depicted unbuilt forge work and already-shipped roadmap items as live). --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-07-19 07:29:04 +02:00