2 Commits

Include renames

Author	SHA1	Message	Date
4 people	6cf99a1b0a	[beb8cae1] Type-gate tests/ under mypy — fix all errors and flip quality gate (#156) (#157) ... * [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154) * [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py - Create tests/__init__.py as empty package marker - Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py - Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py - Add return type annotations to _stub_get_optimal, _source, and factory functions - Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin - Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub - Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py - Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object - All 487 source files pass mypy with 0 errors; 2312 unit tests pass * [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/ Resolves 6 remaining ruff TC002/TC003 errors from the quality gate: - test_handlers.py: Iterator → TYPE_CHECKING - test_quality_gate.py: pathlib → TYPE_CHECKING - test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING - test_streaming.py: Iterator → TYPE_CHECKING - test_notification.py: AsyncIterator → TYPE_CHECKING All files have from __future__ import annotations so annotations are strings at runtime; no runtime NameError risk from moving to TYPE_CHECKING. * [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files * [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets --------- * [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155) * [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/ - Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.) - Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches - Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py - Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/ - No runtime logic changed — annotations and cast() only * [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate - Quote all cast() type arguments per ruff TC006 rule (cast("T", x)) - Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form) - Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.) - No runtime logic changed — annotation-only changeset * [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only) The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast targets already check `roboco/ tests/` — the lint target now matches gate scope. --------- --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>	2026-06-14 13:43:46 +02:00
3 people	a6b67a6a58	Feat: board redraft loop (#139) ... * feat(board): expose board review brief + guard approve-and-start Slice 1 of the board-informed intake re-draft loop (backend foundation): - JournalService.board_review_brief(task_id): the PO + Head of Marketing DECISION_LOG entries for a task, oldest-first, each tagged with author — the board's review as structured data. - GET /api/tasks/{task_id}/board-review (PM-or-above) backing the CEO's approval/redraft surface, so the real board analysis is readable instead of a placeholder; BoardReviewEntry response schema. - Guard: approve_and_start now refuses a board task whose review is not complete (service invariant + precise BOARD_REVIEW_INCOMPLETE at the route). Previously only the UI hid the button; the backend let an early/rogue call hand the task to Main PM mid-review. Tests: brief filtering/ordering + endpoint (200/404) + the two guard paths. * feat(panel): show real board review at the approve gate + live refresh Slice 1 frontend of the board-informed intake re-draft loop: - tasksApi.getBoardReview + useBoardReview hook consume GET /tasks/{id}/board-review. - The Approve & Start dialog now renders the actual Product Owner + Head of Marketing notes (markdown) instead of a static placeholder, so the CEO reads the board's analysis before approving. - C2: useTask polls (4s) while a task is still on the board with an incomplete review, so the Approve & Start button appears as soon as the board finishes — there is no per-task websocket. Polling stops once board_review_complete flips. * feat(intake): board-informed re-draft loop (backend, cold path) Slice 2 of the re-draft loop: - update_live_draft: apply a board-informed re-draft to the EXISTING task in place (title/description/acceptance_criteria) — never a duplicate — then route it: 'main_pm' hands it to the Main PM via approve_and_start; 'board' clears board_review_complete for another review round. - confirm route branches on task_id → update_live_draft vs confirm_live_draft; LiveConfirmRequest.task_id added (scope taken from the task, not required). - POST /live/re-interview/{task_id} (PM-or-above): spawns a fresh intake session seeded with the current draft + the board brief (compose_redraft_message), scoped to the task's product/project. The cold path + Slice-3 fallback. - format_board_briefing / compose_redraft_message helpers. Tests: pure helpers + update_live_draft (main_pm hand-off, re-board reset, missing-task). * feat(panel): board-informed re-draft entry + prompter re-draft guidance Slice 2 panel of the re-draft loop: - 'Re-draft with board feedback' button on a board-reviewed task detail → /prompter?redraft=<taskId>. - usePrompter.startRedraft(taskId): calls POST /prompter/live/re-interview/{id}, scopes the chat to the task, and streams the re-draft; redraftTaskId is threaded (persisted across reload) so confirm carries task_id and updates the existing task in place rather than creating a duplicate. - prompterLiveApi.reInterview; ConfirmPayload.task_id. - Prompter role prompt: a 'Re-drafting after board review' section so the agent revises the included draft from the board brief instead of starting over. Panel verified by CI (no local node_modules). * feat(intake): keep-alive re-draft — park the intake agent during board review Slice 3 of the re-draft loop (in-context fidelity; cold path is the fallback): - Registry: LiveIntakeSession.task_id + park(session_id, task_id) (keep alive instead of reaping) + find_by_task() for board-completion injection. - Confirm: the board route (first pass) PARKS the intake agent instead of reaping, so it keeps the whole interview in context. - Orchestrator: on board-review completion, inject the synthesized board brief into the parked session (_inject_board_brief_into_parked_intake) so the resident prompter re-drafts in-context. No-op when nothing is parked (the container died / a new intake replaced it) — the cold /re-interview path covers that. No reaper change needed (an idle parked session spends no tokens and the budget sweep is the only agent-stopping sweep). - Panel: confirm(board) keeps the chat alive (parked, redraftTaskId set) with a notice; the injected revised draft arrives over the existing stream to approve. Tests: registry park/find_by_task/closed-ignored. Container delivery + the full panel parked flow need live (container-runtime) verification. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-06-14 00:40:18 +02:00