* feat(lifecycle): revision findings ledger — structured QA/PR/PM/CEO failure feedback, persisted and delivered down the chain
Every bounce used to survive only as flattened prose: rounds overwrote each
other in notes_structured, request_changes persisted nothing, two raw
dev_notes appends were silently destroyed by the next handoff note, and the
dev prompt pointed at fields (qa_notes via evidence(), pm_notes) the API
never delivered. Agents re-interpreted and re-discovered every failure
before they could start fixing it.
- task_review_findings (migration 071, append-only): file/line/severity/
criterion(AC-id-validated)/expected/actual/fix/evidence per finding, with
origin (qa|pr_gate|pm|ceo), round, and an open->addressed->verified
lifecycle (waived reserved); new tasks.pm_notes + PmReviewContent give
request_changes a structured home
- producers: fail_review/pr_fail/request_changes take findings=[...] (prose
issues shimmed+merged for one release, deprecation-logged); ceo_reject
validates its reason (no 500), lands an origin=ceo finding, and bumps
round+audit on branchless coordination roots; guardrails at the verb
chokepoint (nudge >5, hard reject >10, field caps, traversal-safe file);
the dev_notes data-loss appends are removed; new task.request_changes +
task.ceo_reject audit events close rework attribution
- delivery: qa_notes/pr_reviewer_notes/pm_notes carry the deterministic
[F-id8] rendering; claim briefings, evidence(), the REVISION_REQUIRED
spawn prompt, PM triage bounced-blocks, and A2A bodies deliver open
findings; round-N+1 QA and gate reviewers get the full prior ledger;
panel Findings tab + bounced-xN chip; metrics pm_rejects/ceo_rejects +
findings counts; vault task notes render a Findings section (fail-open)
- resolution closes for every origin: i_am_done and submit_up/submit_root
take resolved_findings gated by FINDINGS_ADDRESSED (owner-gated so a
stale non-owner PM can never mutate the ledger); pass_review/pr_pass/
complete verify-stamp same-transaction; ceo_approve stamps best-effort
- 24 real-DB integration tests drive the full loop through the real
choreographer; full suite 12856 green
* docs: revision findings ledger sweep — CLAUDE.md, map, RAG corpus
- CLAUDE.md: new ledger section + corrected request_changes row
- docs/map/review-findings.md (new subsystem map) + surgical updates to
task-service/pr-gate-review/metrics-observability/vault/panel maps
- docs/rag: producers' findings contract across qa/pr-reviewer/developer/
cell-pm/main-pm/ceo role docs (the PM docs were missing request_changes
entirely), verb references, and a new architecture/review-findings.md
disambiguating ledger findings from convention findings
* test(e2e): resubmit resolves the pr_fail finding per the ledger contract
The scripted pr_fail revision loop resubmitted submit_up without
resolved_findings — correctly rejected now that FINDINGS_ADDRESSED gates
the PM resubmit verbs (green locally, red only in CI since the e2e suite
skips without ROBOCO_E2E_SMOKE=1). The scripted PM now reads the open
ledger row pr_fail persisted (new open_finding_ids arc helper) and
resolves it on resubmit, asserting the open set drains — exercising the
coordinator half of the new contract end to end.
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
* feat(vault): V2 — create-seam + drift janitor, archival, weekly org-report, KB ingest, Bases views + sync runbook
Implements the vault V2 canonical spec end to end (the splice guard shipped
separately and is reused at KB-ingest time):
- materialize-on-create: TaskService.create writes each task's note best-effort
from the moment it exists; the transition-touch stops no-oping on live work
- drift janitor (services/vault_janitor.py + hourly _vault_janitor_loop): daily
changed-task re-projection, random drift sample, archival pass — restart-proof
via RoboCo/_meta/.janitor_state.json, 200/cycle caps, per-item isolation,
processed-only resume markers, self-repairing state file
- archival: vault_archive_days (30, 0=off) moves old terminal tasks' notes to
RoboCo/Archive/<year>/Tasks/<project>/ — one write_task code path for janitor
and rebuild, id8 lookup across Tasks/+Archive/, alias links keep moves safe
- weekly org-report: VaultWriter.write_org_report renders Reports/<ISO-week>.md
from MetricsService/UsageService (numbers duplicated into frontmatter for
trend queries), once per ISO week, with a best-effort CEO notification
- KB ingest: IndexType.VAULT_NOTES + VaultNotesIndexPlugin + _vault_kb_loop
embed the CEO's RoboCo/Notes into the RAG corpus — injection guard as a hard
gate (flagged notes quarantined with an idempotent callout), traversal- and
symlink-contained at both config and engine layers, content-hash dedup,
50-ingest/cycle cap, frontmatter stripped; reaches roboco_kb_search, the
mentor default domain, claim-time briefings (kind vault_note), and the panel
KB browser; no migration (chunks table auto-creates; migration 030's
CHUNK_TABLES tuple appended per the chunks_playbooks precedent)
- Bases views (Task Board.base, Reports.base — schema verified against the
Obsidian docs) + the Mac sync runbook vault asset
- config/flags/compose: vault_archive_days, vault_report_enabled (flags card),
vault_kb_enabled (flags card; NAS compose arms it, registry ships it off),
vault_kb_dirs (+ overlap/traversal validator), vault_kb_interval_seconds
- e2e smoke (tests/e2e_smoke/test_vault_v2.py): real create-seam, real janitor
cycle incl. archival + state, real KB engine + real guard
* docs: vault V2 sweep — map, RAG corpus, CLAUDE.md
- docs/map/vault.md: V1+V2 — janitor/archival/report/KB data flows, new files,
config, health posture
- docs/map/orchestrator.md + task-service.md: the two new loops, the create
seam, the three janitor queries
- docs/rag/architecture/obsidian-vault.md: agent-facing what-changed (notes
from creation, archive link-safety, CEO notes retrievable, weekly report)
- docs/rag/architecture/config-reference.md: the five new settings
- CLAUDE.md: vault paragraph covers V1+V2; flags-card list mentions the vault
report/KB flags
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
New map + RAG entries for the vault subsystem; sequence gate, lineage
merge, gate diff-base, CI guard, playwright MCP, dispatcher prefilter,
backup sidecar, and the 300/100 budget reflected across docs/map,
docs/rag, and CLAUDE.md; stale claims fixed (agent-ux 'no extra tools',
old budget defaults). No redirects needed — nothing publicly published
moved.
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
