2 Commits

Include renames

Author	SHA1	Message	Date
3 people	d1cf6ecbf3	Wave 1: PR-gate turn cut, task search, trace timestamps, Secretary edits + e2e scenarios 2–3 (#295) ... * feat(tests): e2e scenario 2 — the PM merge chain through the PR gate Shared arcs extracted (arcs.py: canonical-company seeding + dev/qa/doc segments); scenario 2 seeds a root->cell->dev hierarchy mid-flight, rides the child through the scenario-1 arc into the cell branch (real squash via the fake GitHub), then submit_up -> claim_gate_review/pr_pass -> dispatcher re-claim (mirrored) -> PM complete merging cell->root. This is the exact PM->reviewer->PM turn sequence the wave-1 turn cut shortens — the BEFORE-net. Learned seams scripted: commit-subject validator (>=20 chars), reviewer learning-note gate, pr_pass clears ownership by design. * feat(runtime): PR-gate turn cut — assembled parents auto-submit to the reviewer When every child of an assembled parent is terminal, the closure dispatcher now runs the real submit_up/submit_root through the internal API as the owning PM (_try_auto_submit) instead of spawning the PM for that turn — the submit's substance is deterministic gate code. Any gate refusal falls back to the classic PM closure spawn; pr_fail routing and the PM's final merge turn are unchanged; umbrellas never auto-submit. ROBOCO_PR_GATE_AUTO_SUBMIT_ENABLED default-on; task.auto_submitted audit row per cut. Proven by e2e scenario 2b (real API, real gates, real git) against scenario 2 as the before-net. * feat(notes): structured note sections carry a written_at trace stamp Sections are overwrite-in-place, so without a stamp there was no way to reconstruct WHEN a dev/qa/doc/reviewer note landed (CEO reMarkable item: trace TIMESTAMPS). apply_structured_note stamps ISO written_at beside the model fields; the panel notes tab renders it next to each card title (pre-stamp rows render nothing). Progress updates, commits, and journal entries already carried timestamps — this was the one gap. * feat(tasks): server-side task search — title, details, and id prefix The task list's search box only matched titles client-side, and the trimmed summary payload deliberately carries no description — so keyword/details/id search was impossible in the browser by design. GET /tasks/summary gains q (ILIKE over title+description, id-prefix match, composed with team/status and the view-permission scoping); the panel debounces the box into the summary fetch and drops the title-only client filter that would have hidden description matches. * feat(wave-1): trace timestamps, real task search, Secretary task edits - apply_structured_note stamps written_at per section; the panel notes tab shows it (the one trace surface without a timestamp). - GET /tasks/summary?q= searches title+description+id-prefix server-side (summaries carry no description by design); panel debounces into the fetch and drops the title-only client filter. - Secretary control_task gains a CEO-gated edit action over the content allowlist, and GET /secretary/tasks?q= resolves task names to ids for the chat. PM-side expansion deferred per the CEO's 'not that much'. * fix(workspace): dep-update probe scrubs the inherited venv pin Under uv run the orchestrator's process tree carries VIRTUAL_ENV, and a uv-based dep_update_command in the throwaway probe clone would target that venv instead of the clone's — the same hazard _uv_subprocess_env already guards on the install path. * build: private per-repo uv cache — isolate from machine-wide uvx servers Root cause of the recurring rich/pip/bandit rot, with evidence: uv cache clean timed out on the ~/.cache/uv lock ('is another uv process running?') — three uvx mcp-server-fetch processes (Claude Code fetch MCP, one alive since Wednesday) share that cache and race repo syncs on it; poisoned entries then survive venv rebuilds because rm -rf .venv never touches the cache, and every re-link reproduces the breakage. UV_CACHE_DIR now pins <repo>/.uv-cache (gitignored). The earlier UV_NO_SYNC serialization stays as defense-in-depth but was not the whole story. * feat(tests): e2e scenario 3 — pr_fail revision loop + root→CEO chain 3a: reviewer pr_fail with a concrete issue -> needs_revision -> i_will_plan re-entry (full plan gates) -> real fix lands on the cell branch (the unchanged-PR hard gate refuses resubmit until it does) -> clean second pass -> merge. 3b: submit_root -> gate -> Main PM complete escalates the root to the CEO -> the REAL approve-and-merge endpoint squash-merges to the origin's master. Harness gains the tasks router, a seeded CEO identity, origin_commit, and a fake GitHub whose head.sha is recomputed live (real-GitHub semantics the unchanged gate reads). Seeds now encode the real shape: delivery roots are team=main_pm and planning-typed. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-07-02 21:05:50 +02:00
3 people	46d89b58fe	feat: company-in-a-box — goal-aware company layer (0.4.0) (#171) ... * feat(goals): company charter singleton — data layer (Business Goals slice 1) First slice of the company-in-a-box "Business Goals" phase: a single CEO-owned charter row (north star + objectives + constraints + operating policy) that will be injected into every agent's context_briefing so all work is goal-aware. - CompanyGoalsTable: singleton table (all-zeros id), JSON objectives / constraints / operating_policy, updated_at / updated_by. - migration 032: create + seed the singleton row (offline-renderable; column server-defaults fill an INSERT of just the id). - CompanyGoalsService: get() (empty defaults when unset) + upsert() (singleton, partial update, caller commits). - tests: empty defaults, roundtrip, singleton + partial-update preservation. Next slices (mapped, not yet built): briefing injection (BriefingInputs + build_context_briefing + EvidenceRepo), API route (GET any / PUT CEO-only), panel /goals page, and base/Board/PM prompt mentions. * feat(goals): inject the company charter into every agent briefing (slice 2) The charter is now goal-aware context for every agent: - BriefingInputs gains company_goals; build_context_briefing surfaces it. - EvidenceRepo.company_goals(): single-row lookup returning a COMPACT charter (north star + objectives + constraints + operating policy; audit columns dropped, lists capped) or None when unset, so an empty charter never bloats the per-verb briefing. - _briefing_for wires it into every context_briefing. Tests: briefing surfaces company_goals (defaults None); repo returns None for an absent/empty charter and the compact dict when set. * feat(goals): company charter API — GET any agent, PUT CEO-only (slice 3) - routes/company_goals.py: GET returns the charter (any authenticated agent — it drives every briefing); PUT is CEO-only (403 otherwise), partial update via model_dump(exclude_unset=True), explicit commit. - schemas/company_goals.py: response + partial-update models. - registered at /api/company-goals. - tests: GET open to any role, CEO update persists + is readable, non-CEO 403. * feat(goals): make the company charter actionable in agent prompts (slice 5) Agents already receive company_goals in the briefing (slice 2); now tell them to act on it: - base.md: universal "Align with the company charter" section — favour work and trade-offs that advance the objectives, honour the constraints, flag conflicts; never a license to leave your role. - board / main_pm / cell_pm: role-specific lines tying triage / cell-routing / subtask decomposition to the charter. Prompts are composed at spawn from base.md + roles/*.md directly (compose_prompt), so no _generated regeneration is needed. * feat(goals): company charter panel page (slice 4) CEO-facing editor for the charter at /company-goals: - lib/api/company-goals.ts: get / update (PUT) client. - company-goals-card.tsx: edit north star + constraints (one per line) + objectives / operating_policy (JSON, parsed + validated with toast errors); display derives from server state (no set-state-in-effect). - (dashboard)/company-goals/page.tsx + a "Company Goals" sidebar nav link. tsc --noEmit + eslint clean. Completes Phase 1 (Business Goals): data, briefing injection, API, prompts, panel. * fix(test): make test_app route assertions robust to FastAPI 0.137 _IncludedRouter FastAPI 0.137 stopped flattening include_router into app.routes — each include is now an _IncludedRouter (a BaseRoute with no .path), so `{r.path for r in app.routes}` raised AttributeError and the two router-registration tests failed (the bump arrived via the claude-agent-sdk update in uv.lock). Add _registered_paths(): OpenAPI schema paths (the stable public contract) plus each included router's prefix, which also covers the websocket /ws mount (never in the schema). Drops the now-incorrect type: ignore[attr-defined]. * feat(research): pluggable web search/fetch for Board + PM agents Add a provider-agnostic web-research capability so the Board and PMs can ground decisions in current external evidence the knowledge base can't answer. - ResearchService selects a provider adapter from config: Tavily, Brave, and Exa adapters plus a NullProvider that degrades gracefully when no key is set. Result count and fetched-content size are clamped to caps. - /api/research/search and /api/research/fetch: role-gated to Board + PMs (and the CEO), with a per-agent/day Redis quota that fails open. - roboco-search MCP server (web_search / web_fetch) calls those routes; the provider key stays server-side and agent containers never egress. Mounted per role by the orchestrator, behind a master switch. - Charter-aware prompt guidance for Board, Main PM, and Cell PM. Additive: with no key configured it is a no-op and the existing delivery lifecycle is unchanged. * feat(pitch): Board pitch -> CEO approve -> auto-provision repos Add an additive origination path so a product can be proposed, approved, and stood up without manual repo/Project setup. - Pitch entity + migration (pitches table); PitchService create/list/ reject/approve. - GitHubProvisioningService: the one place that creates repos (POST /orgs/{org}/repos). Server-side token/org; when unconfigured the whole approve path is inert and nothing is created. - On approval: provision one repo per target cell, register a Project per repo, create a Product when multi-cell, and seed one Main-PM delivery task — all reusing the existing Product / coordination-task machinery. - /api/pitches: Board authors (PO/HoM), CEO approves/rejects, Board+PM+CEO view. Errors mapped via a single translator. Additive: the delivery lifecycle is untouched; with no provisioning token the capability is a no-op. Agent-facing pitch tool + panel are follow-ups. * feat(strategy): dormant autonomous strategy engine (engine 2) Add a second, optional engine that watches the company against its standing goals and surfaces what needs the CEO — without touching the delivery lifecycle (engine 1). - StrategyEngine.assess() reports observations: the company is idle while goals stand, and tasks stranded in 'blocked' past a threshold. - run_cycle() notifies the CEO (notify-only; it never spends, builds, or auto-approves — originating work stays a CEO decision). - Orchestrator runs it on its own interval, started/stopped with the other background loops; the loop returns immediately unless enabled. DORMANT by default (strategy_engine_enabled=False): the loop never runs and a standard deployment is unchanged. Auto-origination is a further opt-in. * docs(changelog): record Business Goals, Web Research, Pitch->Provision, and the dormant strategy engine under Unreleased * feat(secretary): wire the Secretary role end-to-end (foundation) Add SECRETARY as a distinct role — the CEO's conversational chief-of-staff, governed separately from the Prompter (which stays read-only/human-only). This is the role foundation only; authority, the live agent, and the panel land in following commits. - foundation/identity: Role.SECRETARY (board level), seeded secretary-1 agent, role-level mapping. - journaling read tier (ALL — it advises the CEO), role_config entry, per-role model (opus), prompt-layer mapping + roles/secretary.md. - i_am_idle gains SECRETARY so the role has a verb surface. - migration 034: add 'secretary' to the agentrole enum (mirrors 025). - Role-registry tests updated for the new role. Inert by itself (nothing spawns it yet); additive — existing roles unchanged. * feat(secretary): directives + gate-list authority (backend) The Secretary acts only under CEO command. Low-risk directives (relay a dictated message) execute immediately; high-impact ones — charter edits, task start/cancel/override, pitch approval, announcements — are recorded pending and run only after the CEO confirms (the gate list). - secretary_directives table (migration 035) as the command audit + queue. - SecretaryService: read company state; submit (direct->run, gated->queue + notify CEO); confirm/reject; execution runs with the CEO as actor through the existing services (the Secretary never holds CEO authority itself). - /api/secretary: submit + state/task reads (Secretary or CEO); list/confirm/ reject (CEO only). Writes commit explicitly. * feat(secretary): live conversational agent (container + bridge) Stand up the Secretary as a persistent Claude-SDK container the CEO chats with, mirroring the Intake agent and reusing its driver/session machinery. - secretary_driver: build_secretary_options exposes read_company_state / read_task / submit_directive as SDK tools that call /api/secretary/* with the agent's HMAC token; backend-call logic is module-level + tested. - secretary_main: container entrypoint (receiver + relay) reusing IntakeDriver. - orchestrator: start/spawn/reap secretary session + run-cmd builder; no workspace clone (reads state via API), mints a role=secretary token. - secretary_live routes: panel <-> container bridge over the live registry. - agent-secretary image (Dockerfile + compose build service). Inert until a session is started; additive — intake and all agents unchanged. * feat(secretary): panel chat + directive confirmation queue The CEO's Secretary surface: a live chat (SSE) to talk to the Secretary, and a 'Needs your confirmation' queue listing gated directives the Secretary proposed — each with Confirm / Reject. Adds the sidebar nav entry. - lib/api/secretary.ts: live (start/stream/status/send/stop) + directive (list/confirm/reject) + state clients (all as the CEO). - hooks/use-secretary.ts: drives one chat, accumulating SSE token deltas. - secretary page: chat pane + pending-directive cards. Completes the Secretary end-to-end (role + authority + live agent + panel). * feat(pitch): agent-facing pitch tool + pitches panel Complete the pitch path: the Board can now author pitches through the gateway, and the CEO reviews/approves them in the panel. - content_actions.pitch (Board-only) -> PitchService.create, returning an Envelope; wired as a do-tool (do_server + /api/v1/do/pitch + schema) and added to the Board's do-tools. - Panel /pitches page: lists pitches with CEO Approve & provision / Reject; sidebar nav entry. Pitch (Phase 4) is now end-to-end: author -> CEO approve -> auto-provision. * feat(cockpit): read-only 'is the business winning?' summary A pure aggregation for the CEO over existing data — no new state, no writes. - CockpitService.summary(): charter north-star/objectives, delivery counts (in-flight/blocked/awaiting-CEO), 30-day spend vs the charter's budget cap, pending pitches, and the strategy engine's signals (what needs you). Stamped basis='proxy' — performance is a proxy until real launches. - GET /api/cockpit/summary (CEO / Board / Main PM / Secretary). - Panel /cockpit page + sidebar nav. Reuses goals + usage + StrategyEngine.assess(); reads only. * docs(changelog): add the Secretary and Cockpit to Unreleased * fix(test): isolate the company-goals empty-defaults test from committed state The shared test DB persists committed writes across tests; a route test commits a charter, so the unit test's 'unset' assertion must establish its own clean precondition rather than assume global emptiness. * fix(gateway): lower evidence_repo complexity to rank A (xenon gate) company_goals()'s 4-way `or` emptiness check tipped the module average to rank B; `any(...)` is equivalent and keeps the module under the gate's A bar. * chore(compose): mirror agent-secretary-image build into docker-compose.yaml Both compose files are byte-identical and tracked; .yaml carries the same agent-secretary-image build service already present in docker-compose.yml. * chore(lifecycle): regenerate artifacts for secretary i_am_idle The secretary role gained i_am_idle in the lifecycle spec; regenerate the generated prompt/doc/json artifacts so foundation-check stays green. * docs(changelog): cut the company-in-a-box phases to 0.4.0 Label the six additive phases (business goals, web research, pitch-provision, strategy engine, secretary, cockpit) as 0.4.0; tag v0.4.0 is held until the branch merges to master so it points at the release commit. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>	2026-06-15 20:47:41 +02:00