External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[chore] remove all remaining type:ignore suppressions from tests/

Browse Source 
Converts 115 `# type: ignore[...]` suppressions across 23 test files to
no-suppression patterns (helper-return widening to Any, local Any aliases,
cc:Any aliases, cast at narrow call sites, typed fixtures) so the hard
no-type:ignore convention holds across tests/. No test logic or assertions
changed — only mock-wiring mechanics and type annotations.

Gate: ruff check tests/ clean; mypy tests/ (538 files) clean; 176 changed-file
tests pass. Zero real suppressions remain (the 7 grep hits are 3 hygiene-
checker string-literal test inputs and 4 prose mentions in comments).
This commit is contained in:
Renn F
2026-06-28 17:00:20 +02:00
parent 4d4bf084c5
commit f826285651
23 changed files with 177 additions and 175 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/mcp_servers/test_do_server.py
+8 -7
View File
@@ -5,6 +5,7 @@ from __future__ import annotations
import json
import tempfile
from pathlib import Path
from typing import Any
from unittest.mock import MagicMock, patch
import pytest
@@ -29,7 +30,7 @@ _DO_TEST_MANIFEST = {
@pytest.fixture
def do_module(monkeypatch): # type: ignore[no-untyped-def]
def do_module(monkeypatch: pytest.MonkeyPatch) -> Any:
monkeypatch.setenv("ROBOCO_AGENT_ID", "00000000-0000-0000-0000-000000000001")
monkeypatch.setenv("ROBOCO_AGENT_ROLE", "developer")
monkeypatch.setenv("ROBOCO_ORCHESTRATOR_URL", "http://test-orchestrator:8000")
@@ -44,7 +45,7 @@ def do_module(monkeypatch): # type: ignore[no-untyped-def]
return srv
def test_commit_posts_message_and_files(do_module): # type: ignore[no-untyped-def]
def test_commit_posts_message_and_files(do_module: Any) -> None:
fake_client = MagicMock()
fake_client.__enter__.return_value = fake_client
fake_response = MagicMock()
@@ -60,7 +61,7 @@ def test_commit_posts_message_and_files(do_module): # type: ignore[no-untyped-d
assert kwargs["json"] == {"message": "feat(api): add /healthz", "files": ["foo.py"]}
def test_note_default_scope_note(do_module): # type: ignore[no-untyped-def]
def test_note_default_scope_note(do_module: Any) -> None:
fake_client = MagicMock()
fake_client.__enter__.return_value = fake_client
fake_response = MagicMock()
@@ -74,7 +75,7 @@ def test_note_default_scope_note(do_module): # type: ignore[no-untyped-def]
assert kwargs["json"]["scope"] == "note"
def test_note_with_scope_reflect(do_module): # type: ignore[no-untyped-def]
def test_note_with_scope_reflect(do_module: Any) -> None:
fake_client = MagicMock()
fake_client.__enter__.return_value = fake_client
fake_response = MagicMock()
@@ -88,7 +89,7 @@ def test_note_with_scope_reflect(do_module): # type: ignore[no-untyped-def]
assert kwargs["json"]["scope"] == "reflect"
def test_say_posts_channel_and_text(do_module): # type: ignore[no-untyped-def]
def test_say_posts_channel_and_text(do_module: Any) -> None:
fake_client = MagicMock()
fake_client.__enter__.return_value = fake_client
fake_response = MagicMock()
@@ -106,7 +107,7 @@ def test_say_posts_channel_and_text(do_module): # type: ignore[no-untyped-def]
}
def test_dm_posts_all_fields(do_module): # type: ignore[no-untyped-def]
def test_dm_posts_all_fields(do_module: Any) -> None:
fake_client = MagicMock()
fake_client.__enter__.return_value = fake_client
fake_response = MagicMock()
@@ -125,7 +126,7 @@ def test_dm_posts_all_fields(do_module): # type: ignore[no-untyped-def]
}
def test_evidence_posts_task_id(do_module): # type: ignore[no-untyped-def]
def test_evidence_posts_task_id(do_module: Any) -> None:
fake_client = MagicMock()
fake_client.__enter__.return_value = fake_client
fake_response = MagicMock()