mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[d8a2999b] CI-watch: fix the CI regression on roboco-api (#364)
* [ffcc7317] fix(tests): tolerate tagless checkouts in release-readiness smoke test (#362) (#363) Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> * docs: reflow panel/UPGRADE.md — no hard-wrapped prose --------- Co-authored-by: Backend Developer 1 <be-dev-1@roboco.tech> Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
co-authored by
Backend Developer 1
Renn F
parent
0888fefdac
commit
ec5323917e
+2
-2
@@ -29,7 +29,7 @@ When you bump the `next` package, **always update `eslint-config-next` to match*
|
|||||||
cd panel
|
cd panel
|
||||||
pnpm install
|
pnpm install
|
||||||
```
|
```
|
||||||
This updates `pnpm-lock.yaml` while preserving `node_modules`, keeping the resolution deterministic.
|
This updates `pnpm-lock.yaml` while preserving `node_modules`, keeping the resolution deterministic.
|
||||||
|
|
||||||
3. **Run the quality gate:**
|
3. **Run the quality gate:**
|
||||||
```bash
|
```bash
|
||||||
@@ -39,7 +39,7 @@ When you bump the `next` package, **always update `eslint-config-next` to match*
|
|||||||
pnpm test
|
pnpm test
|
||||||
pnpm build
|
pnpm build
|
||||||
```
|
```
|
||||||
All must pass with no errors before committing.
|
All must pass with no errors before committing.
|
||||||
|
|
||||||
4. **Commit the changes:**
|
4. **Commit the changes:**
|
||||||
```bash
|
```bash
|
||||||
|
|||||||
@@ -161,7 +161,14 @@ def test_gather_snapshot_reads_the_real_repo() -> None:
|
|||||||
snap = gather_snapshot(root, master_ci_conclusion=None)
|
snap = gather_snapshot(root, master_ci_conclusion=None)
|
||||||
# The repo version moves with each release — assert it's a semver, not a literal.
|
# The repo version moves with each release — assert it's a semver, not a literal.
|
||||||
assert re.fullmatch(r"\d+\.\d+\.\d+", snap.current_version)
|
assert re.fullmatch(r"\d+\.\d+\.\d+", snap.current_version)
|
||||||
assert snap.last_tag is not None
|
# last_tag depends on the ambient checkout, not on gather_snapshot's logic:
|
||||||
|
# agent dev/QA workspaces clone with --no-tags by design (workspace.py's
|
||||||
|
# _clone_repo), so git describe legitimately finds nothing there, while CI
|
||||||
|
# (ci.yml pins fetch-tags: true) and the production release-manager read
|
||||||
|
# clone (workspace.py's _sync_read_clone) both fetch tags explicitly.
|
||||||
|
# Assert the shape wherever a tag IS present instead of assuming one
|
||||||
|
# always exists, so this stays meaningful in both kinds of checkout.
|
||||||
|
assert snap.last_tag is None or re.fullmatch(r"v\d+\.\d+\.\d+", snap.last_tag)
|
||||||
assert isinstance(snap.commits, list)
|
assert isinstance(snap.commits, list)
|
||||||
assert "pyproject.toml" in snap.canonical_bump_files
|
assert "pyproject.toml" in snap.canonical_bump_files
|
||||||
assert snap.changelog_text # CHANGELOG.md is non-empty
|
assert snap.changelog_text # CHANGELOG.md is non-empty
|
||||||
|
|||||||
Reference in New Issue
Block a user