From e66a79a8ec21dd7438b37b4990339c0ed02dd4a2 Mon Sep 17 00:00:00 2001 From: Renn F Date: Tue, 16 Jun 2026 04:55:04 +0200 Subject: [PATCH] fix(gateway): align ChoreographerHelpers._briefing_for stub with impl MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The spec-2 change added `include_ac_coverage` to Choreographer._briefing_for (_impl.py) but not to the typed stub in _protocol.py that the role mixins inherit for static analysis. The composed Choreographer (board/doc/qa mixins + _LegacyChoreographer) then had two incompatible _briefing_for signatures in its MRO — caught by full `mypy roboco/ tests/` (not by a per-file check). Add the same keyword to the stub. mypy clean at CI scope (648 files). --- roboco/services/gateway/choreographer/_protocol.py | 1 + 1 file changed, 1 insertion(+) diff --git a/roboco/services/gateway/choreographer/_protocol.py b/roboco/services/gateway/choreographer/_protocol.py index cf987c74..0d6a6909 100644 --- a/roboco/services/gateway/choreographer/_protocol.py +++ b/roboco/services/gateway/choreographer/_protocol.py @@ -59,6 +59,7 @@ class ChoreographerHelpers: task_id: UUID | None, *, task: Any | None = None, + include_ac_coverage: bool = False, ) -> dict[str, Any]: raise NotImplementedError