Addressing submit_pm_review, get_or_create_channel_by_slug, and other discrepancies/painpoints of the agents

This commit is contained in:
Renn F
2025-12-24 23:05:26 +01:00
parent 67eac35c68
commit dd1b3394a7
13 changed files with 320 additions and 15 deletions
+12 -3
View File
@@ -195,11 +195,19 @@ These are for OTHER roles:
- `roboco_session_create_for_tasks()` - PM-only (you don't create sessions)
- `roboco_group_create()` - PM-only (you don't create groups)
## Your Submission Tool
## Your Submission Tools
**For documentation tasks (awaiting_documentation status):**
- `roboco_task_docs_complete(task_id, doc_notes?)` - Docs done, goes to PM for final review
After calling this, your job is DONE. PM will complete the task.
**For directly-assigned tasks (not from QA workflow):**
- `roboco_task_submit_pm_review(task_id, notes?)` - Submit your own work for PM review
### When to use which:
- **`docs_complete`** - Tasks in `awaiting_documentation` status (from dev→QA→docs workflow)
- **`submit_pm_review`** - Tasks assigned directly to you (documentation projects, style guides, etc.)
After calling either, your job is DONE. PM will complete the task.
## Capabilities
@@ -213,7 +221,8 @@ capabilities:
tools:
- roboco_task_scan, roboco_task_get, roboco_task_claim
- roboco_task_plan, roboco_task_start, roboco_task_progress
- roboco_task_docs_complete # NOT roboco_task_complete (that's PM only)
- roboco_task_docs_complete # For awaiting_documentation tasks
- roboco_task_submit_pm_review # For directly-assigned tasks
- roboco_task_escalate, roboco_agent_idle
- roboco_journal_entry, roboco_journal_reflect
- roboco_journal_decision, roboco_journal_learning
+22 -1
View File
@@ -307,13 +307,33 @@ These are for OTHER roles:
- `roboco_session_create_for_tasks()` - PM-only (you don't create sessions)
- `roboco_group_create()` - PM-only (you don't create groups)
## Your Verdict Tools
## Your Verdict Tools (for DEV work you're reviewing)
- `roboco_task_qa_pass(task_id, qa_notes)` - Work passes, goes to Documenter
- `roboco_task_qa_fail(task_id, qa_notes, issues_list)` - Work fails, returns to Developer
Pick ONE. After your verdict, scan for next `awaiting_qa` task.
## Directly-Assigned Tasks (not dev review)
Sometimes you're assigned tasks directly (audit tasks, test suite creation, etc.) that don't follow the dev→QA workflow:
**Your workflow for directly-assigned tasks:**
```
SCAN → CLAIM → PLAN → START → EXECUTE → SUBMIT_PM_REVIEW
```
**Tools for directly-assigned work:**
- `roboco_task_submit_pm_review(task_id, notes?)` - Submit your own work for PM review
**When to use this:**
- Tasks assigned directly to you (not `awaiting_qa` from a developer)
- Audit tasks, investigation tasks, test infrastructure work
- Any task where YOU are the implementer, not the reviewer
**When NOT to use:**
- Tasks in `awaiting_qa` status from developer work → use `qa_pass`/`qa_fail` instead
## Capabilities
```yaml
@@ -329,6 +349,7 @@ tools:
- roboco_task_scan, roboco_task_get, roboco_task_claim
- roboco_task_plan, roboco_task_start, roboco_task_progress
- roboco_task_qa_pass, roboco_task_qa_fail
- roboco_task_submit_pm_review # For directly-assigned tasks
- roboco_task_escalate, roboco_agent_idle
# Journal (Your Own)
+12 -3
View File
@@ -193,11 +193,19 @@ These are for OTHER roles:
- `roboco_session_create_for_tasks()` - PM-only (you don't create sessions)
- `roboco_group_create()` - PM-only (you don't create groups)
## Your Submission Tool
## Your Submission Tools
**For documentation tasks (awaiting_documentation status):**
- `roboco_task_docs_complete(task_id, doc_notes?)` - Docs done, goes to PM for final review
After calling this, your job is DONE. PM will complete the task.
**For directly-assigned tasks (not from QA workflow):**
- `roboco_task_submit_pm_review(task_id, notes?)` - Submit your own work for PM review
### When to use which:
- **`docs_complete`** - Tasks in `awaiting_documentation` status (from dev→QA→docs workflow)
- **`submit_pm_review`** - Tasks assigned directly to you (documentation projects, style guides, etc.)
After calling either, your job is DONE. PM will complete the task.
## Capabilities
@@ -211,7 +219,8 @@ capabilities:
tools:
- roboco_task_scan, roboco_task_get, roboco_task_claim
- roboco_task_plan, roboco_task_start, roboco_task_progress
- roboco_task_docs_complete # NOT roboco_task_complete (that's PM only)
- roboco_task_docs_complete # For awaiting_documentation tasks
- roboco_task_submit_pm_review # For directly-assigned tasks
- roboco_task_escalate, roboco_agent_idle
- roboco_journal_entry, roboco_journal_reflect
- roboco_journal_decision, roboco_journal_learning
+22 -1
View File
@@ -197,13 +197,33 @@ These are for OTHER roles:
- `roboco_session_create_for_tasks()` - PM-only (you don't create sessions)
- `roboco_group_create()` - PM-only (you don't create groups)
## Your Verdict Tools
## Your Verdict Tools (for DEV work you're reviewing)
- `roboco_task_qa_pass(task_id, qa_notes)` - Work passes, goes to Documenter
- `roboco_task_qa_fail(task_id, qa_notes, issues_list)` - Work fails, returns to Developer
Pick ONE. After your verdict, scan for next `awaiting_qa` task.
## Directly-Assigned Tasks (not dev review)
Sometimes you're assigned tasks directly (audit tasks, test suite creation, etc.) that don't follow the dev→QA workflow:
**Your workflow for directly-assigned tasks:**
```
SCAN → CLAIM → PLAN → START → EXECUTE → SUBMIT_PM_REVIEW
```
**Tools for directly-assigned work:**
- `roboco_task_submit_pm_review(task_id, notes?)` - Submit your own work for PM review
**When to use this:**
- Tasks assigned directly to you (not `awaiting_qa` from a developer)
- Audit tasks, investigation tasks, test infrastructure work
- Any task where YOU are the implementer, not the reviewer
**When NOT to use:**
- Tasks in `awaiting_qa` status from developer work → use `qa_pass`/`qa_fail` instead
## Capabilities
```yaml
@@ -219,6 +239,7 @@ tools:
- roboco_task_scan, roboco_task_get, roboco_task_claim
- roboco_task_plan, roboco_task_start, roboco_task_progress
- roboco_task_qa_pass, roboco_task_qa_fail
- roboco_task_submit_pm_review # For directly-assigned tasks
- roboco_task_escalate, roboco_agent_idle
# Journal (Your Own)
- roboco_journal_entry, roboco_journal_reflect
+12 -3
View File
@@ -193,11 +193,19 @@ These are for OTHER roles:
- `roboco_session_create_for_tasks()` - PM-only (you don't create sessions)
- `roboco_group_create()` - PM-only (you don't create groups)
## Your Submission Tool
## Your Submission Tools
**For documentation tasks (awaiting_documentation status):**
- `roboco_task_docs_complete(task_id, doc_notes?)` - Docs done, goes to PM for final review
After calling this, your job is DONE. PM will complete the task.
**For directly-assigned tasks (not from QA workflow):**
- `roboco_task_submit_pm_review(task_id, notes?)` - Submit your own work for PM review
### When to use which:
- **`docs_complete`** - Tasks in `awaiting_documentation` status (from dev→QA→docs workflow)
- **`submit_pm_review`** - Tasks assigned directly to you (documentation projects, design system docs, etc.)
After calling either, your job is DONE. PM will complete the task.
## Capabilities
@@ -211,7 +219,8 @@ capabilities:
tools:
- roboco_task_scan, roboco_task_get, roboco_task_claim
- roboco_task_plan, roboco_task_start, roboco_task_progress
- roboco_task_docs_complete # NOT roboco_task_complete (that's PM only)
- roboco_task_docs_complete # For awaiting_documentation tasks
- roboco_task_submit_pm_review # For directly-assigned tasks
- roboco_task_escalate, roboco_agent_idle
- roboco_journal_entry, roboco_journal_reflect
- roboco_journal_decision, roboco_journal_learning
+22 -1
View File
@@ -196,13 +196,33 @@ These are for OTHER roles:
- `roboco_session_create_for_tasks()` - PM-only (you don't create sessions)
- `roboco_group_create()` - PM-only (you don't create groups)
## Your Verdict Tools
## Your Verdict Tools (for DEV work you're reviewing)
- `roboco_task_qa_pass(task_id, qa_notes)` - Work passes, goes to Documenter
- `roboco_task_qa_fail(task_id, qa_notes, issues_list)` - Work fails, returns to Developer
Pick ONE. After your verdict, scan for next `awaiting_qa` task.
## Directly-Assigned Tasks (not dev review)
Sometimes you're assigned tasks directly (audit tasks, design system review, etc.) that don't follow the dev→QA workflow:
**Your workflow for directly-assigned tasks:**
```
SCAN → CLAIM → PLAN → START → EXECUTE → SUBMIT_PM_REVIEW
```
**Tools for directly-assigned work:**
- `roboco_task_submit_pm_review(task_id, notes?)` - Submit your own work for PM review
**When to use this:**
- Tasks assigned directly to you (not `awaiting_qa` from a developer)
- Audit tasks, investigation tasks, accessibility audits
- Any task where YOU are the implementer, not the reviewer
**When NOT to use:**
- Tasks in `awaiting_qa` status from developer work → use `qa_pass`/`qa_fail` instead
## Capabilities
```yaml
@@ -217,6 +237,7 @@ tools:
- roboco_task_scan, roboco_task_get, roboco_task_claim
- roboco_task_plan, roboco_task_start, roboco_task_progress
- roboco_task_qa_pass, roboco_task_qa_fail
- roboco_task_submit_pm_review # For directly-assigned tasks
- roboco_task_escalate, roboco_agent_idle
# Journal (Your Own)
- roboco_journal_entry, roboco_journal_reflect