feat(marketing): HoM feature-spotlight X drafts + brand-voice charter (v0.18.0 B)

The Head of Marketing now markets features, not just releases: a default-off
x_feature_spotlight loop periodically spawns the HoM to investigate what shipped
(CHANGELOG, feature flags, docs/map, KB) and draft ONE held marketing post via
propose_feature_spotlight, reviewed in the X post queue.

- New x_feature source (distinct from x_post, fixing panel mislabeling) + a
  panel Feature-spotlight branch.
- brand_voice column on company_goals (migration 061, single head) as the
  CEO-editable voice source, surfaced in Settings and injected into the HoM
  briefing; a VOICE GUIDE baseline in head-marketing.md.
- propose_feature_spotlight verb (HoM-only), mirroring propose_roadmap.

Gated by x_feature_spotlight_enabled (default off; flag-off dormancy proven).
Also fixed two real bugs found mid-build: company_goals API schemas dropped
brand_voice on GET/PUT; the live charter UI is goals-tab.tsx, not the unmounted
company-goals-card.tsx. Full suite green (2935); migration single-head verified.

tests/unit/gateway/test_content_actions_feature_spotlight.py

@@ -0,0 +1,179 @@
+"""roboco.services.gateway.content_actions.propose_feature_spotlight — HoM-gated
+feature-spotlight draft authoring."""
+
+from __future__ import annotations
+
+from typing import Any
+from unittest.mock import AsyncMock, MagicMock
+from uuid import uuid4
+
+import pytest
+from roboco.services.gateway.content_actions import ContentActions, ContentActionsDeps
+
+
+class _FakeTask:
+    """Minimal stand-in for the ORM TaskTable row — carries just what
+    ``propose_feature_spotlight`` touches."""
+
+    def __init__(self, *, assigned_to: Any, task_id: Any = None) -> None:
+        self.id = task_id or uuid4()
+        self.assigned_to = assigned_to
+        self.project_id = uuid4()
+
+
+def _actions(role: str) -> ContentActions:
+    task = MagicMock()
+    agent = MagicMock()
+    agent.role = role
+    task.agent_for = AsyncMock(return_value=agent)
+    task.session = MagicMock()
+    deps = ContentActionsDeps(
+        task=task,
+        git=MagicMock(),
+        a2a=MagicMock(),
+        journal=MagicMock(),
+        workspace=MagicMock(),
+        notifications=MagicMock(),
+    )
+    return ContentActions(deps)
+
+
+def _valid_kwargs(**overrides: Any) -> dict[str, Any]:
+    kwargs: dict[str, Any] = {
+        "feature_slug": "org-memory",
+        "feature_title": "Organizational Memory Loop",
+        "body": "Did you know RoboCo agents learn from every completed task?",
+    }
+    kwargs.update(overrides)
+    return kwargs
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_forbidden_for_product_owner() -> None:
+    env = await _actions("product_owner").propose_feature_spotlight(
+        agent_id=uuid4(), **_valid_kwargs()
+    )
+    assert env.error == "not_authorized"
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_forbidden_for_developer() -> None:
+    env = await _actions("developer").propose_feature_spotlight(
+        agent_id=uuid4(), **_valid_kwargs()
+    )
+    assert env.error == "not_authorized"
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_rejects_short_slug() -> None:
+    env = await _actions("head_marketing").propose_feature_spotlight(
+        agent_id=uuid4(), **_valid_kwargs(feature_slug="a")
+    )
+    assert env.error == "invalid_state"
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_rejects_short_title() -> None:
+    env = await _actions("head_marketing").propose_feature_spotlight(
+        agent_id=uuid4(), **_valid_kwargs(feature_title="ab")
+    )
+    assert env.error == "invalid_state"
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_rejects_short_body() -> None:
+    env = await _actions("head_marketing").propose_feature_spotlight(
+        agent_id=uuid4(), **_valid_kwargs(body="short")
+    )
+    assert env.error == "invalid_state"
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_rejects_over_280_chars() -> None:
+    env = await _actions("head_marketing").propose_feature_spotlight(
+        agent_id=uuid4(), **_valid_kwargs(body="z" * 281)
+    )
+    assert env.error == "invalid_state"
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_no_open_exploration_is_invalid_state(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    task_svc = MagicMock()
+    task_svc.list_open_feature_explorations = AsyncMock(return_value=[])
+    monkeypatch.setattr("roboco.services.task.get_task_service", lambda _s: task_svc)
+    env = await _actions("head_marketing").propose_feature_spotlight(
+        agent_id=uuid4(), **_valid_kwargs()
+    )
+    assert env.error == "invalid_state"
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_ignores_exploration_assigned_to_another_agent(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    other_agent = uuid4()
+    exploration = _FakeTask(assigned_to=other_agent)
+    task_svc = MagicMock()
+    task_svc.list_open_feature_explorations = AsyncMock(return_value=[exploration])
+    monkeypatch.setattr("roboco.services.task.get_task_service", lambda _s: task_svc)
+    env = await _actions("head_marketing").propose_feature_spotlight(
+        agent_id=uuid4(), **_valid_kwargs()
+    )
+    assert env.error == "invalid_state"
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_rejects_already_seen_feature(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    agent_id = uuid4()
+    exploration = _FakeTask(assigned_to=agent_id)
+    task_svc = MagicMock()
+    task_svc.list_open_feature_explorations = AsyncMock(return_value=[exploration])
+    monkeypatch.setattr("roboco.services.task.get_task_service", lambda _s: task_svc)
+
+    engine = MagicMock()
+    engine.is_feature_seen = AsyncMock(return_value=True)
+    monkeypatch.setattr("roboco.services.x_engine.get_x_engine", lambda _s: engine)
+
+    env = await _actions("head_marketing").propose_feature_spotlight(
+        agent_id=agent_id, **_valid_kwargs()
+    )
+    assert env.error == "invalid_state"
+    engine.materialize_feature_spotlight.assert_not_called()
+
+
+@pytest.mark.asyncio
+async def test_propose_feature_spotlight_materializes_new_draft_task(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    """Happy path — deliberately asymmetric vs. propose_roadmap: the returned
+    task_id is the NEW materialized draft's id, never the exploration task's."""
+    agent_id = uuid4()
+    exploration = _FakeTask(assigned_to=agent_id)
+    task_svc = MagicMock()
+    task_svc.list_open_feature_explorations = AsyncMock(return_value=[exploration])
+    monkeypatch.setattr("roboco.services.task.get_task_service", lambda _s: task_svc)
+
+    materialized = _FakeTask(assigned_to=agent_id)
+    assert materialized.id != exploration.id
+    engine = MagicMock()
+    engine.is_feature_seen = AsyncMock(return_value=False)
+    engine.materialize_feature_spotlight = AsyncMock(return_value=materialized)
+    monkeypatch.setattr("roboco.services.x_engine.get_x_engine", lambda _s: engine)
+
+    env = await _actions("head_marketing").propose_feature_spotlight(
+        agent_id=agent_id, **_valid_kwargs()
+    )
+    assert env.error is None
+    assert env.status == "feature_spotlight_proposed"
+    assert env.task_id == str(materialized.id)
+    assert env.task_id != str(exploration.id)
+    engine.materialize_feature_spotlight.assert_awaited_once_with(
+        exploration_task=exploration,
+        feature_slug="org-memory",
+        feature_title="Organizational Memory Loop",
+        body="Did you know RoboCo agents learn from every completed task?",
+    )

tests/unit/gateway/test_evidence_repo.py

@@ -55,7 +55,11 @@ async def test_company_goals_none_when_no_row() -> None:
 @pytest.mark.asyncio
 async def test_company_goals_none_when_empty_charter() -> None:
     row = SimpleNamespace(
-        north_star="", objectives=[], constraints=[], operating_policy={}
+        north_star="",
+        objectives=[],
+        constraints=[],
+        operating_policy={},
+        brand_voice="",
     )
     assert await _repo_with_goals_row(row).company_goals() is None
 
@@ -67,6 +71,7 @@ async def test_company_goals_compact_dict_when_set() -> None:
         objectives=[{"metric": "NPS", "target": 50}],
         constraints=["AGPL"],
         operating_policy={"autonomy_level": "assisted"},
+        brand_voice="Confident, dry wit.",
     )
     goals = await _repo_with_goals_row(row).company_goals()
     assert goals == {
@@ -74,9 +79,42 @@ async def test_company_goals_compact_dict_when_set() -> None:
         "objectives": [{"metric": "NPS", "target": 50}],
         "constraints": ["AGPL"],
         "operating_policy": {"autonomy_level": "assisted"},
+        "brand_voice": "Confident, dry wit.",
     }
 
 
+@pytest.mark.asyncio
+async def test_company_goals_none_when_only_brand_voice_unset() -> None:
+    """A charter with substantive content but no brand_voice must still
+    surface — brand_voice is additive, not required."""
+    row = SimpleNamespace(
+        north_star="Win the market",
+        objectives=[],
+        constraints=[],
+        operating_policy={},
+        brand_voice="",
+    )
+    goals = await _repo_with_goals_row(row).company_goals()
+    assert goals is not None
+    assert goals["brand_voice"] == ""
+
+
+@pytest.mark.asyncio
+async def test_company_goals_surfaces_when_only_brand_voice_set() -> None:
+    """The inverse: brand_voice alone (everything else empty) must still
+    surface — it counts toward the "charter has content" check."""
+    row = SimpleNamespace(
+        north_star="",
+        objectives=[],
+        constraints=[],
+        operating_policy={},
+        brand_voice="Speak as 'we'.",
+    )
+    goals = await _repo_with_goals_row(row).company_goals()
+    assert goals is not None
+    assert goals["brand_voice"] == "Speak as 'we'."
+
+
 @pytest.mark.asyncio
 async def test_constructor_stores_db_session() -> None:
     fake_db = MagicMock()

tests/unit/gateway/test_feature_spotlight_role_grant.py

@@ -0,0 +1,18 @@
+"""propose_feature_spotlight is a Head-of-Marketing-only manifest grant
+(mirrors propose_roadmap's PO-only symmetry, reversed)."""
+
+from __future__ import annotations
+
+from roboco.services.gateway.role_config import get_role_config
+
+
+def test_head_marketing_gets_propose_feature_spotlight() -> None:
+    assert "propose_feature_spotlight" in get_role_config("head_marketing").do_tools
+
+
+def test_product_owner_does_not_get_propose_feature_spotlight() -> None:
+    assert "propose_feature_spotlight" not in get_role_config("product_owner").do_tools
+
+
+def test_developer_does_not_get_propose_feature_spotlight() -> None:
+    assert "propose_feature_spotlight" not in get_role_config("developer").do_tools