feat(vault): Obsidian vault V2 — janitor, archival, weekly report, KB ingest, Bases + sync runbook (#482)

* feat(vault): V2 — create-seam + drift janitor, archival, weekly org-report, KB ingest, Bases views + sync runbook

Implements the vault V2 canonical spec end to end (the splice guard shipped
separately and is reused at KB-ingest time):

- materialize-on-create: TaskService.create writes each task's note best-effort
  from the moment it exists; the transition-touch stops no-oping on live work
- drift janitor (services/vault_janitor.py + hourly _vault_janitor_loop): daily
  changed-task re-projection, random drift sample, archival pass — restart-proof
  via RoboCo/_meta/.janitor_state.json, 200/cycle caps, per-item isolation,
  processed-only resume markers, self-repairing state file
- archival: vault_archive_days (30, 0=off) moves old terminal tasks' notes to
  RoboCo/Archive/<year>/Tasks/<project>/ — one write_task code path for janitor
  and rebuild, id8 lookup across Tasks/+Archive/, alias links keep moves safe
- weekly org-report: VaultWriter.write_org_report renders Reports/<ISO-week>.md
  from MetricsService/UsageService (numbers duplicated into frontmatter for
  trend queries), once per ISO week, with a best-effort CEO notification
- KB ingest: IndexType.VAULT_NOTES + VaultNotesIndexPlugin + _vault_kb_loop
  embed the CEO's RoboCo/Notes into the RAG corpus — injection guard as a hard
  gate (flagged notes quarantined with an idempotent callout), traversal- and
  symlink-contained at both config and engine layers, content-hash dedup,
  50-ingest/cycle cap, frontmatter stripped; reaches roboco_kb_search, the
  mentor default domain, claim-time briefings (kind vault_note), and the panel
  KB browser; no migration (chunks table auto-creates; migration 030's
  CHUNK_TABLES tuple appended per the chunks_playbooks precedent)
- Bases views (Task Board.base, Reports.base — schema verified against the
  Obsidian docs) + the Mac sync runbook vault asset
- config/flags/compose: vault_archive_days, vault_report_enabled (flags card),
  vault_kb_enabled (flags card; NAS compose arms it, registry ships it off),
  vault_kb_dirs (+ overlap/traversal validator), vault_kb_interval_seconds
- e2e smoke (tests/e2e_smoke/test_vault_v2.py): real create-seam, real janitor
  cycle incl. archival + state, real KB engine + real guard

* docs: vault V2 sweep — map, RAG corpus, CLAUDE.md

- docs/map/vault.md: V1+V2 — janitor/archival/report/KB data flows, new files,
  config, health posture
- docs/map/orchestrator.md + task-service.md: the two new loops, the create
  seam, the three janitor queries
- docs/rag/architecture/obsidian-vault.md: agent-facing what-changed (notes
  from creation, archive link-safety, CEO notes retrievable, weekly report)
- docs/rag/architecture/config-reference.md: the five new settings
- CLAUDE.md: vault paragraph covers V1+V2; flags-card list mentions the vault
  report/KB flags

---------

Co-authored-by: Renn F <rennf93@users.noreply.github.com>

tests/unit/runtime/test_orchestrator_shutdown_drain.py

@@ -56,6 +56,8 @@ def _make_orchestrator() -> AgentOrchestrator:
         "_x_feature_spotlight_task",
         "_video_render_task",
         "_vault_intake_task",
+        "_vault_janitor_task",
+        "_vault_kb_task",
     ):
         setattr(orch, attr, None)
     return orch

tests/unit/runtime/test_vault_janitor_loop_dormant.py

@@ -0,0 +1,26 @@
+"""The vault-janitor orchestrator loop is fully dormant unless the vault
+umbrella flag is on (default off).
+
+With the flag off, ``_vault_janitor_loop`` must return immediately — no
+sleep, no DB, no filesystem access — so a standard deployment behaves
+exactly as today.
+"""
+
+from __future__ import annotations
+
+import asyncio
+import types
+from typing import cast
+
+import pytest
+from roboco.config import settings as cfg
+from roboco.runtime.orchestrator import AgentOrchestrator
+
+
+@pytest.mark.asyncio
+async def test_vault_janitor_loop_returns_immediately_when_flag_off(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setattr(cfg, "obsidian_vault_enabled", False)
+    stub = cast("AgentOrchestrator", types.SimpleNamespace(_running=True))
+    await asyncio.wait_for(AgentOrchestrator._vault_janitor_loop(stub), timeout=1.0)

tests/unit/runtime/test_vault_kb_loop_dormant.py

@@ -0,0 +1,47 @@
+"""The vault-KB orchestrator loop is fully dormant unless BOTH the vault AND
+KB-ingest flags are on (default).
+
+With either flag off, ``_vault_kb_loop`` must return immediately — no sleep,
+no DB, no filesystem scan — so a standard deployment behaves exactly as
+today.
+"""
+
+from __future__ import annotations
+
+import asyncio
+import types
+from typing import cast
+
+import pytest
+from roboco.config import settings as cfg
+from roboco.runtime.orchestrator import AgentOrchestrator
+
+
+@pytest.mark.asyncio
+async def test_vault_kb_loop_returns_immediately_when_both_flags_off(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setattr(cfg, "obsidian_vault_enabled", False)
+    monkeypatch.setattr(cfg, "vault_kb_enabled", False)
+    stub = cast("AgentOrchestrator", types.SimpleNamespace(_running=True))
+    await asyncio.wait_for(AgentOrchestrator._vault_kb_loop(stub), timeout=1.0)
+
+
+@pytest.mark.asyncio
+async def test_vault_kb_loop_returns_immediately_when_kb_flag_off(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setattr(cfg, "obsidian_vault_enabled", True)
+    monkeypatch.setattr(cfg, "vault_kb_enabled", False)
+    stub = cast("AgentOrchestrator", types.SimpleNamespace(_running=True))
+    await asyncio.wait_for(AgentOrchestrator._vault_kb_loop(stub), timeout=1.0)
+
+
+@pytest.mark.asyncio
+async def test_vault_kb_loop_returns_immediately_when_vault_flag_off(
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    monkeypatch.setattr(cfg, "obsidian_vault_enabled", False)
+    monkeypatch.setattr(cfg, "vault_kb_enabled", True)
+    stub = cast("AgentOrchestrator", types.SimpleNamespace(_running=True))
+    await asyncio.wait_for(AgentOrchestrator._vault_kb_loop(stub), timeout=1.0)