feat(lifecycle): revision findings ledger — structured failure feedback, persisted and delivered down the chain (#486)

* feat(lifecycle): revision findings ledger — structured QA/PR/PM/CEO failure feedback, persisted and delivered down the chain

Every bounce used to survive only as flattened prose: rounds overwrote each
other in notes_structured, request_changes persisted nothing, two raw
dev_notes appends were silently destroyed by the next handoff note, and the
dev prompt pointed at fields (qa_notes via evidence(), pm_notes) the API
never delivered. Agents re-interpreted and re-discovered every failure
before they could start fixing it.

- task_review_findings (migration 071, append-only): file/line/severity/
  criterion(AC-id-validated)/expected/actual/fix/evidence per finding, with
  origin (qa|pr_gate|pm|ceo), round, and an open->addressed->verified
  lifecycle (waived reserved); new tasks.pm_notes + PmReviewContent give
  request_changes a structured home
- producers: fail_review/pr_fail/request_changes take findings=[...] (prose
  issues shimmed+merged for one release, deprecation-logged); ceo_reject
  validates its reason (no 500), lands an origin=ceo finding, and bumps
  round+audit on branchless coordination roots; guardrails at the verb
  chokepoint (nudge >5, hard reject >10, field caps, traversal-safe file);
  the dev_notes data-loss appends are removed; new task.request_changes +
  task.ceo_reject audit events close rework attribution
- delivery: qa_notes/pr_reviewer_notes/pm_notes carry the deterministic
  [F-id8] rendering; claim briefings, evidence(), the REVISION_REQUIRED
  spawn prompt, PM triage bounced-blocks, and A2A bodies deliver open
  findings; round-N+1 QA and gate reviewers get the full prior ledger;
  panel Findings tab + bounced-xN chip; metrics pm_rejects/ceo_rejects +
  findings counts; vault task notes render a Findings section (fail-open)
- resolution closes for every origin: i_am_done and submit_up/submit_root
  take resolved_findings gated by FINDINGS_ADDRESSED (owner-gated so a
  stale non-owner PM can never mutate the ledger); pass_review/pr_pass/
  complete verify-stamp same-transaction; ceo_approve stamps best-effort
- 24 real-DB integration tests drive the full loop through the real
  choreographer; full suite 12856 green

* docs: revision findings ledger sweep — CLAUDE.md, map, RAG corpus

- CLAUDE.md: new ledger section + corrected request_changes row
- docs/map/review-findings.md (new subsystem map) + surgical updates to
  task-service/pr-gate-review/metrics-observability/vault/panel maps
- docs/rag: producers' findings contract across qa/pr-reviewer/developer/
  cell-pm/main-pm/ceo role docs (the PM docs were missing request_changes
  entirely), verb references, and a new architecture/review-findings.md
  disambiguating ledger findings from convention findings

* test(e2e): resubmit resolves the pr_fail finding per the ledger contract

The scripted pr_fail revision loop resubmitted submit_up without
resolved_findings — correctly rejected now that FINDINGS_ADDRESSED gates
the PM resubmit verbs (green locally, red only in CI since the e2e suite
skips without ROBOCO_E2E_SMOKE=1). The scripted PM now reads the open
ledger row pr_fail persisted (new open_finding_ids arc helper) and
resolves it on resubmit, asserting the open set drains — exercising the
coordinator half of the new contract end to end.

---------

Co-authored-by: Renn F <rennf93@users.noreply.github.com>

tests/unit/services/test_vault_writer.py

@@ -14,6 +14,7 @@ from roboco.services.vault_writer import (
     A2AMessageData,
     AgentNoteData,
     BottleneckRow,
+    FindingRow,
     JournalNoteData,
     OrgReportData,
     StageTimingRow,
@@ -362,3 +363,60 @@ def test_write_org_report_same_week_overwrites(tmp_path: Path) -> None:
     p2 = writer.write_org_report(_report_data())
     assert p1 == p2
     assert len(list((tmp_path / "RoboCo" / "Reports").glob("*.md"))) == 1
+
+
+# --- revision-findings ledger section -------------------------------------- #
+
+_FINDINGS_CAP = 20
+
+
+def test_write_task_omits_findings_section_when_empty(tmp_path: Path) -> None:
+    writer = VaultWriter(tmp_path)
+    text = writer.write_task(_task_data()).read_text(encoding="utf-8")
+    assert "## Findings" not in text
+
+
+def test_write_task_renders_findings_section(tmp_path: Path) -> None:
+    writer = VaultWriter(tmp_path)
+    finding = FindingRow(
+        id8="aaaaaaaa",
+        severity="blocker",
+        file="roboco/services/task.py",
+        line=42,
+        expected="the endpoint returns 404",
+        actual="the endpoint returns 500",
+        fix="add a not-found guard",
+        status="open",
+        round=2,
+    )
+    text = writer.write_task(_task_data(findings=(finding,))).read_text(
+        encoding="utf-8"
+    )
+    assert "## Findings" in text
+    assert "[F-aaaaaaaa] (blocker, round 2, open)" in text
+    assert "roboco/services/task.py:42" in text
+    assert (
+        "the endpoint returns 404 → the endpoint returns 500 → "
+        "add a not-found guard" in text
+    )
+
+
+def test_write_task_findings_capped_with_overflow_line(tmp_path: Path) -> None:
+    writer = VaultWriter(tmp_path)
+    many = tuple(
+        FindingRow(
+            id8=f"{i:08d}",
+            severity="minor",
+            file=None,
+            line=None,
+            expected="x",
+            actual="y",
+            fix=None,
+            status="open",
+            round=1,
+        )
+        for i in range(25)
+    )
+    text = writer.write_task(_task_data(findings=many)).read_text(encoding="utf-8")
+    assert text.count("[F-") == _FINDINGS_CAP
+    assert "5 more" in text