mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
fix(gateway): bounded fail-open evidence assembly + PM decision transient-failure bypass
Evidence-assembly git legs (diff, changed-files, branch fetch, advisory conventions run) ran unbounded inside claim_review / claim_doc_task / claim_gate_review / evidence() / i_am_done's envelope build, so a slow clone turned the whole verb into a silent 120s FlowVerbTimeout 504. Each leg now runs through run_bounded_leg under a shared LegBudget (evidence_assembly_timeout_seconds, 45s total): a timed-out leg — both asyncio TimeoutError and git's own GitTimeoutError — degrades into an evidence_gaps note on the envelope instead of hanging the verb, while non-timeout git errors still propagate. The advisory conventions run gets an inner-only timeout (conventions_validator_advisory_timeout_ seconds, 30s) threaded down to the subprocess so it is never orphaned by an outer cancel; the fail-closed i_am_done/pr_pass conventions gates keep their hardcoded 120s. _ensure_pm_decision now reports a PmDecisionOutcome: a transient DB failure recording the PM's decision journal (e.g. lock timeout under load) no longer launders into a journal:decision gate rejection that escalates and BLOCKS the task — the verb's own rationale satisfies the gate with a structured warning, across all seven PM verbs. Also: repo-wide ruff realignment to the lockfile-pinned ruff (8 format-only diffs, 14 UP038 isinstance conversions) that a transiently newer venv ruff had masked. Gate: 15474 passed, 459 skipped; ruff/mypy/xenon/vulture/bandit/ pip-audit/deptry/import-linter/foundation-check all green.
This commit is contained in:
@@ -884,7 +884,6 @@ async def test_soft_block_task_for_agent_full_flow(
|
||||
db_session: AsyncSession,
|
||||
monkeypatch: pytest.MonkeyPatch,
|
||||
) -> None:
|
||||
|
||||
svc = task_setup["svc"]
|
||||
task = await svc.create(_req(task_setup))
|
||||
task.assigned_to = task_setup["agent_id"]
|
||||
@@ -929,7 +928,6 @@ async def test_soft_block_task_for_agent_full_flow(
|
||||
async def test_docs_complete_for_task_invokes_notification(
|
||||
task_setup: dict, db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
|
||||
svc = task_setup["svc"]
|
||||
doc = AgentTable(
|
||||
id=uuid4(),
|
||||
@@ -988,7 +986,6 @@ async def test_docs_complete_for_task_invokes_notification(
|
||||
async def test_escalate_to_ceo_for_agent_invokes_notification(
|
||||
task_setup: dict, db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
|
||||
svc = task_setup["svc"]
|
||||
pm = AgentTable(
|
||||
id=uuid4(),
|
||||
@@ -1054,7 +1051,6 @@ async def test_escalate_to_ceo_for_agent_invokes_notification(
|
||||
async def test_claim_task_for_agent_commits_and_returns(
|
||||
task_setup: dict, db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
|
||||
svc = task_setup["svc"]
|
||||
task = await svc.create(_req(task_setup))
|
||||
task.branch_name = "feature/backend/x"
|
||||
@@ -1088,7 +1084,6 @@ async def test_claim_task_for_agent_commits_and_returns(
|
||||
async def test_complete_task_for_agent_commits(
|
||||
task_setup: dict, db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
|
||||
svc = task_setup["svc"]
|
||||
pm = AgentTable(
|
||||
id=uuid4(),
|
||||
@@ -1138,7 +1133,6 @@ async def test_complete_task_for_agent_commits(
|
||||
async def test_substitute_task_for_agent_runs_update(
|
||||
task_setup: dict, db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
|
||||
svc = task_setup["svc"]
|
||||
task = await svc.create(_req(task_setup))
|
||||
task.assigned_to = task_setup["agent_id"]
|
||||
|
||||
Reference in New Issue
Block a user