External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(notifications): task titles and agent slugs replace raw UUIDs (#616)

Browse Source 
* fix(notifications): task titles and agent slugs replace raw UUIDs

Notification producers interpolated raw task/agent UUIDs into subjects and
bodies ('Task 68e1e4db-... unblocked', 'handed back to 00000000-...-0004').
A tiny notification_text helper (task_display: title-first with a #id8
fallback; agent_display: identity-map slug first, DB lookup fallback) now
feeds every producer: all 13 NotificationService methods, the 7
delivery-service bodies whose subjects were already title-based, the
substitute-PM ad-hoc insert, and the orchestrator/choreographer callers,
which thread the task row's title one call deeper. Fixes the literal
'cell_pm' role string sent as an agent slug in the merge-conflict
notification. Tool-call examples like unblock('<uuid>') keep the raw id on
purpose — agents need it.

* test(notifications): board-review subject assertion matches the humanized format

---------

Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
Renzo F
2026-07-20 20:59:36 +02:00
committed by GitHub
co-authored by Renn F
parent f6cca66afa
commit c8f55be904
13 changed files with 335 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/test_board_review_gate_timeline_real_db.py
+2 -1
View File
@@ -238,4 +238,5 @@ async def test_board_review_gate_flips_only_after_both_reviewers_go_idle(
note = notes[0]
assert note.from_agent == UUID(_SYSTEM_UUID)
assert UUID(_CEO_UUID) in note.to_agents
assert str(task_id) in note.subject
# Subjects are human-readable now: task title + #id8, never the raw UUID.
assert f"#{str(task_id)[:8]}" in note.subject