External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(content): mypy-clean structured-model construction + lint fixes

Browse Source
This commit is contained in:
Renn F
2026-06-21 03:07:58 +02:00
parent 6a14312a0c
commit c47c886508
3 changed files with 84 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/test_task_service_misc.py
+4 -2
View File
@@ -34,11 +34,11 @@ import pytest
import pytest_asyncio
from roboco.db.tables import AgentTable, ProjectTable, WorkSessionTable
from roboco.enforcement import TaskLifecycleError
from roboco.foundation.policy.content import markers
from roboco.models import AgentRole, AgentStatus, Team
from roboco.models.base import Complexity, TaskNature, TaskStatus, TaskType
from roboco.models.permissions import AgentContext
from roboco.models.task import TaskCreateRequest
from roboco.foundation.policy.content import markers
from roboco.models.work_session import WorkSessionStatus
from roboco.services.base import ValidationError
from roboco.services.task import (
@@ -159,7 +159,9 @@ def test_extract_original_developer_no_match() -> None:
def test_extract_original_developer_empty() -> None:
assert extract_original_developer(SimpleNamespace(orchestration_markers=None)) is None
assert (
extract_original_developer(SimpleNamespace(orchestration_markers=None)) is None
)
assert extract_original_developer(SimpleNamespace(orchestration_markers={})) is None
tests/unit/foundation/policy/content/test_content_models.py
+39 -29
View File
@@ -22,46 +22,56 @@ from roboco.foundation.policy.content.enums import Severity, Verdict
def test_pr_review_valid() -> None:
c = PrReviewContent(
summary="The change is correct and covered by tests.",
findings=[
{
"file": "roboco/services/git.py",
"line": 42,
"severity": "major",
"expected": "raises on 422",
"actual": "swallows the error",
}
],
verdict="changes_requested",
c = PrReviewContent.model_validate(
{
"summary": "The change is correct and covered by tests.",
"findings": [
{
"file": "roboco/services/git.py",
"line": 42,
"severity": "major",
"expected": "raises on 422",
"actual": "swallows the error",
}
],
"verdict": "changes_requested",
}
)
assert c.findings[0].severity is Severity.MAJOR
assert c.verdict is Verdict.CHANGES_REQUESTED
def test_qa_valid() -> None:
c = QaNote(
summary="Reviewed all acceptance criteria against the diff.",
ac_verdicts=[
{"criterion": "AC1 returns 400", "status": "verified", "how": "test passes"}
],
verdict="passed",
c = QaNote.model_validate(
{
"summary": "Reviewed all acceptance criteria against the diff.",
"ac_verdicts": [
{
"criterion": "AC1 returns 400",
"status": "verified",
"how": "test passes",
}
],
"verdict": "passed",
}
)
assert c.ac_verdicts[0].status == "verified"
def test_task_description_valid() -> None:
c = TaskDescription(
objective="Add a structured PR-review comment format.",
what_this_builds=["a reviewer schema"],
the_work=[
{
"team": "backend",
"summary": "schema + gateway",
"items": ["model", "verb"],
}
],
acceptance_criteria=["reviewer notes land in their own slot"],
c = TaskDescription.model_validate(
{
"objective": "Add a structured PR-review comment format.",
"what_this_builds": ["a reviewer schema"],
"the_work": [
{
"team": "backend",
"summary": "schema + gateway",
"items": ["model", "verb"],
}
],
"acceptance_criteria": ["reviewer notes land in their own slot"],
}
)
assert c.the_work[0].team.value == "backend"
tests/unit/foundation/policy/content/test_content_renderers.py
+41 -31
View File
@@ -15,18 +15,20 @@ from roboco.foundation.policy.content import (
def test_pr_review_renders_sections_and_findings_table() -> None:
md = PrReviewContent(
summary="The guard is missing on the 422 path.",
findings=[
{
"file": "roboco/services/git.py",
"line": 42,
"severity": "blocker",
"expected": "retry as COMMENT",
"actual": "raises",
}
],
verdict="changes_requested",
md = PrReviewContent.model_validate(
{
"summary": "The guard is missing on the 422 path.",
"findings": [
{
"file": "roboco/services/git.py",
"line": 42,
"severity": "blocker",
"expected": "retry as COMMENT",
"actual": "raises",
}
],
"verdict": "changes_requested",
}
).render_markdown()
assert "## Summary" in md
assert "## Findings" in md
@@ -38,17 +40,19 @@ def test_pr_review_renders_sections_and_findings_table() -> None:
def test_qa_renders_checklist() -> None:
md = QaNote(
summary="Verified every acceptance criterion against the diff.",
ac_verdicts=[
{
"criterion": "AC1 returns 400",
"status": "verified",
"how": "test passes",
},
{"criterion": "AC2 logs", "status": "failed", "how": "no log emitted"},
],
verdict="failed",
md = QaNote.model_validate(
{
"summary": "Verified every acceptance criterion against the diff.",
"ac_verdicts": [
{
"criterion": "AC1 returns 400",
"status": "verified",
"how": "test passes",
},
{"criterion": "AC2 logs", "status": "failed", "how": "no log emitted"},
],
"verdict": "failed",
}
).render_markdown()
assert "## Acceptance Criteria" in md
assert "✅" in md and "❌" in md
@@ -75,14 +79,20 @@ def test_resumption_renders_done_next_where() -> None:
def test_task_description_renders_all_sections() -> None:
md = TaskDescription(
objective="Add the structured content standard.",
what_this_builds=["a schema layer", "a gateway gate"],
the_work=[
{"team": "backend", "summary": "models + verbs", "items": ["model", "verb"]}
],
notes=["reuse the Team enum"],
acceptance_criteria=["reviewer notes are isolated"],
md = TaskDescription.model_validate(
{
"objective": "Add the structured content standard.",
"what_this_builds": ["a schema layer", "a gateway gate"],
"the_work": [
{
"team": "backend",
"summary": "models + verbs",
"items": ["model", "verb"],
}
],
"notes": ["reuse the Team enum"],
"acceptance_criteria": ["reviewer notes are isolated"],
}
).render_markdown()
assert "## Objective" in md
assert "## What This Builds" in md