External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(gateway): correct claim/start argument order in choreographer

Browse Source 
Service signatures are (task_id, agent_id, ...) but choreographer was
calling (agent_id, task_id). Production claim path silently returned
None; unit tests pinned the buggy order so the bug was invisible. Swap
all 7 call sites and update test assertions. Add a regression pin
that locks in the correct order.
This commit is contained in:
Renn F
2026-05-03 04:27:14 +02:00
parent 4c9b7c4210
commit c33340bda1
5 changed files with 231 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/gateway/test_choreographer_claim_guards.py
+2 -2
View File
@@ -147,7 +147,7 @@ async def test_i_will_work_on_allows_when_earlier_sibling_terminal() -> None:
env = await c.i_will_work_on(agent_id, target_id)
assert env.error is None
task_svc.claim.assert_awaited_once_with(agent_id, target_id)
task_svc.claim.assert_awaited_once_with(target_id, agent_id)
@pytest.mark.asyncio
@@ -242,7 +242,7 @@ async def test_i_will_work_on_resumption_does_not_self_block() -> None:
env = await c.i_will_work_on(agent_id, task_id)
assert env.error is None
task_svc.start.assert_awaited_once_with(agent_id, task_id)
task_svc.start.assert_awaited_once_with(task_id, agent_id)
# ---------------------------------------------------------------------------