fix(orchestrator): dispatch board agents for assigned board-team tasks

No dispatcher ever spawned board roles (product-owner / head-marketing) — _handle_pm_assigned_task gates on _PM_AGENTS and there was no board path — so a task assigned to the Product Owner sat pending forever (surfaced by the first board-led run). Board roles advise: triage / note / say / escalate_to_ceo / i_am_idle, with NO verb to claim, plan, delegate, or complete. So a respawn cannot advance the task and would just loop. Add _handle_board_assigned_task: spawn the assigned board agent exactly ONCE (tracked in _board_dispatched) with a review prompt that steers it to its real verbs (record requirements via note, discuss via say, then i_am_idle). The board review is recorded; the CEO then reassigns the task to Main PM for delegation (the handoff stays CEO-mediated, by design — board roles cannot delegate). _dispatch_pm_work routes board-assigned tasks here.
2026-08-03 07:23:24 +02:00 · 2026-05-25 02:48:13 +02:00
parent bc5e016d6d
commit c1d0eefd20
2 changed files with 176 additions and 1 deletions
@@ -0,0 +1,90 @@
+"""Board agents (Product Owner / Head of Marketing) must be dispatched for
+assigned board-team tasks — and only ONCE.
+
+Before this, no dispatcher spawned board roles (only PMs, devs, QA, doc, and
+marketing were wired), so a task assigned to the Product Owner sat `pending`
+forever. Board roles also have no verb to claim/plan/delegate/complete, so a
+respawn cannot advance the task — dispatch is one-shot per (agent, task); the
+CEO reassigns to Main PM after the board review is recorded.
+"""
+
+from __future__ import annotations
+
+from typing import Any
+from unittest.mock import AsyncMock, patch
+from uuid import uuid4
+
+import pytest
+from roboco.runtime.orchestrator import AgentOrchestrator
+
+
+def _make_orch() -> AgentOrchestrator:
+    orch = AgentOrchestrator.__new__(AgentOrchestrator)
+    orch._instances = {}
+    orch._board_dispatched = set()
+    return orch
+
+
+def _board_task(assigned_to: str) -> dict[str, Any]:
+    return {
+        "id": str(uuid4()),
+        "status": "pending",
+        "team": "board",
+        "title": "Strategic feature",
+        "description": "A board-level task to review and shape.",
+        "assigned_to": assigned_to,
+    }
+
+
+@pytest.mark.asyncio
+async def test_board_agent_spawned_once_for_assigned_board_task() -> None:
+    orch = _make_orch()
+    task = _board_task("product-owner")
+    with (
+        patch.object(orch, "_is_agent_active", return_value=False),
+        patch.object(orch, "_task_git_context", return_value=None),
+        patch.object(orch, "spawn_agent", new=AsyncMock()) as spawn,
+    ):
+        await orch._handle_board_assigned_task(task, "product-owner")
+        # Second tick: task is still pending (board has no progression verb) —
+        # must NOT respawn (no loop).
+        await orch._handle_board_assigned_task(task, "product-owner")
+
+    spawn.assert_awaited_once()
+    assert spawn.await_args.kwargs["agent_id"] == "product-owner"
+    assert spawn.await_args.kwargs["task_id"] == task["id"]
+
+
+@pytest.mark.asyncio
+async def test_board_handler_skips_when_agent_active() -> None:
+    orch = _make_orch()
+    task = _board_task("head-marketing")
+    with (
+        patch.object(orch, "_is_agent_active", return_value=True),
+        patch.object(orch, "spawn_agent", new=AsyncMock()) as spawn,
+    ):
+        await orch._handle_board_assigned_task(task, "head-marketing")
+    spawn.assert_not_awaited()
+
+
+@pytest.mark.asyncio
+async def test_board_handler_ignores_non_board_assignee() -> None:
+    orch = _make_orch()
+    task = _board_task("be-pm")
+    with (
+        patch.object(orch, "_is_agent_active", return_value=False),
+        patch.object(orch, "spawn_agent", new=AsyncMock()) as spawn,
+    ):
+        await orch._handle_board_assigned_task(task, "be-pm")
+    spawn.assert_not_awaited()
+
+
+def test_board_review_prompt_uses_board_verbs_only() -> None:
+    """The prompt must steer board agents to their real verbs (triage / note /
+    say / i_am_idle) and away from claim/plan/delegate they do not have."""
+    orch = _make_orch()
+    prompt = orch._build_board_prompt(_board_task("product-owner"))
+    assert "triage()" in prompt
+    assert "note(" in prompt
+    assert "i_am_idle()" in prompt
+    assert "do NOT" in prompt.lower() or "do not" in prompt.lower()