mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
W6: Telegram notifications bridge (V1) (#524)
* feat(gateway): reviewer/PM collision map (W5)
The collision surface (intends_to_touch / adds_migration / touches_shared)
is authored at delegate time, consumed once by SequencingService to wire
dependency edges, then never shown to a reviewer again. This surfaces it:
- Pure builder (services/gateway/choreographer/collision.py): for a task
under review, the surfaced siblings (same parent) that would collide —
file-overlap globs or a shared migration chain (both adds_migration) —
with the overlapping globs and a declared-vs-actual drift check. No
DB/IO; callers fetch siblings (one indexed get_subtasks query, mig 069)
+ actual files (git). Caps: 10 siblings, 5 globs.
- Evidence envelopes: collision_context block injected into QA
claim_review, PR-gate claim_gate_review (both carry real touched files
so drift is populated), and the PM i_will_plan briefing (no actual
files at plan time, drift omitted). Best-effort — a failure omits the
block, never breaks the verb/briefing. Empty block omitted (zero token
cost via _EVIDENCE_OMIT_WHEN_EMPTY).
- Panel: GET /api/tasks/{id}/collision-map (declared surface + sibling
overlap; no drift — the panel route resolves no workspace) + a Collision
tab on the task detail (8th tab). Mock-mode returns an empty map.
- docs/map added to the RAG auto-index dirs so the collision-map concept
is fleet-retrievable; skipped gracefully if the dir is absent.
19 new tests (15 unit on the pure builder + 4 integration on the route).
Gate green: ruff/mypy/xenon (module rank A)/pytest 13000/coverage 94.81%,
panel typecheck/lint/516 tests.
* [w6-telegram] Add Telegram notifications bridge (V1)
CEO-facing Telegram DM bridge, flag-gated off by default
(ROBOCO_TELEGRAM_ENABLED). Mirrors the X-credentials / X-client pattern:
- TelegramCredentialsTable (migration 073) — singleton Fernet-encrypted
bot_token + chat_id, all-or-nothing set/clear; API never returns plaintext.
- TelegramClient ABC / NullTelegramClient (no-op, configured->False, never
raises) / LiveTelegramClient (httpx POST sendMessage) / build_telegram_client
factory (Null when creds unset).
- /telegram/credentials CEO-only routes (write-only, guard-decorated).
- Best-effort _notify_telegram fan-out from the two CEO-notify producers
(notify_ceo_of_escalation, notify_ceo_of_completion) — guarded by the flag,
never raises into the producer, carries a panel deep-link when
panel_base_url is set.
- panel credentials card (2 fields) nested in the Telegram feature-flag row.
- panel_base_url + telegram_timeout_seconds config fields.
V1 scope only: credentials + flag + panel card + client + one-line fan-out.
Out of scope (V2): inbound commands, a TelegramEngine background loop, a
dedup ledger, a bus subscription.
* [w6-telegram] fix: slave mypy/xenon regression (product tests + helper extract)
Pre-existing on slave from prior session's merges — no PR's CI caught them
(squash merges don't re-CI the result; each branch was based on older slave).
- test_product: _product helper returned MagicMock -> list invariant error;
cast to ProductTable, move import under TYPE_CHECKING.
- test_usage: svc.session.execute (AsyncSession) has no call_args_list;
cast to MagicMock at the two call sites.
- product.progress_for_products: xenon rank C -> extract module-level
_project_to_products_map helper (repo pattern: helper-extract).
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
@@ -11,6 +11,7 @@ export { TabCommits } from "./tab-commits";
|
||||
export { TabNotes } from "./tab-notes";
|
||||
export { TabDependencies } from "./tab-dependencies";
|
||||
export { TabFindings } from "./tab-findings";
|
||||
export { TabCollision } from "./tab-collision";
|
||||
export { AcceptanceCriteria } from "./acceptance-criteria";
|
||||
export { ProgressTimeline } from "./progress-timeline";
|
||||
export { CheckpointCard } from "./checkpoint-card";
|
||||
|
||||
@@ -0,0 +1,241 @@
|
||||
"use client";
|
||||
|
||||
import { Task } from "@/types";
|
||||
import { useTaskCollisionMap } from "@/hooks/use-tasks";
|
||||
import type { CollisionMap, CollisionSibling } from "@/lib/api/tasks";
|
||||
import { Card, CardContent } from "@/components/ui/card";
|
||||
import { Badge } from "@/components/ui/badge";
|
||||
import { Skeleton } from "@/components/ui/skeleton";
|
||||
import { GitBranch, AlertTriangle } from "lucide-react";
|
||||
|
||||
interface TabCollisionProps {
|
||||
task: Task;
|
||||
}
|
||||
|
||||
// Status → tailwind badge class (a small inline map; no shared helper exists
|
||||
// across the task-detail tabs, so this mirrors tab-findings' inline maps).
|
||||
const STATUS_CLASS: Record<string, string> = {
|
||||
pending: "bg-gray-100 text-gray-700 dark:bg-gray-800 dark:text-gray-300",
|
||||
claimed:
|
||||
"bg-blue-100 text-blue-700 dark:bg-blue-900 dark:text-blue-300",
|
||||
in_progress:
|
||||
"bg-indigo-100 text-indigo-700 dark:bg-indigo-900 dark:text-indigo-300",
|
||||
awaiting_qa:
|
||||
"bg-purple-100 text-purple-700 dark:bg-purple-900 dark:text-purple-300",
|
||||
awaiting_documentation:
|
||||
"bg-cyan-100 text-cyan-700 dark:bg-cyan-900 dark:text-cyan-300",
|
||||
awaiting_pr_review:
|
||||
"bg-amber-100 text-amber-700 dark:bg-amber-900 dark:text-amber-300",
|
||||
awaiting_pm_review:
|
||||
"bg-teal-100 text-teal-700 dark:bg-teal-900 dark:text-teal-300",
|
||||
awaiting_ceo_approval:
|
||||
"bg-orange-100 text-orange-700 dark:bg-orange-900 dark:text-orange-300",
|
||||
needs_revision:
|
||||
"bg-red-100 text-red-700 dark:bg-red-900 dark:text-red-300",
|
||||
completed:
|
||||
"bg-green-100 text-green-700 dark:bg-green-900 dark:text-green-300",
|
||||
cancelled:
|
||||
"bg-gray-100 text-gray-500 dark:bg-gray-800 dark:text-gray-500",
|
||||
blocked:
|
||||
"bg-red-100 text-red-700 dark:bg-red-900 dark:text-red-300",
|
||||
paused: "bg-yellow-100 text-yellow-700 dark:bg-yellow-900 dark:text-yellow-300",
|
||||
verifying:
|
||||
"bg-violet-100 text-violet-700 dark:bg-violet-900 dark:text-violet-300",
|
||||
backlog: "bg-gray-100 text-gray-500 dark:bg-gray-800 dark:text-gray-500",
|
||||
};
|
||||
|
||||
function SiblingCard({ sib }: { sib: CollisionSibling }) {
|
||||
return (
|
||||
<Card>
|
||||
<CardContent className="pt-4 space-y-3">
|
||||
<div className="flex flex-wrap items-center gap-2">
|
||||
<code className="text-xs font-mono text-muted-foreground">
|
||||
{sib.id}
|
||||
</code>
|
||||
{sib.title && (
|
||||
<span className="text-sm font-medium truncate">{sib.title}</span>
|
||||
)}
|
||||
<Badge
|
||||
className={STATUS_CLASS[sib.status] ?? STATUS_CLASS.pending}
|
||||
>
|
||||
{sib.status}
|
||||
</Badge>
|
||||
{sib.branch_name && (
|
||||
<code className="text-xs text-muted-foreground flex items-center gap-1">
|
||||
<GitBranch className="h-3 w-3" />
|
||||
{sib.branch_name}
|
||||
</code>
|
||||
)}
|
||||
{sib.pr_number != null && (
|
||||
<Badge variant="outline">#{sib.pr_number}</Badge>
|
||||
)}
|
||||
{sib.adds_migration && (
|
||||
<Badge variant="outline" className="text-amber-700">
|
||||
+migration
|
||||
</Badge>
|
||||
)}
|
||||
{sib.touches_shared && (
|
||||
<Badge variant="outline" className="text-orange-700">
|
||||
shared
|
||||
</Badge>
|
||||
)}
|
||||
{sib.sequence != null && (
|
||||
<span className="ml-auto text-xs text-muted-foreground">
|
||||
seq {sib.sequence}
|
||||
</span>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{sib.intends_to_touch.length > 0 && (
|
||||
<div className="flex flex-wrap gap-1.5">
|
||||
{sib.intends_to_touch.map((g) => (
|
||||
<code
|
||||
key={g}
|
||||
className={
|
||||
"text-xs rounded px-1.5 py-0.5 " +
|
||||
(sib.overlap.includes(g)
|
||||
? "bg-red-100 text-red-700 dark:bg-red-900 dark:text-red-300"
|
||||
: "bg-muted text-muted-foreground")
|
||||
}
|
||||
>
|
||||
{g}
|
||||
</code>
|
||||
))}
|
||||
</div>
|
||||
)}
|
||||
|
||||
{sib.overlap.length > 0 && (
|
||||
<p className="text-xs text-muted-foreground">
|
||||
<AlertTriangle className="inline h-3 w-3 mr-1" />
|
||||
Overlaps your declared surface on{" "}
|
||||
{sib.overlap.join(", ")}.
|
||||
</p>
|
||||
)}
|
||||
|
||||
{sib.undeclared.length > 0 && (
|
||||
<div className="rounded border border-amber-300 dark:border-amber-800 bg-amber-50 dark:bg-amber-950/40 p-2 text-xs">
|
||||
<span className="text-amber-700 dark:text-amber-300 font-medium">
|
||||
Drift — touched but not declared:
|
||||
</span>
|
||||
<div className="mt-1 flex flex-wrap gap-1">
|
||||
{sib.undeclared.map((f) => (
|
||||
<code
|
||||
key={f}
|
||||
className="bg-amber-100 dark:bg-amber-900 text-amber-800 dark:text-amber-200 rounded px-1.5 py-0.5"
|
||||
>
|
||||
{f}
|
||||
</code>
|
||||
))}
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
</CardContent>
|
||||
</Card>
|
||||
);
|
||||
}
|
||||
|
||||
export function TabCollision({ task }: TabCollisionProps) {
|
||||
const { data, isLoading } = useTaskCollisionMap(task.id);
|
||||
|
||||
if (isLoading) {
|
||||
return (
|
||||
<div className="space-y-3">
|
||||
<Skeleton className="h-20 w-full" />
|
||||
<Skeleton className="h-24 w-full" />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
// No parent = a root; no collision siblings by construction.
|
||||
if (!data || data.parent_task_id == null) {
|
||||
return (
|
||||
<div className="py-12 text-center text-muted-foreground">
|
||||
<GitBranch className="mx-auto mb-4 h-12 w-12 opacity-50" />
|
||||
<p>No collision map — this task has no parent.</p>
|
||||
<p className="mt-2 text-sm">
|
||||
Roots and standalone tasks have no siblings to collide with.
|
||||
</p>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
const siblings = data.siblings;
|
||||
|
||||
if (siblings.length === 0) {
|
||||
return (
|
||||
<div className="space-y-4">
|
||||
<DeclaredSurfaceCard data={data} />
|
||||
<div className="py-8 text-center text-muted-foreground">
|
||||
<GitBranch className="mx-auto mb-4 h-12 w-12 opacity-50" />
|
||||
<p>No colliding siblings.</p>
|
||||
<p className="mt-2 text-sm">
|
||||
None of this task's siblings share its declared surface or
|
||||
migration chain.
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
return (
|
||||
<div className="space-y-4">
|
||||
<DeclaredSurfaceCard data={data} />
|
||||
<div>
|
||||
<h3 className="text-sm font-semibold mb-3">
|
||||
{siblings.length} colliding sibling{siblings.length > 1 ? "s" : ""}
|
||||
</h3>
|
||||
<div className="space-y-3">
|
||||
{siblings.map((sib) => (
|
||||
<SiblingCard key={sib.id} sib={sib} />
|
||||
))}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
function DeclaredSurfaceCard({ data }: { data: CollisionMap }) {
|
||||
const hasSurface =
|
||||
data.intends_to_touch.length > 0 ||
|
||||
data.adds_migration ||
|
||||
data.touches_shared;
|
||||
return (
|
||||
<Card>
|
||||
<CardContent className="pt-4 space-y-2">
|
||||
<h3 className="text-sm font-semibold">Declared surface</h3>
|
||||
{hasSurface ? (
|
||||
<>
|
||||
{data.intends_to_touch.length > 0 && (
|
||||
<div className="flex flex-wrap gap-1.5">
|
||||
{data.intends_to_touch.map((g) => (
|
||||
<code
|
||||
key={g}
|
||||
className="text-xs bg-muted text-muted-foreground rounded px-1.5 py-0.5"
|
||||
>
|
||||
{g}
|
||||
</code>
|
||||
))}
|
||||
</div>
|
||||
)}
|
||||
<div className="flex flex-wrap gap-2">
|
||||
{data.adds_migration && (
|
||||
<Badge variant="outline" className="text-amber-700">
|
||||
adds migration
|
||||
</Badge>
|
||||
)}
|
||||
{data.touches_shared && (
|
||||
<Badge variant="outline" className="text-orange-700">
|
||||
touches shared
|
||||
</Badge>
|
||||
)}
|
||||
</div>
|
||||
</>
|
||||
) : (
|
||||
<p className="text-sm text-muted-foreground">
|
||||
This task declared no collision surface.
|
||||
</p>
|
||||
)}
|
||||
</CardContent>
|
||||
</Card>
|
||||
);
|
||||
}
|
||||
@@ -17,6 +17,7 @@ import { TabCommits } from "./tab-commits";
|
||||
import { TabNotes } from "./tab-notes";
|
||||
import { TabDependencies } from "./tab-dependencies";
|
||||
import { TabFindings } from "./tab-findings";
|
||||
import { TabCollision } from "./tab-collision";
|
||||
import {
|
||||
FileText,
|
||||
Layout,
|
||||
@@ -25,6 +26,7 @@ import {
|
||||
StickyNote,
|
||||
Link2,
|
||||
ListChecks,
|
||||
GitBranch,
|
||||
type LucideIcon,
|
||||
} from "lucide-react";
|
||||
|
||||
@@ -108,6 +110,12 @@ export function TaskTabs({ task }: TaskTabsProps) {
|
||||
hint: "Revision-findings ledger — QA / PR-review / PM / CEO bounce feedback",
|
||||
count: findingsCount > 0 ? findingsCount : undefined,
|
||||
},
|
||||
{
|
||||
value: "collision",
|
||||
label: "Collision",
|
||||
icon: GitBranch,
|
||||
hint: "Sibling collision surface + declared-vs-actual drift",
|
||||
},
|
||||
];
|
||||
|
||||
// The active tab lives in the URL (?tab=) so it survives reloads,
|
||||
@@ -128,7 +136,7 @@ export function TaskTabs({ task }: TaskTabsProps) {
|
||||
|
||||
return (
|
||||
<Tabs value={activeTab} onValueChange={handleTabChange} className="mt-6">
|
||||
<TabsList className="grid w-full grid-cols-7 lg:w-auto lg:inline-grid">
|
||||
<TabsList className="grid w-full grid-cols-8 lg:w-auto lg:inline-grid">
|
||||
{tabs.map((tab) => (
|
||||
<Tooltip key={tab.value}>
|
||||
<TooltipTrigger asChild>
|
||||
@@ -169,6 +177,9 @@ export function TaskTabs({ task }: TaskTabsProps) {
|
||||
<TabsContent value="findings">
|
||||
<TabFindings task={task} />
|
||||
</TabsContent>
|
||||
<TabsContent value="collision">
|
||||
<TabCollision task={task} />
|
||||
</TabsContent>
|
||||
</div>
|
||||
</Tabs>
|
||||
);
|
||||
|
||||
Reference in New Issue
Block a user