mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[chore] logical-gaps: route-layer force gate + privileged-field gate + pre-task audit attribution
tasks.py (5 gaps):
- _HATCH_OVERRIDE_STATES expanded to 7: a privileged PATCH INTO a gate
state (completed/cancelled/awaiting_{qa,documentation,pr_review,
pm_review,ceo_approval}) now requires explicit force — the panel hatch
is no longer a quiet click that drops a task into/out of a human gate.
- _RESURRECT_SOURCE_STATES: a privileged PATCH OUT of a terminal status
(completed/cancelled) resurrects finished work and likewise requires
force, audited as an override.
- _PRIVILEGED_UPDATE_FIELDS gate: a bare task owner (UPDATE_OWN, no
ASSIGN) cannot self-reassign / re-team / re-parent / re-depend /
re-block / rewrite-plan / re-project its task — those structural fields
are PM-gated; the REST surface must not bypass the verb-layer's
reassign/delegate/triage gate. A 403 names the touched fields + the
verb to use instead.
- pre-task create denial: a role that cannot create tasks is now logged
via log_task_creation_denial (distinct task_creation target_type +
attempted payload) instead of a 'N/A' task_id that coerced to NULL and
left the role-escalation attempt unattributable.
audit.py:
- split log_task_action_denial (5-param, under PLR0913) from
log_task_creation_denial (4-param) — the create path has no task_id;
the non-UUID sentinel (N/A) is preserved in details[target_id_raw]
rather than dropped to a NULL target_id indistinguishable from any
other NULL-target denial.
tests:
- test_tasks_routes.py: parametrized admin-override gate (force
required for gate + terminal states, force succeeds).
- test_tasks_route_privileged_fields.py: dev owner 403 on
assigned_to/team/parent_task_id, 200 on dev-facing description.
- test_audit.py: pre-task attribution via log_task_creation_denial +
non-UUID sentinel preservation.
This commit is contained in:
@@ -144,3 +144,67 @@ async def test_resolve_actor_role_returns_none_when_db_unavailable(
|
||||
# still proceed with the caller-supplied role as fallback.
|
||||
result = await svc._resolve_actor_role_from_db(uuid4())
|
||||
assert result is None
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_log_task_creation_denial_preserves_pre_task_attribution(
|
||||
svc: AuditService,
|
||||
) -> None:
|
||||
"""A create denial has no task row yet; the attempted payload must land in
|
||||
details with a distinct ``task_creation`` target_type, not as an anonymous
|
||||
NULL-target row (a "N/A" task_id would coerce to NULL and leave the denial
|
||||
unattributable — the exact hole where role-escalation attempts surface)."""
|
||||
captured: list[_AuditEvent] = []
|
||||
svc._resolve_actor_role_from_db = _AsyncNone() # type: ignore[method-assign]
|
||||
svc._persist = _Capture(captured) # type: ignore[method-assign]
|
||||
|
||||
await svc.log_task_creation_denial(
|
||||
agent_id=uuid4(),
|
||||
agent_role="developer",
|
||||
action="create",
|
||||
details={
|
||||
"attempted_title": "Steal the keys",
|
||||
"attempted_team": "backend",
|
||||
},
|
||||
)
|
||||
assert len(captured) == 1
|
||||
event = captured[0]
|
||||
assert event.target_type == "task_creation"
|
||||
assert event.target_id is None
|
||||
assert event.details["attempted_title"] == "Steal the keys"
|
||||
assert event.details["attempted_team"] == "backend"
|
||||
assert event.details["action"] == "create"
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_log_task_action_denial_preserves_non_uuid_target_sentinel(
|
||||
svc: AuditService,
|
||||
) -> None:
|
||||
"""A non-UUID task_id sentinel is preserved in details rather than dropped
|
||||
silently to a NULL target_id (the dropped-identifier pattern)."""
|
||||
captured: list[_AuditEvent] = []
|
||||
svc._resolve_actor_role_from_db = _AsyncNone() # type: ignore[method-assign]
|
||||
svc._persist = _Capture(captured) # type: ignore[method-assign]
|
||||
|
||||
await svc.log_task_action_denial(
|
||||
agent_id=uuid4(),
|
||||
agent_role="developer",
|
||||
task_id="N/A",
|
||||
action="claim",
|
||||
reason="x",
|
||||
)
|
||||
assert captured[0].target_id is None
|
||||
assert captured[0].details["target_id_raw"] == "N/A"
|
||||
|
||||
|
||||
class _AsyncNone:
|
||||
async def __call__(self, *_a: object, **_k: object) -> None:
|
||||
return None
|
||||
|
||||
|
||||
class _Capture:
|
||||
def __init__(self, sink: list[_AuditEvent]) -> None:
|
||||
self.sink = sink
|
||||
|
||||
async def __call__(self, event: _AuditEvent) -> None:
|
||||
self.sink.append(event)
|
||||
|
||||
Reference in New Issue
Block a user