mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Feature/video artifact verification (#537)
* fix(release): CI wait polls the prod rung; escape the header tooltip apostrophe get_latest_ci_conclusion defaults to the ladder's head rung, so wait_for_ci searched slave for a release commit that lives on master and timed out after 40 minutes with the run already green. The wait now passes the prod branch explicitly. Also fixes the react/no-unescaped-entities error that turned master's Panel CI red. * fix(panel,video): dead dialog triggers behind tooltips; dotted composition ids render HelpTip nested inside a Dialog/AlertDialog trigger puts the trigger's click handler on the Tooltip root, which renders no DOM — the agents Spawn item and the KB Reindex-All / Delete-index confirms were dead. Tooltips now wrap the triggers. The video renderer accepts interior single dots in composition ids (release-0.25.0) with '..' still unrepresentable, and propose_video refuses an unrenderable id at authoring time. * fix(dispatch): restart-safe PM review turns A leaf task in awaiting_pm_review had no periodic pickup: the closure dispatcher bailed on childless tasks and skipped PR-bearing review tasks as already-promoted, assuming the submit-time PM session was still alive — an assumption every restart breaks. Proven live on the docs-sync leaf after the 0.25.0 redeploy, which also dependency-blocked its sibling dev task. Childless awaiting_pm_review tasks now flow to the PM's review turn, and the merge turn respawns its PM when none is active. * feat(video): verify the rendered artifact, not the source The 14s release-0.25.0 cut shipped with only one of four scenes visibly registering: the dev authored DOM, the smoke asserted DOM, QA read code — nobody consumed the rendered MP4 before the CEO did. Close that loop, and the reject loop behind it: - sidecar frames mode: POST /render with frames=1..32 renders the cut, ffprobes the REAL duration, extracts midpoint-sampled keyframe PNGs (timestamps in filenames), streams a tar.gz back with X-Video-Duration - request_render do-verb (developer/QA, request_sandbox's shape): renders the caller's ACTUAL composition — dev's own worktree (head_sha/dirty provenance), QA a read-only git-archive export of the assembled branch — extracts frames to the container-shared .previews/ path, stamps the render_preview marker, returns the paths as envelope evidence - gate: i_am_done on a source=video task refuses without a stamped render_preview (Requirement.RENDER_VERIFIED; canonical source string moved to foundation as markers.VIDEO_TASK_SOURCE; mirrored in the possibilities-matrix fast path so it cannot bypass the check) - QA claim_review evidence carries video_context (composition id, the dev's preview, a re-render instruction) so review checks output - dev spawn prompt block + a 4th authoring AC order Read-every-frame verification before submitting - reject -> re-author: a CEO reject with a reason opens a fresh authoring task carrying the verbatim feedback + a revise-in-place pointer at the existing composition (best-effort, never fails the reject) — rejection feedback no longer dies on the cancelled draft E2E: rendered the committed release-0.25.0 composition through the new frames mode locally — the returned keyframes show exactly the reported failure (blank frame at 5.8s, only 'Env ladder' by 12.8s), the check the fleet was missing. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
@@ -0,0 +1,42 @@
|
||||
// node --test: exercises the pure 'frames' form-field validation only —
|
||||
// server.js's app.listen is guarded (see server.js) so importing it here
|
||||
// never binds the real port.
|
||||
import { test } from "node:test";
|
||||
import assert from "node:assert/strict";
|
||||
import { parseFramesField } from "./server.js";
|
||||
import { MAX_PREVIEW_FRAMES } from "./render.js";
|
||||
|
||||
test("parseFramesField treats an absent field as the existing MP4 path", () => {
|
||||
assert.deepEqual(parseFramesField(undefined), { count: null });
|
||||
});
|
||||
|
||||
test("parseFramesField treats an empty string as the existing MP4 path", () => {
|
||||
assert.deepEqual(parseFramesField(""), { count: null });
|
||||
});
|
||||
|
||||
test("parseFramesField accepts an in-bounds integer string", () => {
|
||||
assert.deepEqual(parseFramesField("8"), { count: 8 });
|
||||
});
|
||||
|
||||
test("parseFramesField accepts the boundary values 1 and MAX_PREVIEW_FRAMES", () => {
|
||||
assert.deepEqual(parseFramesField("1"), { count: 1 });
|
||||
assert.deepEqual(parseFramesField(String(MAX_PREVIEW_FRAMES)), {
|
||||
count: MAX_PREVIEW_FRAMES,
|
||||
});
|
||||
});
|
||||
|
||||
test("parseFramesField rejects zero", () => {
|
||||
assert.ok(parseFramesField("0").error);
|
||||
});
|
||||
|
||||
test("parseFramesField rejects above MAX_PREVIEW_FRAMES", () => {
|
||||
assert.ok(parseFramesField(String(MAX_PREVIEW_FRAMES + 1)).error);
|
||||
});
|
||||
|
||||
test("parseFramesField rejects a non-integer value", () => {
|
||||
assert.ok(parseFramesField("4.5").error);
|
||||
});
|
||||
|
||||
test("parseFramesField rejects a non-numeric value", () => {
|
||||
assert.ok(parseFramesField("abc").error);
|
||||
});
|
||||
Reference in New Issue
Block a user