feat(content): task structured-note fields + orchestration-marker accessors

tests/unit/api/schemas/test_task_update_notes.py

@@ -0,0 +1,28 @@
+"""The note fields are first-class on the task update + response schemas."""
+
+from __future__ import annotations
+
+from roboco.api.schemas.tasks import TaskResponse
+from roboco.api.schemas.tasks import TaskUpdate as ApiTaskUpdate
+from roboco.models.task import TaskUpdate as DomainTaskUpdate
+
+
+def test_api_task_update_accepts_auditor_and_pr_reviewer_notes() -> None:
+    u = ApiTaskUpdate(auditor_notes="audit", pr_reviewer_notes="review")
+    assert u.auditor_notes == "audit"
+    assert u.pr_reviewer_notes == "review"
+
+
+def test_domain_task_update_accepts_new_notes() -> None:
+    u = DomainTaskUpdate(auditor_notes="audit", pr_reviewer_notes="review")
+    assert u.auditor_notes == "audit"
+    assert u.pr_reviewer_notes == "review"
+
+
+def test_task_response_exposes_structured_fields() -> None:
+    fields = set(TaskResponse.model_fields)
+    assert {
+        "pr_reviewer_notes",
+        "notes_structured",
+        "orchestration_markers",
+    } <= fields

tests/unit/foundation/policy/content/test_markers.py

@@ -0,0 +1,62 @@
+"""Tests for the orchestration-marker accessors."""
+
+from __future__ import annotations
+
+from types import SimpleNamespace
+
+from roboco.foundation.policy.content import markers as m
+
+
+def _task(om: dict | None = None) -> SimpleNamespace:
+    return SimpleNamespace(orchestration_markers=om)
+
+
+def test_original_developer_roundtrip() -> None:
+    t = _task()
+    assert m.get_original_developer(t) is None
+    m.set_original_developer(t, "00000000-0000-0000-0001-000000000002")
+    assert m.get_original_developer(t) == "00000000-0000-0000-0001-000000000002"
+
+
+def test_required_cells_roundtrip() -> None:
+    t = _task()
+    assert m.get_required_cells(t) == []
+    m.set_required_cells(t, ["backend", "frontend"])
+    assert m.get_required_cells(t) == ["backend", "frontend"]
+
+
+def test_dismissed_flag() -> None:
+    t = _task()
+    assert m.is_dismissed(t) is False
+    m.mark_dismissed(t)
+    assert m.is_dismissed(t) is True
+
+
+def test_set_marker_reassigns_dict_for_orm_dirty_tracking() -> None:
+    t = _task({"a": 1})
+    before = t.orchestration_markers
+    m.set_marker(t, "b", 2)
+    # A new dict object — SQLAlchemy only flags JSON columns dirty on reassign.
+    assert t.orchestration_markers is not before
+    assert t.orchestration_markers == {"a": 1, "b": 2}
+
+
+def test_clear_marker_nulls_when_empty() -> None:
+    t = _task({"x": 1})
+    m.clear_marker(t, "x")
+    assert t.orchestration_markers is None
+    # Clearing an absent key is a no-op.
+    m.clear_marker(t, "missing")
+    assert t.orchestration_markers is None
+
+
+def test_documenter_self_heal_head_supersede() -> None:
+    t = _task()
+    m.set_documenter(t, "doc-uuid")
+    m.set_self_heal_fingerprint(t, "deadbeef")
+    m.set_external_pr_head(t, "sha123")
+    m.set_external_pr_supersede(t, "pr=1 review=2 closed=1")
+    assert m.get_documenter(t) == "doc-uuid"
+    assert m.get_self_heal_fingerprint(t) == "deadbeef"
+    assert m.get_external_pr_head(t) == "sha123"
+    assert m.get_external_pr_supersede(t) == "pr=1 review=2 closed=1"