mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
feat(content): obligate role note sections like journals
Completes the note(scope='handoff') write-path (WIP 23e6ee57): every role
with a dedicated note section is now obligated to populate it, the same way
journals are obligated.
Obligations (foundation.policy.tracing):
- DEV_NOTES / PR_REVIEWER_NOTES / QUICK_CONTEXT_MIN_CHARS requirements +
checkers, wired onto i_am_done (dev_notes), delegate (quick_context), and
pr_pass / pr_fail / post_pr_review (pr_reviewer_notes).
- Fixes a latent bug: the docs-notes checker read dev_notes instead of
doc_notes (the documenter's section); the i_documented shim now feeds
doc_notes to match.
Auditor: a session-scoped note obligation on i_am_idle — the auditor owns no
delivery task and has no delivery verb, so it must have recorded an
observation within the window before going idle (JournalService.has_recent_entry).
Write-then-gate: persisted sections (dev_notes / quick_context) are
pre-written by the agent's note(scope='handoff') before the gated verb;
argument-borne sections (doc_notes / pr_reviewer_notes) are checked through a
SimpleNamespace shim, the same pattern qa_notes already uses.
Config: dev/pr_reviewer/quick_context min-chars (40/40/30), panel-tunable.
Plus per-gap remediation hints and full coverage (write-path routing,
ownership, validation->remediation, each obligation, the doc_notes fix).
Full make-quality green: 9777 passed, 95.6% coverage.
This commit is contained in:
@@ -0,0 +1,167 @@
|
||||
"""Tests for note(scope='handoff') — the role note-section write-path.
|
||||
|
||||
``note()`` only ever wrote the JOURNAL; ``scope='handoff'`` is how an agent
|
||||
authors its dedicated SECTION (dev_notes / quick_context / auditor_notes …)
|
||||
through the ``apply_structured_note`` chokepoint. These cover the routing,
|
||||
ownership, validation→remediation, and journal-trail behaviours.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from unittest.mock import AsyncMock, MagicMock
|
||||
from uuid import uuid4
|
||||
|
||||
import pytest
|
||||
from roboco.foundation.policy.content import ContentValidationError
|
||||
from roboco.services.gateway.content_actions import ContentActions, ContentActionsDeps
|
||||
|
||||
|
||||
def _make_deps(**overrides: object) -> ContentActionsDeps:
|
||||
task = overrides.get("task") or AsyncMock()
|
||||
return ContentActionsDeps(
|
||||
task=task,
|
||||
git=overrides.get("git") or AsyncMock(),
|
||||
messaging=overrides.get("messaging") or AsyncMock(),
|
||||
a2a=overrides.get("a2a") or AsyncMock(),
|
||||
journal=overrides.get("journal") or AsyncMock(),
|
||||
workspace=overrides.get("workspace") or AsyncMock(),
|
||||
notifications=overrides.get("notifications") or AsyncMock(),
|
||||
notification_delivery=overrides.get("notification_delivery") or AsyncMock(),
|
||||
evidence_repo=overrides.get("evidence_repo") or AsyncMock(),
|
||||
)
|
||||
|
||||
|
||||
def _dev_task_svc(task_id: object, role: str = "developer") -> AsyncMock:
|
||||
"""A task service whose active/context task is owned by the caller."""
|
||||
svc = AsyncMock()
|
||||
svc.agent_for.return_value = MagicMock(role=role)
|
||||
svc.get_journal_context_task_for_agent.return_value = MagicMock(id=task_id)
|
||||
svc.record_section_note.return_value = None
|
||||
return svc
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_handoff_developer_writes_dev_notes_from_text() -> None:
|
||||
"""A developer handoff routes to the 'developer' content type, defaulting
|
||||
the payload to {'summary': text} when no explicit section is given."""
|
||||
agent_id, task_id = uuid4(), uuid4()
|
||||
svc = _dev_task_svc(task_id)
|
||||
ca = ContentActions(_make_deps(task=svc))
|
||||
|
||||
summary = "Implemented the endpoint and added happy-path tests."
|
||||
env = await ca.note(agent_id=agent_id, text=summary, scope="handoff")
|
||||
|
||||
assert env.as_dict()["error"] is None
|
||||
svc.record_section_note.assert_awaited_once()
|
||||
called_task_id, content_type, payload = svc.record_section_note.call_args.args
|
||||
assert called_task_id == task_id
|
||||
assert content_type == "developer"
|
||||
assert payload == {"summary": summary}
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_handoff_passes_explicit_section_through() -> None:
|
||||
"""An explicit ``section`` dict is the payload (e.g. PM resumption)."""
|
||||
agent_id, task_id = uuid4(), uuid4()
|
||||
svc = _dev_task_svc(task_id, role="cell_pm")
|
||||
ca = ContentActions(_make_deps(task=svc))
|
||||
|
||||
section = {"done": "Planned the decomposition.", "next": "Cells implement."}
|
||||
env = await ca.note(
|
||||
agent_id=agent_id, text="handoff", scope="handoff", section=section
|
||||
)
|
||||
|
||||
assert env.as_dict()["error"] is None
|
||||
_tid, content_type, payload = svc.record_section_note.call_args.args
|
||||
assert content_type == "resumption"
|
||||
assert payload == section
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_handoff_also_writes_journal_trail_entry() -> None:
|
||||
"""The section write drops a journal trail entry so it shows in the log."""
|
||||
agent_id, task_id = uuid4(), uuid4()
|
||||
svc = _dev_task_svc(task_id)
|
||||
journal = AsyncMock()
|
||||
ca = ContentActions(_make_deps(task=svc, journal=journal))
|
||||
|
||||
await ca.note(agent_id=agent_id, text="Did the thing thoroughly.", scope="handoff")
|
||||
|
||||
journal.write_entry.assert_awaited_once()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_handoff_role_without_section_is_rejected() -> None:
|
||||
"""A role with no dedicated section (board/advisory) cannot handoff."""
|
||||
agent_id = uuid4()
|
||||
svc = AsyncMock()
|
||||
svc.agent_for.return_value = MagicMock(role="product_owner")
|
||||
ca = ContentActions(_make_deps(task=svc))
|
||||
|
||||
env = await ca.note(agent_id=agent_id, text="observation", scope="handoff")
|
||||
body = env.as_dict()
|
||||
|
||||
assert body["error"] == "invalid_state"
|
||||
assert "no dedicated note section" in body["message"]
|
||||
svc.record_section_note.assert_not_awaited()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_handoff_validation_error_returns_remediation_not_422() -> None:
|
||||
"""A malformed section payload becomes a remediation Envelope, never a 422
|
||||
(a raw 422 would trip the do-server circuit breaker)."""
|
||||
agent_id, task_id = uuid4(), uuid4()
|
||||
svc = _dev_task_svc(task_id, role="auditor")
|
||||
svc.record_section_note.side_effect = ContentValidationError(
|
||||
"severity", "field required"
|
||||
)
|
||||
ca = ContentActions(_make_deps(task=svc))
|
||||
|
||||
env = await ca.note(
|
||||
agent_id=agent_id,
|
||||
text="risk spotted",
|
||||
scope="handoff",
|
||||
section={"summary": "x"},
|
||||
)
|
||||
body = env.as_dict()
|
||||
|
||||
assert body["error"] == "invalid_state"
|
||||
assert "severity" in body["message"]
|
||||
assert "auditor" in body["remediate"]
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_handoff_no_task_to_attach_is_rejected() -> None:
|
||||
"""With no active/context task and no explicit task_id, handoff refuses."""
|
||||
agent_id = uuid4()
|
||||
svc = AsyncMock()
|
||||
svc.agent_for.return_value = MagicMock(role="developer")
|
||||
svc.get_journal_context_task_for_agent.return_value = None
|
||||
ca = ContentActions(_make_deps(task=svc))
|
||||
|
||||
env = await ca.note(agent_id=agent_id, text="orphan note", scope="handoff")
|
||||
body = env.as_dict()
|
||||
|
||||
assert body["error"] == "invalid_state"
|
||||
assert "task_id" in body["remediate"]
|
||||
svc.record_section_note.assert_not_awaited()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_handoff_explicit_task_not_owned_is_rejected() -> None:
|
||||
"""An explicit task_id the caller does not own is an ownership violation."""
|
||||
agent_id, task_id = uuid4(), uuid4()
|
||||
svc = AsyncMock()
|
||||
svc.agent_for.return_value = MagicMock(role="developer")
|
||||
svc.get.return_value = MagicMock(
|
||||
id=task_id, assigned_to=uuid4(), project_id=uuid4(), product_id=None
|
||||
)
|
||||
ca = ContentActions(_make_deps(task=svc))
|
||||
|
||||
env = await ca.note(
|
||||
agent_id=agent_id, text="poking another task", scope="handoff", task_id=task_id
|
||||
)
|
||||
body = env.as_dict()
|
||||
|
||||
assert body["error"] == "not_authorized"
|
||||
svc.record_section_note.assert_not_awaited()
|
||||
Reference in New Issue
Block a user