mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
feat(content): obligate role note sections like journals
Completes the note(scope='handoff') write-path (WIP 23e6ee57): every role
with a dedicated note section is now obligated to populate it, the same way
journals are obligated.
Obligations (foundation.policy.tracing):
- DEV_NOTES / PR_REVIEWER_NOTES / QUICK_CONTEXT_MIN_CHARS requirements +
checkers, wired onto i_am_done (dev_notes), delegate (quick_context), and
pr_pass / pr_fail / post_pr_review (pr_reviewer_notes).
- Fixes a latent bug: the docs-notes checker read dev_notes instead of
doc_notes (the documenter's section); the i_documented shim now feeds
doc_notes to match.
Auditor: a session-scoped note obligation on i_am_idle — the auditor owns no
delivery task and has no delivery verb, so it must have recorded an
observation within the window before going idle (JournalService.has_recent_entry).
Write-then-gate: persisted sections (dev_notes / quick_context) are
pre-written by the agent's note(scope='handoff') before the gated verb;
argument-borne sections (doc_notes / pr_reviewer_notes) are checked through a
SimpleNamespace shim, the same pattern qa_notes already uses.
Config: dev/pr_reviewer/quick_context min-chars (40/40/30), panel-tunable.
Plus per-gap remediation hints and full coverage (write-path routing,
ownership, validation->remediation, each obligation, the doc_notes fix).
Full make-quality green: 9777 passed, 95.6% coverage.
This commit is contained in:
@@ -424,6 +424,14 @@ async def test_dev_full_chain_through_awaiting_qa(
|
||||
assert refreshed is not None
|
||||
assert refreshed.pr_number == _PR_NUMBER, "PR recorded on task"
|
||||
|
||||
# i_am_done obligates the developer's dev_notes section — the agent fills
|
||||
# it via note(scope='handoff') first; record_section_note is that write.
|
||||
await task_service.record_section_note(
|
||||
task.id,
|
||||
"developer",
|
||||
{"summary": "Implemented /healthz and added a test for the happy path."},
|
||||
)
|
||||
|
||||
# 4. i_am_done — auto-runs in_progress → verifying → awaiting_qa.
|
||||
env = await c.i_am_done(dev_agent.id, task.id, "tests pass; route works")
|
||||
assert env.error is None, f"i_am_done failed: {env.message}"
|
||||
@@ -482,6 +490,12 @@ async def test_full_chain_through_doc_handoff(
|
||||
)
|
||||
await task_service.add_progress(task.id, dev_agent.id, "implemented /healthz")
|
||||
await c.open_pr(dev_agent.id, task.id)
|
||||
# i_am_done obligates the developer's dev_notes section (note(scope='handoff')).
|
||||
await task_service.record_section_note(
|
||||
task.id,
|
||||
"developer",
|
||||
{"summary": "Implemented /healthz and added a test for the happy path."},
|
||||
)
|
||||
env = await c.i_am_done(dev_agent.id, task.id, "tests pass; route works")
|
||||
assert env.error is None
|
||||
assert env.status == "awaiting_qa"
|
||||
|
||||
Reference in New Issue
Block a user