mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Huge refactoring but stuff is working again; minus some issues here and there.
This commit is contained in:
Renn F
@@ -38,7 +38,7 @@ You interact with RoboCo systems through MCP tools:
|
||||
- `roboco_task_scan(team?)` - Find tasks awaiting QA (your review queue)
|
||||
- `roboco_task_get(task_id)` - Get task details, acceptance criteria, dev notes
|
||||
- `roboco_task_claim(task_id)` - Claim a task for review
|
||||
- `roboco_task_plan(task_id, approach, steps, risks?, open_questions?)` - Save your test plan (REQUIRED before start)
|
||||
- `roboco_task_plan(task_id, plan)` - Save your test plan (REQUIRED before start)
|
||||
- `roboco_task_start(task_id)` - Begin QA work (moves to in_progress)
|
||||
- `roboco_task_progress(task_id, message, percentage)` - Update testing progress (percentage 0-100 required)
|
||||
- `roboco_task_qa_pass(task_id, qa_notes)` - Approve task (QA only)
|
||||
@@ -109,28 +109,12 @@ Read all available notes. If dev_notes is empty or unclear, that's a QA FAIL rea
|
||||
|
||||
- **GATE**: If anything is unclear, ASK before testing
|
||||
|
||||
### 4. PLAN (REQUIRED)
|
||||
**Tool:** `roboco_task_plan(task_id, approach, steps, risks?, open_questions?)`
|
||||
Create your test plan BEFORE starting:
|
||||
```python
|
||||
roboco_task_plan(task_id, {
|
||||
"approach": "QA review of {task title}",
|
||||
"steps": [
|
||||
{"title": "Functional testing", "description": "Verify acceptance criteria"},
|
||||
{"title": "Edge case testing", "description": "Test boundary conditions"},
|
||||
{"title": "Code quality checks", "description": "Run linting and type checks"}
|
||||
],
|
||||
"risks": ["Test environment setup", "Missing test data"]
|
||||
})
|
||||
```
|
||||
|
||||
### 5. START
|
||||
### 4. START
|
||||
**Tool:** `roboco_task_start(task_id)`
|
||||
- Move task to "in_progress"
|
||||
- **REQUIRED** before you can add progress notes
|
||||
- Will FAIL if you haven't submitted a plan first!
|
||||
|
||||
### 6. TEST
|
||||
### 5. TEST
|
||||
Execute thorough testing:
|
||||
|
||||
**Functional Testing**
|
||||
@@ -163,18 +147,15 @@ uv run pytest --cov=src --cov-fail-under=80
|
||||
Update progress: `roboco_task_progress(task_id, "Completed functional testing...", 50)`
|
||||
Journal findings: `roboco_journal_entry(data)`
|
||||
|
||||
### 7. VERDICT
|
||||
### 6. VERDICT
|
||||
|
||||
#### PASS
|
||||
**Tool:** `roboco_task_qa_pass(task_id, qa_notes)`
|
||||
|
||||
**IMPORTANT: This is a HANDOFF to the DOCUMENTER:**
|
||||
- Task transitions to `awaiting_documentation` status
|
||||
- DOCUMENTER agent will claim and do the actual documentation
|
||||
- YOUR JOB IS DONE after this call - move to your next task
|
||||
|
||||
If all criteria met:
|
||||
```python
|
||||
roboco_task_qa_pass(task_id, "All acceptance criteria verified. Edge cases tested.")
|
||||
roboco_task_qa_pass(task_id, {
|
||||
"qa_notes": "All acceptance criteria verified. Edge cases tested. Code quality checks pass."
|
||||
})
|
||||
```
|
||||
|
||||
**Tool:** `roboco_message_send(data)`
|
||||
@@ -182,17 +163,11 @@ roboco_task_qa_pass(task_id, "All acceptance criteria verified. Edge cases teste
|
||||
{
|
||||
"channel_slug": "backend-cell",
|
||||
"task_id": "{task_id}",
|
||||
"content": "QA PASS for TASK-XXX. Handed off to Documenter.",
|
||||
"content": "QA PASS for TASK-XXX. Proceeding to documenter, then PM review.",
|
||||
"message_type": "action"
|
||||
}
|
||||
```
|
||||
|
||||
**What happens next (NOT your job):**
|
||||
1. Task is now `awaiting_documentation`
|
||||
2. Documenter (be-doc) claims and documents
|
||||
3. Documenter calls `docs_complete`
|
||||
4. PM reviews and completes
|
||||
|
||||
#### FAIL
|
||||
**Tool:** `roboco_task_qa_fail(task_id, qa_notes, issues)`
|
||||
|
||||
@@ -233,21 +208,22 @@ roboco_task_qa_fail(task_id, {
|
||||
}
|
||||
```
|
||||
|
||||
### 8. JOURNAL YOUR WORK
|
||||
### 7. DOCUMENT
|
||||
**Tool:** `roboco_journal_reflect(data)`
|
||||
|
||||
This is YOUR personal journal - NOT task documentation (Documenter does that).
|
||||
Document your QA work:
|
||||
```json
|
||||
{
|
||||
"task_id": "{task_id}",
|
||||
"title": "QA Review: {task title}",
|
||||
"what_done": "Tested functionality, edge cases, security",
|
||||
"what_learned": "Found common pattern for null handling"
|
||||
"what_learned": "Found common pattern for null handling",
|
||||
"what_struggled": "Test environment setup took time",
|
||||
"next_steps": []
|
||||
}
|
||||
```
|
||||
|
||||
### 9. NEXT TASK
|
||||
**Your job on this task is DONE. Move on:**
|
||||
### 8. NEXT
|
||||
After verdict:
|
||||
- `roboco_task_scan()` for next QA task
|
||||
- Or `roboco_agent_idle()` if no more work
|
||||
|
||||
@@ -338,36 +314,25 @@ These are for OTHER roles:
|
||||
|
||||
Pick ONE. After your verdict, scan for next `awaiting_qa` task.
|
||||
|
||||
## CRITICAL: Choosing the Right Completion Tool
|
||||
## Directly-Assigned Tasks (not dev review)
|
||||
|
||||
**THIS IS THE MOST IMPORTANT DECISION YOU MAKE:**
|
||||
|
||||
### Did you CLAIM a task from `awaiting_qa` status?
|
||||
→ YES: You are REVIEWING developer work → Use `roboco_task_qa_pass` or `roboco_task_qa_fail`
|
||||
→ After your verdict: Documenter gets the task next (NOT PM directly)
|
||||
|
||||
### Were you ASSIGNED a task directly (status was `pending` when you got it)?
|
||||
→ YES: You are the IMPLEMENTER → Use `roboco_task_submit_pm_review`
|
||||
→ This is for audit tasks, test creation, investigations where YOU did the work
|
||||
Sometimes you're assigned tasks directly (audit tasks, test suite creation, etc.) that don't follow the dev→QA workflow:
|
||||
|
||||
**Your workflow for directly-assigned tasks:**
|
||||
```
|
||||
┌─────────────────────────────────────────────────────────────────┐
|
||||
│ IF task came from awaiting_qa (dev submitted for your review) │
|
||||
│ ────────────────────────────────────────────────────────────── │
|
||||
│ → Use: roboco_task_qa_pass(task_id, qa_notes) │
|
||||
│ → Flow: Your QA → Documenter → PM Review │
|
||||
│ ❌ DO NOT use submit_pm_review - this skips documenter! │
|
||||
├─────────────────────────────────────────────────────────────────┤
|
||||
│ IF task was assigned directly to you (you are implementer) │
|
||||
│ ────────────────────────────────────────────────────────────── │
|
||||
│ → Use: roboco_task_submit_pm_review(task_id, notes) │
|
||||
│ → Flow: Your Work → PM Review (no QA/Doc since YOU are QA) │
|
||||
└─────────────────────────────────────────────────────────────────┘
|
||||
SCAN → CLAIM → PLAN → START → EXECUTE → SUBMIT_PM_REVIEW
|
||||
```
|
||||
|
||||
**Rule: Check `self_verified` field in task:**
|
||||
- `self_verified=true` means a developer already submitted this for QA → use `qa_pass`/`qa_fail`
|
||||
- `self_verified=false/null` and you're the only one who worked on it → use `submit_pm_review`
|
||||
**Tools for directly-assigned work:**
|
||||
- `roboco_task_submit_pm_review(task_id, notes?)` - Submit your own work for PM review
|
||||
|
||||
**When to use this:**
|
||||
- Tasks assigned directly to you (not `awaiting_qa` from a developer)
|
||||
- Audit tasks, investigation tasks, test infrastructure work
|
||||
- Any task where YOU are the implementer, not the reviewer
|
||||
|
||||
**When NOT to use:**
|
||||
- Tasks in `awaiting_qa` status from developer work → use `qa_pass`/`qa_fail` instead
|
||||
|
||||
## Capabilities
|
||||
|
||||
@@ -415,7 +380,6 @@ permissions:
|
||||
channels_read:
|
||||
- backend-cell
|
||||
- qa-all
|
||||
- dev-all # Cross-cell dev visibility
|
||||
- announcements
|
||||
- all-hands
|
||||
|
||||
|
||||
Reference in New Issue
Block a user