Board Program LEARN context, ruff 0.16, and verb-rejection observability (#700)

* fix(board): LEARN decisions name the item, not its per-cycle index

A cycle's reject reasons are rendered into the NEXT cycle's exploration
prompt, but the ref recorded alongside each reason was the item's stored
id (item-0/item-1) — a per-cycle index that means something different
every cycle and appears nowhere the explorer can resolve. The reason
survived the loop; what it was about did not.

Record the item's title instead, via a shared learn_ref() helper (falls
back to the id when title-less, and reads target_task_title for Scales,
whose items name the live task they mutate).

* chore(lint): satisfy ruff 0.16 — keyword-only signatures and markdown formatting

The dev toolchain resolved ruff 0.16.0, which stabilises PLR0917 (too many
positional arguments) and formats python code blocks inside markdown. Both
fired repo-wide and neither had anything to do with the code they flagged.

- 36 signatures gain a `*` so their tail arguments are keyword-only, and
  the 104 call sites that passed them positionally are converted. mypy was
  the safety net for the static ones; the full suite caught nine more that
  only bind at runtime (the MCP tool functions, whose real callers already
  pass named JSON arguments).
- 28 markdown files reformatted by 0.16's code-block formatter.
- One RUF036 (`None` mid-union) autofixed in the GitLab provider.

* fix(gateway): log the reason when a verb rejects

A rejected envelope rides an HTTP 200, its body is never logged, and there
is no trace table — so in the access log a verb an agent could not satisfy
looks identical to one that worked. On 2026-07-25 four Board Programs
(Periscope, Sentinel, Scales, Barfly) each POSTed their propose verb three
or four times, persisted nothing, and left their exploration tasks PENDING;
the reason was unrecoverable afterwards, from the logs or from the agents'
own transcripts.

Log error/message/remediate/missing plus the calling agent at
envelope_to_response — the one chokepoint every v1 flow and do route
returns through. Success envelopes stay silent.

---------

Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
Renzo F
2026-07-26 15:07:28 +02:00
committed by GitHub
co-authored by Renn F
parent 401f8a2cc9
commit 879afc14a4
84 changed files with 932 additions and 567 deletions
+1 -1
View File
@@ -36,7 +36,7 @@ CEO-initiated conversations may arrive and are replied to in-thread like any oth
Your claim briefing surfaces incoming A2A under `unread_a2a` — each entry shows the sender and a preview of their latest message. To read the full bodies (and clear them):
```python
read_a2a() # -> {"messages": [{from_agent, content, created_at}, ...]}
read_a2a() # -> {"messages": [{from_agent, content, created_at}, ...]}
```
`read_a2a()` returns only INCOMING messages (never your own sends) and marks them read. It also clears `i_am_idle()`'s unread-A2A soft-block.
+6 -11
View File
@@ -25,9 +25,9 @@ It searches ALL knowledge sources and supports follow-up questions.
```python
roboco_kb_search(
query="rate limiting redis implementation",
top_k=5, # Results to return
project="roboco-api", # Optional project filter
index_types=["code", "docs"] # Filter by type
top_k=5, # Results to return
project="roboco-api", # Optional project filter
index_types=["code", "docs"], # Filter by type
)
```
@@ -36,10 +36,7 @@ Returns similar content - not just keyword matches.
## RAG Query (AI Answer)
```python
roboco_rag_query(
query="How does authentication work in this codebase?",
top_k=5
)
roboco_rag_query(query="How does authentication work in this codebase?", top_k=5)
```
Returns AI-synthesized answer with citations.
@@ -54,14 +51,12 @@ Good for:
```python
# First question
response = roboco_ask_mentor(
question="How do I handle authentication?",
domain="coding"
question="How do I handle authentication?", domain="coding"
)
# Follow-up
roboco_ask_mentor(
question="What about refresh tokens?",
conversation_id=response["conversation_id"]
question="What about refresh tokens?", conversation_id=response["conversation_id"]
)
```
+4 -2
View File
@@ -12,8 +12,10 @@ You do **not** call any tool to create a PR. There is no `roboco_git_create_pr`
```python
# 1. Make commits as you work (auto-pushes, no separate push step)
commit(message="feat(api): add Redis rate limiter",
files=["roboco/api/routes/rate.py", "tests/integration/test_rate.py"])
commit(
message="feat(api): add Redis rate limiter",
files=["roboco/api/routes/rate.py", "tests/integration/test_rate.py"],
)
# 2. Once acceptance criteria are implemented + tested, hand off to QA.
# The choreographer opens the PR here, sets pr_number/pr_url on the
+6 -4
View File
@@ -27,10 +27,12 @@ roboco_git_log(branch="<dev's branch>")
# Frontend: pnpm test && pnpm lint && pnpm typecheck
# 5. Capture evidence (survives compaction; PMs can audit later)
note(text="Verified AC #1 (429 on 101st req), #2 (TTL match), #3 "
"(boundary tests). pytest 1635 passed; ruff clean; mypy clean.",
scope="evidence",
task_id="<task>")
note(
text="Verified AC #1 (429 on 101st req), #2 (TTL match), #3 "
"(boundary tests). pytest 1635 passed; ruff clean; mypy clean.",
scope="evidence",
task_id="<task>",
)
```
There is no `roboco_task_claim / _start / _qa_pass / _qa_fail` and no `roboco_git_checkout`. The verbs above (`claim_review`, `pass`, `fail`) are the actual surface; branch checkout is a side-effect of `claim_review`.
+3 -3
View File
@@ -16,9 +16,9 @@
give_me_work()
# 2. Claim it. The claim verb is role-specific:
i_will_work_on(task_id) # Developer — claims + auto-creates the branch
claim_review(task_id) # QA — claims + auto-checks-out the dev's branch
claim_doc_task(task_id) # Documenter
i_will_work_on(task_id) # Developer — claims + auto-creates the branch
claim_review(task_id) # QA — claims + auto-checks-out the dev's branch
claim_doc_task(task_id) # Documenter
# Result:
# - status: claimed (then in_progress)