mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Board Program LEARN context, ruff 0.16, and verb-rejection observability (#700)
* fix(board): LEARN decisions name the item, not its per-cycle index A cycle's reject reasons are rendered into the NEXT cycle's exploration prompt, but the ref recorded alongside each reason was the item's stored id (item-0/item-1) — a per-cycle index that means something different every cycle and appears nowhere the explorer can resolve. The reason survived the loop; what it was about did not. Record the item's title instead, via a shared learn_ref() helper (falls back to the id when title-less, and reads target_task_title for Scales, whose items name the live task they mutate). * chore(lint): satisfy ruff 0.16 — keyword-only signatures and markdown formatting The dev toolchain resolved ruff 0.16.0, which stabilises PLR0917 (too many positional arguments) and formats python code blocks inside markdown. Both fired repo-wide and neither had anything to do with the code they flagged. - 36 signatures gain a `*` so their tail arguments are keyword-only, and the 104 call sites that passed them positionally are converted. mypy was the safety net for the static ones; the full suite caught nine more that only bind at runtime (the MCP tool functions, whose real callers already pass named JSON arguments). - 28 markdown files reformatted by 0.16's code-block formatter. - One RUF036 (`None` mid-union) autofixed in the GitLab provider. * fix(gateway): log the reason when a verb rejects A rejected envelope rides an HTTP 200, its body is never logged, and there is no trace table — so in the access log a verb an agent could not satisfy looks identical to one that worked. On 2026-07-25 four Board Programs (Periscope, Sentinel, Scales, Barfly) each POSTed their propose verb three or four times, persisted nothing, and left their exploration tasks PENDING; the reason was unrecoverable afterwards, from the logs or from the agents' own transcripts. Log error/message/remediate/missing plus the calling agent at envelope_to_response — the one chokepoint every v1 flow and do route returns through. Success envelopes stay silent. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
@@ -129,9 +129,9 @@ Biweekly cron, org-scoped. Playbook curation is otherwise reactive — you only
|
||||
propose_playbook_drafts(
|
||||
drafts=[
|
||||
{
|
||||
"title": "...", # <=200 chars, must not duplicate an existing playbook (case-insensitive)
|
||||
"body": "...", # <=4000 chars, the procedure itself
|
||||
"pattern_evidence": "...", # REQUIRED, <=500 chars — which repeated journal/learning pattern justifies this
|
||||
"title": "...", # <=200 chars, must not duplicate an existing playbook (case-insensitive)
|
||||
"body": "...", # <=4000 chars, the procedure itself
|
||||
"pattern_evidence": "...", # REQUIRED, <=500 chars — which repeated journal/learning pattern justifies this
|
||||
},
|
||||
# 1-3 drafts
|
||||
],
|
||||
|
||||
+20
-10
@@ -149,9 +149,9 @@ Each finding is inserted onto the task's revision-findings ledger (`origin=pm`)
|
||||
## Monitoring Your Cell
|
||||
|
||||
```python
|
||||
triage() # surfaces tasks waiting on you
|
||||
roboco_git_status(...) # workspace state
|
||||
roboco_git_log(...) # cell branch history
|
||||
triage() # surfaces tasks waiting on you
|
||||
roboco_git_status(...) # workspace state
|
||||
roboco_git_log(...) # cell branch history
|
||||
note(text="...", scope="reflect") # journal observations
|
||||
```
|
||||
|
||||
@@ -159,12 +159,20 @@ note(text="...", scope="reflect") # journal observations
|
||||
|
||||
```python
|
||||
# Cross-cell coordination
|
||||
dm(recipient="fe-pm", text="Need to align on shared schema; task X.",
|
||||
task_id="...", skill="api_design")
|
||||
dm(
|
||||
recipient="fe-pm",
|
||||
text="Need to align on shared schema; task X.",
|
||||
task_id="...",
|
||||
skill="api_design",
|
||||
)
|
||||
|
||||
# Ack-required notification (PMs / Board only)
|
||||
notify(target="be-dev-1", text="Please prioritise task X by EOD.",
|
||||
priority="high", task_id="...")
|
||||
notify(
|
||||
target="be-dev-1",
|
||||
text="Please prioritise task X by EOD.",
|
||||
priority="high",
|
||||
task_id="...",
|
||||
)
|
||||
```
|
||||
|
||||
## Assembling + Submitting Finished Work
|
||||
@@ -206,7 +214,9 @@ Use `escalate_up(task_id, reason)` when:
|
||||
- A non-cell agent is blocking you
|
||||
|
||||
```python
|
||||
escalate_up(task_id="<task>",
|
||||
reason="Frontend cell needs the new auth endpoint we own; "
|
||||
"they're blocked. Want to confirm priority swap.")
|
||||
escalate_up(
|
||||
task_id="<task>",
|
||||
reason="Frontend cell needs the new auth endpoint we own; "
|
||||
"they're blocked. Want to confirm priority swap.",
|
||||
)
|
||||
```
|
||||
|
||||
@@ -68,13 +68,15 @@ roboco_kb_search("similar documentation")
|
||||
Use `roboco_docs_write()` — handles paths and deduplication automatically:
|
||||
|
||||
```python
|
||||
roboco_docs_write({
|
||||
"task_id": "your-task-uuid",
|
||||
"filename": "feature-api.md",
|
||||
"doc_type": "api", # api, qa, guide, readme, changelog, architecture, design
|
||||
"title": "Feature API Documentation",
|
||||
"content": "# Feature API\n\n..."
|
||||
})
|
||||
roboco_docs_write(
|
||||
{
|
||||
"task_id": "your-task-uuid",
|
||||
"filename": "feature-api.md",
|
||||
"doc_type": "api", # api, qa, guide, readme, changelog, architecture, design
|
||||
"title": "Feature API Documentation",
|
||||
"content": "# Feature API\n\n...",
|
||||
}
|
||||
)
|
||||
```
|
||||
|
||||
**SMART DEDUPLICATION**: RAG searches for similar existing docs.
|
||||
|
||||
@@ -69,9 +69,9 @@ propose_market_brief(
|
||||
{"claim": "...", "source_url": "https://...", "relevance": "..."},
|
||||
# 1-7 findings, source_url REQUIRED per finding — an uncited claim is rejected
|
||||
],
|
||||
threats=["..."], # optional, up to 5
|
||||
opportunities=["..."], # optional, up to 5
|
||||
positioning_note="...", # optional
|
||||
threats=["..."], # optional, up to 5
|
||||
opportunities=["..."], # optional, up to 5
|
||||
positioning_note="...", # optional
|
||||
)
|
||||
```
|
||||
|
||||
@@ -99,8 +99,12 @@ Quarterly cron, project-scoped (`projects.board_programs` contains `"mirror"`).
|
||||
propose_messaging_fixes(
|
||||
items=[
|
||||
{
|
||||
"title": "...", "description": "...", "acceptance_criteria": ["..."],
|
||||
"project_slug": "roboco-website", "team": "backend", "priority": 2,
|
||||
"title": "...",
|
||||
"description": "...",
|
||||
"acceptance_criteria": ["..."],
|
||||
"project_slug": "roboco-website",
|
||||
"team": "backend",
|
||||
"priority": 2,
|
||||
"evidence": "BOTH the drifted claim and the reality it contradicts — REQUIRED",
|
||||
},
|
||||
# 1-5 items
|
||||
@@ -138,8 +142,8 @@ Cron every 2 days, org-scoped. The task carries a set of SCREENED candidate X co
|
||||
propose_conversation_replies(
|
||||
items=[
|
||||
{
|
||||
"tweet_id": "...", # REQUIRED — must be one of the candidate ids verbatim
|
||||
"reply_body": "...", # your voice, <=280 chars, no invented facts
|
||||
"tweet_id": "...", # REQUIRED — must be one of the candidate ids verbatim
|
||||
"reply_body": "...", # your voice, <=280 chars, no invented facts
|
||||
"rationale": "why this conversation is worth replying to", # REQUIRED
|
||||
},
|
||||
# up to 5 items
|
||||
@@ -166,7 +170,11 @@ The CEO acts via the panel/UI; you idle until the CEO decides.
|
||||
## A2A
|
||||
|
||||
```python
|
||||
dm(recipient="product-owner", text="Market analysis for the launch — ...", task_id="...")
|
||||
dm(
|
||||
recipient="product-owner",
|
||||
text="Market analysis for the launch — ...",
|
||||
task_id="...",
|
||||
)
|
||||
```
|
||||
|
||||
Skills: market_analysis
|
||||
|
||||
@@ -68,7 +68,7 @@ notify(target="be-pm", text="New initiative assigned — see task", task_id=subt
|
||||
|
||||
Monitor via:
|
||||
```python
|
||||
triage_all() # actionable tasks across all teams (Main PM only)
|
||||
triage_all() # actionable tasks across all teams (Main PM only)
|
||||
```
|
||||
|
||||
## Tool Surface (per-spawn manifest)
|
||||
|
||||
@@ -107,8 +107,12 @@ Biweekly cron, project-scoped (`projects.board_programs` contains `"spackle"`).
|
||||
propose_gap_fill(
|
||||
items=[
|
||||
{
|
||||
"title": "...", "description": "...", "acceptance_criteria": ["..."],
|
||||
"project_slug": "roboco-api", "team": "backend", "priority": 2,
|
||||
"title": "...",
|
||||
"description": "...",
|
||||
"acceptance_criteria": ["..."],
|
||||
"project_slug": "roboco-api",
|
||||
"team": "backend",
|
||||
"priority": 2,
|
||||
"evidence": "BOTH sides of the gap — REQUIRED",
|
||||
},
|
||||
# 1-5 items
|
||||
@@ -146,8 +150,12 @@ Event-triggered only (a release-publish hook, or the CEO's "run now") — no cro
|
||||
propose_friction_fixes(
|
||||
items=[
|
||||
{
|
||||
"title": "...", "description": "...", "acceptance_criteria": ["..."],
|
||||
"project_slug": "roboco-api", "team": "frontend", "priority": 2,
|
||||
"title": "...",
|
||||
"description": "...",
|
||||
"acceptance_criteria": ["..."],
|
||||
"project_slug": "roboco-api",
|
||||
"team": "frontend",
|
||||
"priority": 2,
|
||||
"evidence": "the walked path (which pages, which clicks) — prose only, never a screenshot — REQUIRED",
|
||||
},
|
||||
# 1-5 items
|
||||
|
||||
@@ -143,10 +143,11 @@ The system blocks QA from reviewing their own dev work. The `original_developer`
|
||||
`escalate_up` is **not** in your manifest. Use `dm` to your Cell PM if something needs attention beyond pass/fail:
|
||||
|
||||
```python
|
||||
dm(recipient="be-pm",
|
||||
text="Task X — security concern, can you take a look before we "
|
||||
"merge?",
|
||||
task_id="...")
|
||||
dm(
|
||||
recipient="be-pm",
|
||||
text="Task X — security concern, can you take a look before we merge?",
|
||||
task_id="...",
|
||||
)
|
||||
```
|
||||
|
||||
For an external blocker (test environment broken, can't reproduce, missing infra), use `i_am_blocked(task_id, reason="...")` — your Cell PM is notified and `unblock`s you. If the work itself is wrong, `fail(task_id, findings=[...])` with the full context is the right move; the Cell PM picks it up from `needs_revision`.
|
||||
|
||||
Reference in New Issue
Block a user