mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Board Program LEARN context, ruff 0.16, and verb-rejection observability (#700)
* fix(board): LEARN decisions name the item, not its per-cycle index A cycle's reject reasons are rendered into the NEXT cycle's exploration prompt, but the ref recorded alongside each reason was the item's stored id (item-0/item-1) — a per-cycle index that means something different every cycle and appears nowhere the explorer can resolve. The reason survived the loop; what it was about did not. Record the item's title instead, via a shared learn_ref() helper (falls back to the id when title-less, and reads target_task_title for Scales, whose items name the live task they mutate). * chore(lint): satisfy ruff 0.16 — keyword-only signatures and markdown formatting The dev toolchain resolved ruff 0.16.0, which stabilises PLR0917 (too many positional arguments) and formats python code blocks inside markdown. Both fired repo-wide and neither had anything to do with the code they flagged. - 36 signatures gain a `*` so their tail arguments are keyword-only, and the 104 call sites that passed them positionally are converted. mypy was the safety net for the static ones; the full suite caught nine more that only bind at runtime (the MCP tool functions, whose real callers already pass named JSON arguments). - 28 markdown files reformatted by 0.16's code-block formatter. - One RUF036 (`None` mid-union) autofixed in the GitLab provider. * fix(gateway): log the reason when a verb rejects A rejected envelope rides an HTTP 200, its body is never logged, and there is no trace table — so in the access log a verb an agent could not satisfy looks identical to one that worked. On 2026-07-25 four Board Programs (Periscope, Sentinel, Scales, Barfly) each POSTed their propose verb three or four times, persisted nothing, and left their exploration tasks PENDING; the reason was unrecoverable afterwards, from the logs or from the agents' own transcripts. Log error/message/remediate/missing plus the calling agent at envelope_to_response — the one chokepoint every v1 flow and do route returns through. Success envelopes stay silent. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
@@ -43,10 +43,7 @@ Cell Members → Cell PM → Main PM → Product Owner → CEO
|
||||
## Escalation Tool
|
||||
|
||||
```python
|
||||
escalate_up(
|
||||
task_id="uuid-here",
|
||||
reason="Need clarification on requirements"
|
||||
)
|
||||
escalate_up(task_id="uuid-here", reason="Need clarification on requirements")
|
||||
```
|
||||
|
||||
Auto-routes to your escalation target. You CANNOT choose a different target. `escalate_up` is a PM verb (Cell PM / Main PM); cell members (devs, QA, documenters) signal blockers with `i_am_blocked(task_id, reason)`, which their Cell PM resolves.
|
||||
@@ -54,10 +51,7 @@ Auto-routes to your escalation target. You CANNOT choose a different target. `es
|
||||
## CEO Escalation (Main PM / Board Only)
|
||||
|
||||
```python
|
||||
escalate_to_ceo(
|
||||
task_id="uuid-here",
|
||||
reason="Major feature ready for approval"
|
||||
)
|
||||
escalate_to_ceo(task_id="uuid-here", reason="Major feature ready for approval")
|
||||
```
|
||||
|
||||
Requirements:
|
||||
|
||||
@@ -90,7 +90,7 @@ def _check_intent_preconditions(
|
||||
spec_intent: IntentSpec, task: Any, ctx: Context
|
||||
) -> Decision | None:
|
||||
"""Verb-level extra_preconditions gate.
|
||||
|
||||
|
||||
If the first failing precondition has rejection_kind='not_authorized',
|
||||
return Decision.reject(kind='not_authorized').
|
||||
All other failures return Decision.tracing_gap.
|
||||
@@ -102,12 +102,11 @@ def _check_intent_preconditions(
|
||||
]
|
||||
if not missing:
|
||||
return None
|
||||
|
||||
|
||||
first_missing = next(
|
||||
p for p in spec_intent.extra_preconditions
|
||||
if p.missing_token == missing[0]
|
||||
p for p in spec_intent.extra_preconditions if p.missing_token == missing[0]
|
||||
)
|
||||
|
||||
|
||||
# Check the rejection_kind of the first failing precondition
|
||||
if first_missing.rejection_kind == "not_authorized":
|
||||
return Decision.reject(
|
||||
@@ -115,12 +114,9 @@ def _check_intent_preconditions(
|
||||
message=first_missing.remediate,
|
||||
remediate=first_missing.remediate,
|
||||
)
|
||||
|
||||
|
||||
# Default: tracing_gap with missing tokens
|
||||
return Decision.tracing_gap(
|
||||
missing=missing,
|
||||
remediate=first_missing.remediate
|
||||
)
|
||||
return Decision.tracing_gap(missing=missing, remediate=first_missing.remediate)
|
||||
```
|
||||
|
||||
The key insight: **Only the first failing precondition's `rejection_kind` is checked.** This ensures ownership gates are checked early (they usually are in the preconditions list) so unowned tasks fail fast with `not_authorized` instead of collecting other tracing gaps.
|
||||
|
||||
@@ -17,13 +17,13 @@ Each takes `findings: list[dict]` — a list of structured findings. The legacy
|
||||
|
||||
```python
|
||||
{
|
||||
"file": "roboco/api/routes/rate_limit.py", # optional; repo-relative, no ".."
|
||||
"line": 88, # optional; >= 1
|
||||
"severity": "blocker", # required: blocker | major | minor | nit
|
||||
"file": "roboco/api/routes/rate_limit.py", # optional; repo-relative, no ".."
|
||||
"line": 88, # optional; >= 1
|
||||
"severity": "blocker", # required: blocker | major | minor | nit
|
||||
"criterion": "<acceptance-criterion id or exact text>", # optional
|
||||
"expected": "429 on the 101st request", # required, <=300 chars
|
||||
"actual": "the 100th request also 429s", # required, <=300 chars
|
||||
"fix": "use > not >= on the window limit", # optional, <=500 chars — describe the change, never a literal patch
|
||||
"expected": "429 on the 101st request", # required, <=300 chars
|
||||
"actual": "the 100th request also 429s", # required, <=300 chars
|
||||
"fix": "use > not >= on the window limit", # optional, <=500 chars — describe the change, never a literal patch
|
||||
"evidence": "<failing test output / CI lines / diff hunk>", # optional, <=2000 chars
|
||||
}
|
||||
```
|
||||
|
||||
Reference in New Issue
Block a user