docs(rag): close the corpus drift — findings/collision/fast-path/forge/env-ladder coverage (#596)

Seventeen-page sweep of the agent-facing KB against shipped behavior:
required covers_parent_criteria and per-AC criteria_verified reach the
QA/PM/task-tools pages (the QA docs also named non-callable pass_review/
fail_review — the MCP tools are pass/fail); collision_context lands in the
QA/gate/planning evidence docs; the possibilities matrix gets its own
architecture page + config entry; the auditor page gains its missing
waive_finding and playbook-curation verbs; git-pr-types.md is rewritten
off the long-dead is_root_pr model; PR/workspace/git-error pages stop
assuming GitHub (forge-agnostic + env-ladder semantics).

Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
Renzo F
2026-07-19 19:00:48 +02:00
committed by GitHub
co-authored by Renn F
parent 700dbcd285
commit 862c0b27cd
17 changed files with 217 additions and 47 deletions
+18 -3
View File
@@ -42,17 +42,32 @@ You still cannot claim tasks, message agents, or write code — the scheduled sw
- Record private observations via `note(text="...", scope="reflect")`
- Attach evidence via `evidence(task_id)`
- Search the knowledge base via `roboco_ask_mentor` / `roboco_kb_search`
- Waive one open **minor/nit** revision-findings-ledger finding via `waive_finding(finding_id, note)` — see below
- Curate the KB's playbook queue via `approve_playbook` / `reject_playbook` / `archive_playbook` — a deliberate, bounded expansion of your read-only surface (KB curation, not agent comms, so the no-`dm` restriction still holds)
- Curate the Obsidian vault's narrative for a just-completed root task-tree via `curate_vault(task_id, narrative)` — see below (only when `ROBOCO_OBSIDIAN_VAULT_ENABLED`)
## What You CANNOT Do
- Claim, create, assign, complete, or cancel tasks
- Pass or fail QA
- Escalate (`triage` is your only flow verb besides `i_am_idle`)
- Escalate (`triage` is your only flow verb besides `i_am_idle`/`waive_finding`)
- DM agents (`dm`) or send `notify`
- Acknowledge notifications (silent observer — `notify_ack` is not yours)
- Write to project docs, write code, or run git write operations
## Waiving a review finding
The Auditor is the **only** role that can close a revision-findings-ledger finding without a dev actually fixing it — and only for non-blocking severity:
```python
waive_finding(
finding_id="a1b2c3d4",
note="Cosmetic — the naming nit doesn't affect behavior; not worth a rework cycle.",
)
```
`severity=blocker` and `severity=major` findings are refused outright — they must be fixed, never waived. Only `minor`/`nit` findings, still `open`, are eligible, and `note` is required (an empty note is rejected). No task status change: the ledger row moves `open -> waived` and a `task.finding_waived` audit event records the decision. See `docs/rag/architecture/review-findings.md`.
## Silent Observer Mode
The Auditor has **silent read access** across the org:
@@ -89,8 +104,8 @@ When the Obsidian vault is armed, the orchestrator spawns you once per completed
| MCP server | Verbs you can call |
|-----------------------|--------------------|
| `roboco-flow` | `triage`, `i_am_idle` |
| `roboco-do` | `note` (scope=`reflect`), `evidence`, `notify_list`, `notify_get`, `curate_vault` |
| `roboco-flow` | `triage`, `waive_finding`, `i_am_idle` |
| `roboco-do` | `note` (scope=`reflect`), `evidence`, `notify_list`, `notify_get`, `approve_playbook`, `reject_playbook`, `archive_playbook`, `curate_vault` |
| `roboco-git-readonly` | `roboco_git_status`, `roboco_git_log`, `roboco_git_diff`, `roboco_git_branch_list` |
| `roboco-optimal` | `roboco_ask_mentor`, `roboco_kb_search` |