External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[529f579a] Implement Prompter chat endpoint and structured task drafting (#76) (#77)

Browse Source 
* [529f579a] feat(prompter): add PrompterService with chat and draft generation endpoints

* [529f579a] feat(prompter): add PrompterService, schemas, routes, and integration tests

* [529f579a] feat(prompter): implement session-based prompter chat endpoints with DB persistence

Add full session-based Prompter chat system with:
- Alembic migration 024 creating prompter_sessions, prompter_messages, and task_drafts tables with proper foreign keys, indexes, and enum columns
- Three new SQLAlchemy ORM table classes in roboco/db/tables.py
- Pydantic schemas: PrompterSessionCreateRequest, PrompterMessageRequest, PrompterSessionResponse, PrompterMessageResponse, TaskDraftResponse, TaskConfirmRequest
- Four new session-based FastAPI routes: POST /sessions, POST /sessions/{id}/messages, GET /sessions/{id}/draft, POST /sessions/{id}/confirm
- PrompterService with DB-backed session, message, and draft persistence; LLM-driven draft generation; ConfirmOverrides dataclass to stay under PLR0913
- Legacy stateless /chat and /draft endpoints retained for backward compatibility
- Unit tests for schemas (test_schemas_prompter.py), service pure functions and DB logic (test_prompter.py) with mocked LLM calls
- Integration tests for full happy path and legacy endpoints (test_prompter_routes.py)
- All ruff format, ruff check, mypy (changed files), and pytest checks passing

* [529f579a] fix(prompter): correct test assertion for confirmed_at field nesting

The test test_get_draft_generates_from_conversation incorrectly
accessed body['draft']['confirmed_at'] but confirmed_at is a field
on the outer TaskDraftResponse, not on the nested PrompterDraftTask.
Fixed to body['confirmed_at'].

---------

Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
This commit is contained in:
Renzo F
2026-06-07 22:16:56 +02:00
committed by GitHub
co-authored by Backend Developer 2
parent d5cbbf49ee
commit 85ffec86b4
19 changed files with 2866 additions and 724 deletions
Download Patch File Download Diff File Expand all files Collapse all files
alembic/versions/023_add_prompter_tracking_columns.py
+37
View File
@@ -0,0 +1,37 @@
"""Add prompter origin tracking columns to tasks table.
Adds `source` (varchar 50, default 'manual') and `confirmed_by_human`
(boolean, default false) to support the Prompter conversational assistant
feature. Prompter-originated tasks require human confirmation before entering
the workflow.
Revision ID: 023_add_prompter_tracking_columns
Revises: 022_default_branch_master
Create Date: 2026-06-07
"""
from __future__ import annotations
import sqlalchemy as sa
from alembic import op
revision = "023_add_prompter_tracking_columns"
down_revision = "022_default_branch_master"
branch_labels = None
depends_on = None
def upgrade() -> None:
op.add_column(
"tasks",
sa.Column("source", sa.String(length=50), server_default="manual", nullable=False),
)
op.add_column(
"tasks",
sa.Column("confirmed_by_human", sa.Boolean(), server_default=sa.false(), nullable=False),
)
def downgrade() -> None:
op.drop_column("tasks", "confirmed_by_human")
op.drop_column("tasks", "source")
alembic/versions/024_add_prompter_tables.py
+145
View File
@@ -0,0 +1,145 @@
"""Add prompter_sessions, prompter_messages, and task_drafts tables.
Adds three new tables to support the Prompter conversational assistant
feature with DB-persisted conversation history and task draft tracking:
- prompter_sessions: links a conversation session to an authenticated agent
- prompter_messages: stores the full message history (user + assistant turns)
- task_drafts: stores structured task drafts extracted from conversations;
links to a real Task once the human confirms via /confirm endpoint
Revision ID: 024_add_prompter_tables
Revises: 023_add_prompter_tracking_columns
Create Date: 2026-06-07
"""
from __future__ import annotations
import sqlalchemy as sa
from alembic import op
from sqlalchemy.dialects.postgresql import JSONB, UUID
revision = "024_add_prompter_tables"
down_revision = "023_add_prompter_tracking_columns"
branch_labels = None
depends_on = None
def upgrade() -> None:
# --- prompter_sessions -----------------------------------------------
op.create_table(
"prompter_sessions",
sa.Column("id", UUID(as_uuid=True), primary_key=True),
sa.Column(
"agent_id",
UUID(as_uuid=True),
sa.ForeignKey("agents.id", ondelete="CASCADE"),
nullable=False,
),
sa.Column(
"status",
sa.Enum(
"active",
"draft_ready",
"confirmed",
"abandoned",
name="promptersessionstatus",
),
nullable=False,
server_default="active",
),
sa.Column(
"created_at",
sa.DateTime(timezone=True),
nullable=False,
server_default=sa.func.now(),
),
sa.Column(
"updated_at",
sa.DateTime(timezone=True),
nullable=True,
onupdate=sa.func.now(),
),
)
op.create_index("ix_prompter_sessions_agent_id", "prompter_sessions", ["agent_id"])
op.create_index(
"ix_prompter_sessions_status", "prompter_sessions", ["status"]
)
# --- prompter_messages -----------------------------------------------
op.create_table(
"prompter_messages",
sa.Column("id", UUID(as_uuid=True), primary_key=True),
sa.Column(
"session_id",
UUID(as_uuid=True),
sa.ForeignKey("prompter_sessions.id", ondelete="CASCADE"),
nullable=False,
),
sa.Column(
"role",
sa.Enum("user", "assistant", "system", name="promptermessagerole"),
nullable=False,
),
sa.Column("content", sa.Text, nullable=False),
sa.Column(
"created_at",
sa.DateTime(timezone=True),
nullable=False,
server_default=sa.func.now(),
),
)
op.create_index(
"ix_prompter_messages_session_id", "prompter_messages", ["session_id"]
)
op.create_index(
"ix_prompter_messages_session_created",
"prompter_messages",
["session_id", "created_at"],
)
# --- task_drafts -----------------------------------------------------
op.create_table(
"task_drafts",
sa.Column("id", UUID(as_uuid=True), primary_key=True),
sa.Column(
"session_id",
UUID(as_uuid=True),
sa.ForeignKey("prompter_sessions.id", ondelete="CASCADE"),
nullable=False,
),
sa.Column("draft_data", JSONB, nullable=False),
sa.Column("confirmed_at", sa.DateTime(timezone=True), nullable=True),
sa.Column(
"task_id",
UUID(as_uuid=True),
sa.ForeignKey("tasks.id", ondelete="SET NULL"),
nullable=True,
),
sa.Column(
"created_at",
sa.DateTime(timezone=True),
nullable=False,
server_default=sa.func.now(),
),
sa.Column(
"updated_at",
sa.DateTime(timezone=True),
nullable=True,
onupdate=sa.func.now(),
),
)
op.create_index("ix_task_drafts_session_id", "task_drafts", ["session_id"])
op.create_index("ix_task_drafts_task_id", "task_drafts", ["task_id"])
def downgrade() -> None:
op.drop_table("task_drafts")
op.drop_index("ix_prompter_messages_session_created", "prompter_messages")
op.drop_index("ix_prompter_messages_session_id", "prompter_messages")
op.drop_table("prompter_messages")
op.drop_index("ix_prompter_sessions_status", "prompter_sessions")
op.drop_index("ix_prompter_sessions_agent_id", "prompter_sessions")
op.drop_table("prompter_sessions")
op.execute("DROP TYPE IF EXISTS promptersessionstatus")
op.execute("DROP TYPE IF EXISTS promptermessagerole")