mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[F061] audit status-transition rows now written in-session (F061/F073/F075)
_emit_status_transition_audit now writes AuditLogTable rows into self.session synchronously (session.add) instead of dispatching AuditService.log_task_event fire-and-forget on its own connection. The audit row now commits/rolls back atomically with the status transition in the caller's transaction, closing three facets at once: - F061: audit commit no longer decoupled from the transition commit - F073: a committed transition can no longer have NO audit row (the row rides the same transaction; a swallowed persist can't drop it) - F075: a transition rolled back inside a verb savepoint no longer leaves a phantom audit row (the row is in the savepoint too) log_task_event is now called only from this helper (narrow blast radius verified); revision_count increment stays at this single chokepoint. Cycle-time/bottleneck reconstruction from task.<status> events is no longer silently corruptible. Tests: test_emit_status_transition_audit_writes_in_session_atomically, test_finalize_claim_rollback_emits_reversal_audit, escalation-audit tests retargeted to in-session AuditLogTable rows. Also: _canonical_bump_files grep-looseness follow-on (F058) -- filter by subject, not body; git log --grep matches any message line, so a non-release commit whose body references chore(release): shadowed the real release commit. Test test_canonical_bump_files_ignores_body_only_chore_release_match.
This commit is contained in:
@@ -14,6 +14,7 @@ from unittest.mock import AsyncMock, MagicMock, patch
|
||||
from uuid import uuid4
|
||||
|
||||
import pytest
|
||||
from roboco.db.tables import AuditLogTable
|
||||
from roboco.models.base import (
|
||||
AgentRole,
|
||||
AgentStatus,
|
||||
@@ -1117,6 +1118,55 @@ async def test_finalize_claim_rollback_emits_reversal_audit() -> None:
|
||||
assert {"from": "claimed", "to": "pending"} in audit_calls
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_emit_status_transition_audit_writes_in_session_atomically() -> None:
|
||||
"""F061/F073/F075: the status-transition audit row is written into the
|
||||
CALLER's session (same transaction as the transition), not fire-and-forget
|
||||
on a separate connection.
|
||||
|
||||
Fire-and-forget decouples the audit commit from the transition commit:
|
||||
a transition that rolls back inside a verb savepoint leaves a PHANTOM audit
|
||||
row (F075), and a swallowed persist failure means a committed transition
|
||||
can have NO audit row (F073) — silently corrupting the cycle-time /
|
||||
bottleneck metrics reconstructed from ``task.<status>`` events (F061).
|
||||
Writing the row in-session makes it commit/roll back atomically with the
|
||||
transition, closing all three. Asserted at the unit level: the row is
|
||||
``session.add``-ed (same txn) with the metric-reconstruction details, and
|
||||
NO fire-and-forget background task is spawned.
|
||||
"""
|
||||
svc = TaskService(MagicMock())
|
||||
added: list[object] = []
|
||||
svc.session.add = MagicMock(side_effect=added.append) # type: ignore[assignment]
|
||||
prior_bg = set(svc._background_tasks)
|
||||
|
||||
task = MagicMock(id=uuid4(), claimed_by=uuid4(), team=Team.BACKEND)
|
||||
|
||||
svc._emit_status_transition_audit(
|
||||
task,
|
||||
from_status="pending",
|
||||
to_status="claimed",
|
||||
agent_role="developer",
|
||||
audit_agent_id=None,
|
||||
)
|
||||
|
||||
# The audit row is added to the CALLER's session (same transaction) — not
|
||||
# dispatched to a separate fire-and-forget connection.
|
||||
rows = [r for r in added if isinstance(r, AuditLogTable)]
|
||||
assert len(rows) == 1
|
||||
row = rows[0]
|
||||
assert row.event_type == "task.claimed"
|
||||
assert row.target_type == "task"
|
||||
assert row.target_id == task.id
|
||||
assert row.details["from_status"] == "pending"
|
||||
assert row.details["to_status"] == "claimed"
|
||||
assert row.details["agent_role"] == "developer"
|
||||
assert row.details["team"] == "backend"
|
||||
# The claiming agent is attributed (resolved from claimed_by).
|
||||
assert row.agent_id == task.claimed_by
|
||||
# No fire-and-forget audit task was spawned (the old decoupled path).
|
||||
assert svc._background_tasks == prior_bg
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# _resolve_doc_abspath — normalize documenter-supplied paths under /app/docs
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
Reference in New Issue
Block a user