mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[1dae04a7] Video: release 0.25.0 (revision) (#536)
* fix(release): CI wait polls the prod rung; escape the header tooltip apostrophe get_latest_ci_conclusion defaults to the ladder's head rung, so wait_for_ci searched slave for a release commit that lives on master and timed out after 40 minutes with the run already green. The wait now passes the prod branch explicitly. Also fixes the react/no-unescaped-entities error that turned master's Panel CI red. * fix(panel,video): dead dialog triggers behind tooltips; dotted composition ids render HelpTip nested inside a Dialog/AlertDialog trigger puts the trigger's click handler on the Tooltip root, which renders no DOM — the agents Spawn item and the KB Reindex-All / Delete-index confirms were dead. Tooltips now wrap the triggers. The video renderer accepts interior single dots in composition ids (release-0.25.0) with '..' still unrepresentable, and propose_video refuses an unrenderable id at authoring time. * fix(dispatch): restart-safe PM review turns A leaf task in awaiting_pm_review had no periodic pickup: the closure dispatcher bailed on childless tasks and skipped PR-bearing review tasks as already-promoted, assuming the submit-time PM session was still alive — an assumption every restart breaks. Proven live on the docs-sync leaf after the 0.25.0 redeploy, which also dependency-blocked its sibling dev task. Childless awaiting_pm_review tasks now flow to the PM's review turn, and the merge turn respawns its PM when none is active. * [1dae04a7] Revise release-0.25.0 composition to 40s scene-based pacing with four feature cards * [1dae04a7] docs(motion): update release-0.25.0 README section for 40s four-card revision --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com> Co-authored-by: UX/UI Developer 1 <ux-dev-1@roboco.tech> Co-authored-by: UX/UI Documenter <ux-doc@roboco.tech>
This commit is contained in:
co-authored by
Renn F
UX/UI Developer 1
UX/UI Documenter
parent
63212899ca
commit
797847e379
@@ -161,3 +161,38 @@ async def test_auto_recover_blocked_swallows_errors() -> None:
|
||||
|
||||
# Must not raise.
|
||||
await orch._auto_recover_blocked_parent(client, "p")
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_childless_awaiting_pm_review_reaches_closure() -> None:
|
||||
"""A leaf task in awaiting_pm_review (dev->qa->doc ran on the task itself)
|
||||
is the PM's review turn — it must flow past the descendants gate, or a
|
||||
restart-stranded review has no periodic pickup at all."""
|
||||
orch = _ready_orch()
|
||||
orch._fetch_all_descendants = AsyncMock(return_value=[])
|
||||
orch._closure_handled_without_pm = AsyncMock(return_value=(True, None))
|
||||
task = {"id": "t1", "status": "awaiting_pm_review", "team": "frontend"}
|
||||
await orch._maybe_spawn_pm_closure(MagicMock(), task)
|
||||
orch._closure_handled_without_pm.assert_awaited_once()
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_childless_in_progress_still_bails() -> None:
|
||||
"""A childless claimed/in_progress task is a dev's work, not PM closure
|
||||
material — the descendants gate must still bail."""
|
||||
orch = _ready_orch()
|
||||
orch._fetch_all_descendants = AsyncMock(return_value=[])
|
||||
orch._closure_handled_without_pm = AsyncMock(return_value=(True, None))
|
||||
task = {"id": "t1", "status": "in_progress", "team": "frontend"}
|
||||
await orch._maybe_spawn_pm_closure(MagicMock(), task)
|
||||
orch._closure_handled_without_pm.assert_not_awaited()
|
||||
|
||||
|
||||
def test_promoted_skip_excludes_the_pm_merge_turn() -> None:
|
||||
"""awaiting_pm_review IS the PM's turn — a PR-bearing task there must not
|
||||
be skipped as already-promoted (the submit-time PM session may be gone)."""
|
||||
promoted = AgentOrchestrator._already_promoted_for_closure
|
||||
assert not promoted({"pr_number": 5, "status": "awaiting_pm_review"})
|
||||
assert promoted({"pr_number": 5, "status": "awaiting_ceo_approval"})
|
||||
assert promoted({"pr_number": 5, "status": "completed"})
|
||||
assert not promoted({"pr_number": None, "status": "completed"})
|
||||
|
||||
Reference in New Issue
Block a user