mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
revert(briefing): drop the verb->MCP-server map from the agent briefing
The map told agents to hand-construct mcp__<server>__<verb> tool names, which do not match what their runtime exposes — agents fumbled (No such tool available: mcp__roboco-do__evidence) and had to retry the bare verb. It also did not reduce the opening-move fumbling it targeted; agents recover via the gateway's own remediate hints regardless. Net-negative. Reverts3d04943and its follow-up5462fe3.
This commit is contained in:
Renn F
@@ -1,181 +0,0 @@
|
||||
"""The session briefing must carry a verb->MCP-server map + key preconditions.
|
||||
|
||||
Agents repeatedly fumble their first move: calling raw bash/http/shell-git,
|
||||
invoking ``evidence`` on roboco-flow (it lives on roboco-do), omitting the
|
||||
``nature`` argument on ``delegate``, or skipping the required journal note
|
||||
before claiming. The role docs cover this but agents cannot read them at
|
||||
spawn, so the briefing embeds a concise, role-accurate block generated from
|
||||
the role's actual manifest (``get_role_config``).
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
import asyncio
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
from unittest.mock import patch
|
||||
|
||||
from roboco.foundation.policy.journaling import SCOPE_TO_TYPE, Scope
|
||||
from roboco.foundation.policy.tracing import Requirement
|
||||
from roboco.models.base import JournalEntryType
|
||||
from roboco.runtime.orchestrator import AgentOrchestrator
|
||||
from roboco.services.gateway.role_config import get_role_config
|
||||
|
||||
|
||||
def _orch() -> AgentOrchestrator:
|
||||
with patch.object(AgentOrchestrator, "__init__", return_value=None):
|
||||
orch = AgentOrchestrator.__new__(AgentOrchestrator)
|
||||
orch._VERB_SERVER_CACHE = {}
|
||||
return orch
|
||||
|
||||
|
||||
def test_developer_block_maps_flow_verbs_to_flow_server() -> None:
|
||||
block = _orch()._build_verb_server_block("developer")
|
||||
cfg = get_role_config("developer")
|
||||
# Every flow verb the role can call is attributed to roboco-flow.
|
||||
flow_section = block.split("roboco-flow", 1)[1].split("roboco-do", 1)[0]
|
||||
for verb in cfg.flow_tools:
|
||||
assert verb in flow_section, f"{verb} missing from roboco-flow line"
|
||||
|
||||
|
||||
def test_developer_block_puts_evidence_on_do_not_flow() -> None:
|
||||
block = _orch()._build_verb_server_block("developer")
|
||||
do_section = block.split("roboco-do", 1)[1].split("roboco-git-readonly", 1)[0]
|
||||
flow_section = block.split("roboco-flow", 1)[1].split("roboco-do", 1)[0]
|
||||
assert "evidence" in do_section
|
||||
assert "evidence" not in flow_section
|
||||
|
||||
|
||||
def test_developer_block_lists_git_readonly_and_optimal_servers() -> None:
|
||||
block = _orch()._build_verb_server_block("developer")
|
||||
assert "roboco-git-readonly" in block
|
||||
assert "roboco-optimal" in block
|
||||
assert "roboco_ask_mentor" in block
|
||||
|
||||
|
||||
def test_developer_block_states_note_before_claim_precondition() -> None:
|
||||
# The i_will_work_on claim gate is journal:note_at_claim, enforced via
|
||||
# JournalService.has_note_for_task -> JournalEntryType.GENERAL. The only
|
||||
# note scope that maps to GENERAL is scope='note' (scope='decision' maps
|
||||
# to DECISION_LOG and is the PM's i_will_plan gate). The briefing MUST
|
||||
# name the scope that actually satisfies the gate, not 'decision'.
|
||||
block = _orch()._build_verb_server_block("developer")
|
||||
assert "note(scope='note')" in block
|
||||
assert "i_will_work_on" in block.split("note(scope='note')", 1)[1]
|
||||
# The decision scope must NOT be the dev-claim precondition.
|
||||
assert "note(scope='decision')" not in block
|
||||
|
||||
|
||||
def test_developer_claim_precondition_scope_matches_real_gate_type() -> None:
|
||||
# Validate against the REAL boundary: the JOURNAL_NOTE_AT_CLAIM requirement
|
||||
# on i_will_work_on is satisfied by has_note_for_task, which queries
|
||||
# JournalEntryType.GENERAL. Whatever scope the briefing emits MUST be the
|
||||
# scope whose SCOPE_TO_TYPE mapping equals the type the gate checks.
|
||||
assert Requirement.JOURNAL_NOTE_AT_CLAIM.value == "journal:note_at_claim"
|
||||
gate_type = JournalEntryType.GENERAL # has_note_for_task checks this type
|
||||
satisfying_scopes = {
|
||||
scope.value for scope, jtype in SCOPE_TO_TYPE.items() if jtype is gate_type
|
||||
}
|
||||
assert satisfying_scopes == {Scope.NOTE.value}
|
||||
|
||||
block = _orch()._build_verb_server_block("developer")
|
||||
for scope_value in satisfying_scopes:
|
||||
assert f"note(scope='{scope_value}')" in block
|
||||
# A scope that does NOT map to the gate type must not be presented as the
|
||||
# i_will_work_on precondition.
|
||||
non_satisfying = {s.value for s in Scope} - satisfying_scopes
|
||||
for scope_value in non_satisfying:
|
||||
claim_clause = f"note(scope='{scope_value}') is REQUIRED before i_will_work_on"
|
||||
assert claim_clause not in block
|
||||
|
||||
|
||||
def test_developer_block_forbids_raw_bash_http_shell_git() -> None:
|
||||
block = _orch()._build_verb_server_block("developer")
|
||||
lowered = block.lower()
|
||||
assert "shell git" in lowered or "shell-git" in lowered
|
||||
assert "raw" in lowered
|
||||
|
||||
|
||||
def test_pm_block_states_delegate_requires_nature() -> None:
|
||||
block = _orch()._build_verb_server_block("cell_pm")
|
||||
assert "delegate" in block
|
||||
assert "nature" in block
|
||||
|
||||
|
||||
def test_pm_plan_precondition_stays_decision_scope() -> None:
|
||||
# The PM's i_will_plan gate is journal:decision_at_claim, enforced via
|
||||
# has_decision_for_task -> JournalEntryType.DECISION_LOG. The only scope
|
||||
# that maps to DECISION_LOG is scope='decision', so the i_will_plan
|
||||
# precondition must keep scope='decision' (this branch is correct).
|
||||
decision_scopes = {
|
||||
scope.value
|
||||
for scope, jtype in SCOPE_TO_TYPE.items()
|
||||
if jtype is JournalEntryType.DECISION_LOG
|
||||
}
|
||||
assert decision_scopes == {Scope.DECISION.value}
|
||||
|
||||
block = _orch()._build_verb_server_block("cell_pm")
|
||||
assert "note(scope='decision')" in block
|
||||
assert "i_will_plan" in block.split("note(scope='decision')", 1)[1]
|
||||
|
||||
|
||||
def test_qa_block_has_no_delegate_or_note_before_claim_noise() -> None:
|
||||
# QA has no delegate verb, so the nature precondition must not appear;
|
||||
# QA has no claim-with-plan verb, so note-before-claim must not appear.
|
||||
block = _orch()._build_verb_server_block("qa")
|
||||
assert "delegate" not in block
|
||||
assert "note(scope='decision')" not in block
|
||||
# But it must still carry the no-raw-bash rule and its own flow verbs.
|
||||
assert "pass_review" in block
|
||||
assert "shell" in block.lower()
|
||||
|
||||
|
||||
def test_head_marketing_block_lists_docs_server() -> None:
|
||||
# Head of Marketing is handed the roboco-docs MCP at spawn for read-only
|
||||
# oversight; the briefing must surface it (and the service READ_ROLES must
|
||||
# agree, or list/read 403 against a tool the agent was given).
|
||||
block = _orch()._build_verb_server_block("head_marketing")
|
||||
assert "roboco-docs" in block
|
||||
assert "roboco_docs_read" in block
|
||||
|
||||
|
||||
def test_unknown_role_returns_empty() -> None:
|
||||
assert _orch()._build_verb_server_block("nonexistent") == ""
|
||||
|
||||
|
||||
def test_block_is_cached_per_role() -> None:
|
||||
orch = _orch()
|
||||
first = orch._build_verb_server_block("developer")
|
||||
second = orch._build_verb_server_block("developer")
|
||||
assert first is second
|
||||
|
||||
|
||||
def test_block_is_embedded_in_written_briefing() -> None:
|
||||
orch = _orch()
|
||||
orch._VERB_SERVER_CACHE = {}
|
||||
orch._TOOL_LOAD_CACHE = {}
|
||||
|
||||
with (
|
||||
patch("roboco.runtime.orchestrator.get_agent_role", return_value="developer"),
|
||||
patch("roboco.runtime.orchestrator.get_agent_team", return_value="backend"),
|
||||
patch(
|
||||
"roboco.runtime.orchestrator.get_escalation_target", return_value="be-pm"
|
||||
),
|
||||
patch("roboco.runtime.orchestrator.PROJECT_HOST_PATH", None),
|
||||
patch(
|
||||
"roboco.runtime.orchestrator.tempfile.gettempdir",
|
||||
return_value=tempfile.gettempdir(),
|
||||
),
|
||||
):
|
||||
path = asyncio.run(
|
||||
orch._write_agent_briefing("be-dev-1", None, "/data/workspaces/x")
|
||||
)
|
||||
|
||||
assert path is not None
|
||||
content = Path(path).read_text()
|
||||
assert "roboco-flow" in content
|
||||
assert "roboco-do" in content
|
||||
# Developer briefing: the claim precondition is scope='note' (the GENERAL
|
||||
# entry has_note_for_task checks), never scope='decision'.
|
||||
assert "note(scope='note')" in content
|
||||
assert "note(scope='decision')" not in content
|
||||
Reference in New Issue
Block a user