External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(orchestrator): repo-aware external-PR polling (monorepo no longer triplicates)

Browse Source 
Multiple projects can map to ONE repo — a monorepo product's backend/
frontend/ux cells each have their own Project pointing at the same git_url.
The poll ingested per-project with a per-(project,pr) dedup, so one external
PR (e.g. #170 on github.com/rennf93/roboco) created one review task per cell
project — three identical reviews for the same PR.

Collapse active projects to one canonical project per distinct repo before
polling (_projects_one_per_repo, deterministic by slug so the pick is stable
across polls). A monorepo product now yields ONE review per external PR;
genuinely separate repos (multi-repo) each still get polled.
This commit is contained in:
Renn F
2026-06-17 01:39:39 +02:00
parent 79dcba1431
commit 6d02b75c15
2 changed files with 69 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/runtime/test_external_pr_classify.py
+32
View File
@@ -7,10 +7,42 @@ side) for anything it does not positively recognize as internal.
from __future__ import annotations
from types import SimpleNamespace
import pytest
from roboco.runtime.orchestrator import AgentOrchestrator
def _proj(slug: str, git_url: str | None) -> SimpleNamespace:
return SimpleNamespace(slug=slug, git_url=git_url)
def test_projects_one_per_repo_collapses_monorepo() -> None:
# Three cell-projects all pointing at the same repo (a monorepo product)
# collapse to ONE canonical project; a genuinely separate repo is kept.
projects = [
_proj("roboco-uix", "https://github.com/rennf93/roboco.git"),
_proj("roboco-api", "https://github.com/rennf93/roboco.git"),
_proj("roboco-panel", "https://github.com/rennf93/roboco.git"),
_proj("other", "https://github.com/rennf93/other-repo.git"),
]
out = AgentOrchestrator._projects_one_per_repo(projects)
slugs = [p.slug for p in out]
# one per distinct repo; canonical pick is deterministic (first by slug).
assert slugs == ["other", "roboco-api"]
def test_projects_one_per_repo_normalizes_and_skips_repoless() -> None:
projects = [
_proj("a", "https://github.com/rennf93/roboco"), # no .git
_proj("b", "https://github.com/rennf93/roboco.git/"), # .git + slash
_proj("coordination", None), # product/coordination project, no repo
]
out = AgentOrchestrator._projects_one_per_repo(projects)
# a & b are the same repo; coordination (no git_url) is skipped.
assert [p.slug for p in out] == ["a"]
@pytest.mark.parametrize(
("pr", "expected"),
[