[beb8cae1] Type-gate tests/ under mypy — fix all errors and flip quality gate (#156) (#157)

* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154)

* [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py

- Create tests/__init__.py as empty package marker
- Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py
- Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py
- Add return type annotations to _stub_get_optimal, _source, and factory functions
- Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin
- Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub
- Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py
- Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object
- All 487 source files pass mypy with 0 errors; 2312 unit tests pass

* [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/

Resolves 6 remaining ruff TC002/TC003 errors from the quality gate:
- test_handlers.py: Iterator → TYPE_CHECKING
- test_quality_gate.py: pathlib → TYPE_CHECKING
- test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING
- test_streaming.py: Iterator → TYPE_CHECKING
- test_notification.py: AsyncIterator → TYPE_CHECKING

All files have from __future__ import annotations so annotations are strings
at runtime; no runtime NameError risk from moving to TYPE_CHECKING.

* [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files

* [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets

---------



* [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155)

* [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/

- Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.)
- Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches
- Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py
- Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/
- No runtime logic changed — annotations and cast() only

* [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate

- Quote all cast() type arguments per ruff TC006 rule (cast("T", x))
- Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form)
- Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.)
- No runtime logic changed — annotation-only changeset

* [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only)

The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy
roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing
tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast
targets already check `roboco/ tests/` — the lint target now matches gate scope.

---------



---------

Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev>
Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>

tests/unit/services/test_git_diff_base_fallback.py

@@ -12,7 +12,7 @@ from __future__ import annotations
 
 from pathlib import Path
 from typing import Any
-from unittest.mock import AsyncMock
+from unittest.mock import AsyncMock, patch
 
 import pytest
 from roboco.services.git import GitService
@@ -69,8 +69,8 @@ async def test_default_branch_ref_prefers_origin_head() -> None:
             )()
         return type("R", (), {"returncode": 1, "stdout": ""})()
 
-    svc._run_git = fake_run  # type: ignore[method-assign]
-    ref = await svc._default_branch_ref(Path("/tmp/ws"))
+    with patch.object(svc, "_run_git", new=fake_run):
+        ref = await svc._default_branch_ref(Path("/tmp/ws"))
     assert ref == "origin/main"
 
 
@@ -84,9 +84,9 @@ async def test_default_branch_ref_fallback_when_no_head() -> None:
         # symbolic-ref fails; fetches succeed but ref never verifies.
         return type("R", (), {"returncode": 1, "stdout": ""})()
 
-    svc._run_git = fake_run  # type: ignore[method-assign]
     svc._ref_exists = AsyncMock(return_value=False)  # type: ignore[method-assign]
-    ref = await svc._default_branch_ref(Path("/tmp/ws"))
+    with patch.object(svc, "_run_git", new=fake_run):
+        ref = await svc._default_branch_ref(Path("/tmp/ws"))
     assert ref == "origin/master"
 
 
@@ -125,8 +125,8 @@ async def test_resolve_head_ref_falls_back_to_origin_in_foreign_clone() -> None:
         # local branch absent; only the remote-tracking ref resolves.
         return ref == f"origin/{_BR}"
 
-    svc._ref_exists = ref_exists  # type: ignore[method-assign]
-    head = await svc._resolve_head_ref(Path("/tmp/ws"), _BR)
+    with patch.object(svc, "_ref_exists", new=ref_exists):
+        head = await svc._resolve_head_ref(Path("/tmp/ws"), _BR)
     assert head == f"origin/{_BR}"
 
 
@@ -141,9 +141,9 @@ async def test_resolve_head_ref_fetches_branch_before_resolving() -> None:
         calls.append(args)
         return type("R", (), {"returncode": 0, "stdout": ""})()
 
-    svc._run_git = fake_run  # type: ignore[method-assign]
     svc._ref_exists = AsyncMock(return_value=True)  # type: ignore[method-assign]
-    await svc._resolve_head_ref(Path("/tmp/ws"), _BR)
+    with patch.object(svc, "_run_git", new=fake_run):
+        await svc._resolve_head_ref(Path("/tmp/ws"), _BR)
     assert ["fetch", "origin", _BR] in calls
 
 
@@ -171,9 +171,8 @@ async def test_diff_targets_origin_head_in_foreign_clone() -> None:
         captured.append(args)
         return type("R", (), {"returncode": 0, "stdout": "diff body"})()
 
-    svc._run_git = fake_run  # type: ignore[method-assign]
-
-    out = await svc.diff(branch_name=_BR)
+    with patch.object(svc, "_run_git", new=fake_run):
+        out = await svc.diff(branch_name=_BR)
     assert out == "diff body"
     assert captured == [["diff", f"origin/master...origin/{_BR}"]]
     # #168: the resolved project token is threaded into ref resolution so
@@ -206,9 +205,8 @@ async def test_list_changed_files_targets_origin_head_in_foreign_clone() -> None
         captured.append(args)
         return type("R", (), {"returncode": 0, "stdout": "README.md\nsrc/app.py\n"})()
 
-    svc._run_git = fake_run  # type: ignore[method-assign]
-
-    files = await svc.list_changed_files(branch_name=_BR)
+    with patch.object(svc, "_run_git", new=fake_run):
+        files = await svc.list_changed_files(branch_name=_BR)
     assert files == ["README.md", "src/app.py"]
     assert captured == [["diff", "--name-only", f"origin/master...origin/{_BR}"]]
     svc._resolve_diff_base.assert_awaited_once_with(
@@ -239,8 +237,8 @@ async def test_diff_honours_explicit_base_with_resolved_head() -> None:
         captured.append(args)
         return type("R", (), {"returncode": 0, "stdout": ""})()
 
-    svc._run_git = fake_run  # type: ignore[method-assign]
-    await svc.diff(branch_name=_BR, base="HEAD~1")
+    with patch.object(svc, "_run_git", new=fake_run):
+        await svc.diff(branch_name=_BR, base="HEAD~1")
     assert captured == [["diff", f"HEAD~1...{_BR}"]]
     svc._resolve_diff_base.assert_not_awaited()
 
@@ -267,14 +265,14 @@ async def test_resolve_diff_base_refetches_default_branch_with_token() -> None:
         calls.append((args, kw.get("token")))
         return type("R", (), {"returncode": 0, "stdout": ""})()
 
-    svc._run_git = fake_run  # type: ignore[method-assign]
     # parent ref never exists → fall back to default branch.
     svc._ref_exists = AsyncMock(return_value=False)  # type: ignore[method-assign]
     svc._default_branch_ref = AsyncMock(  # type: ignore[method-assign]
         return_value="origin/master"
     )
 
-    base = await svc._resolve_diff_base(Path("/tmp/ws"), _BR, token="tok")
+    with patch.object(svc, "_run_git", new=fake_run):
+        base = await svc._resolve_diff_base(Path("/tmp/ws"), _BR, token="tok")
     assert base == "origin/master"
     # The resolved default branch ('master') was fetched, authenticated.
     assert (["fetch", "origin", "master"], "tok") in calls
@@ -293,9 +291,9 @@ async def test_resolve_head_ref_fetch_is_authenticated() -> None:
         seen.append((args, kw.get("token")))
         return type("R", (), {"returncode": 0, "stdout": ""})()
 
-    svc._run_git = fake_run  # type: ignore[method-assign]
     svc._ref_exists = AsyncMock(return_value=True)  # type: ignore[method-assign]
-    await svc._resolve_head_ref(Path("/tmp/ws"), _BR, token="tok")
+    with patch.object(svc, "_run_git", new=fake_run):
+        await svc._resolve_head_ref(Path("/tmp/ws"), _BR, token="tok")
     assert (["fetch", "origin", _BR], "tok") in seen