[beb8cae1] Type-gate tests/ under mypy — fix all errors and flip quality gate (#156) (#157)

* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154)

* [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py

- Create tests/__init__.py as empty package marker
- Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py
- Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py
- Add return type annotations to _stub_get_optimal, _source, and factory functions
- Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin
- Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub
- Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py
- Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object
- All 487 source files pass mypy with 0 errors; 2312 unit tests pass

* [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/

Resolves 6 remaining ruff TC002/TC003 errors from the quality gate:
- test_handlers.py: Iterator → TYPE_CHECKING
- test_quality_gate.py: pathlib → TYPE_CHECKING
- test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING
- test_streaming.py: Iterator → TYPE_CHECKING
- test_notification.py: AsyncIterator → TYPE_CHECKING

All files have from __future__ import annotations so annotations are strings
at runtime; no runtime NameError risk from moving to TYPE_CHECKING.

* [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files

* [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets

---------



* [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155)

* [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/

- Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.)
- Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches
- Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py
- Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/
- No runtime logic changed — annotations and cast() only

* [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate

- Quote all cast() type arguments per ruff TC006 rule (cast("T", x))
- Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form)
- Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.)
- No runtime logic changed — annotation-only changeset

* [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only)

The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy
roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing
tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast
targets already check `roboco/ tests/` — the lint target now matches gate scope.

---------



---------

Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev>
Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>

tests/unit/api/test_app.py

@@ -9,6 +9,7 @@ extraction, optimal-service).
 from __future__ import annotations
 
 from contextlib import ExitStack, asynccontextmanager
+from typing import TYPE_CHECKING
 from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
@@ -16,6 +17,9 @@ from fastapi import FastAPI
 from roboco.api.app import app as default_app
 from roboco.api.app import create_app, lifespan
 
+if TYPE_CHECKING:
+    from collections.abc import AsyncIterator
+
 
 def test_default_app_is_a_fastapi_instance() -> None:
     """Importing the module yields a configured FastAPI instance."""
@@ -74,7 +78,7 @@ def test_create_app_includes_v1_flow_routes() -> None:
 
 def test_create_app_attaches_cors_middleware() -> None:
     app = create_app()
-    middleware_classes = [m.cls.__name__ for m in app.user_middleware]
+    middleware_classes = [getattr(m.cls, "__name__", "") for m in app.user_middleware]
     assert "CORSMiddleware" in middleware_classes
 
 
@@ -84,7 +88,7 @@ def test_create_app_attaches_cors_middleware() -> None:
 
 
 @asynccontextmanager
-async def _stub_get_optimal():
+async def _stub_get_optimal() -> AsyncIterator[MagicMock]:
     """Stand-in for the optimal-service factory."""
     yield MagicMock()
 

tests/unit/api/test_middleware.py

@@ -3,6 +3,7 @@
 from __future__ import annotations
 
 from http import HTTPStatus
+from typing import Any
 
 # UUID annotates a Pydantic model field below, so it must stay a runtime import
 # (Pydantic resolves the annotation when building the model) despite `from
@@ -79,36 +80,36 @@ def _make_app() -> FastAPI:
     app = FastAPI()
 
     @app.get("/ok")
-    async def _ok():
+    async def _ok() -> Any:
         return {"status": "ok"}
 
     @app.get("/raise")
-    async def _raise():
+    async def _raise() -> Any:
         raise RuntimeError("boom")
 
     @app.get("/notfound")
-    async def _nf():
+    async def _nf() -> Any:
         raise NotFoundError("Resource", "abc")
 
     @app.get("/http-error")
-    async def _he():
+    async def _he() -> Any:
         raise HTTPException(status_code=403, detail="nope")
 
     # service-layer errors (parallel hierarchy from roboco.services.base)
     @app.get("/svc-notfound")
-    async def _svc_nf():
+    async def _svc_nf() -> Any:
         raise ServiceNotFoundError("Channel", "main-pm")
 
     @app.get("/svc-validation")
-    async def _svc_v():
+    async def _svc_v() -> Any:
         raise ServiceValidationError("invalid input", field="title")
 
     @app.get("/svc-conflict")
-    async def _svc_c():
+    async def _svc_c() -> Any:
         raise ServiceConflictError("duplicate", resource_type="task")
 
     @app.get("/svc-unauth")
-    async def _svc_u():
+    async def _svc_u() -> Any:
         raise ServiceUnauthorizedError("merge_pr", reason="not your PR")
 
     setup_middleware(app)
@@ -265,7 +266,7 @@ def test_request_validation_handler_returns_422_with_details() -> None:
     setup_middleware(app)
 
     @app.post("/validate")
-    async def _v(_data: _Body):
+    async def _v(_data: _Body) -> Any:
         return {"ok": True}
 
     client = TestClient(app, raise_server_exceptions=False)

tests/unit/api/test_middleware_docs.py

@@ -208,7 +208,10 @@ def test_check_permission_match_with_string_permission() -> None:
 def test_path_allowed_for_agent_read_all_role() -> None:
     """Line 297-298: READ_ALL_ROLES gets read access automatically."""
     role = next(iter(READ_ALL_ROLES))
-    rule = {"read": [], "write": []}  # empty perms — but read-all role bypasses
+    rule: dict[str, list[str]] = {
+        "read": [],
+        "write": [],
+    }  # empty perms — but read-all role bypasses
     assert _path_allowed_for_agent(rule, "x", role, None, "read") is True
 
 

tests/unit/api/test_schemas_messages.py

@@ -4,14 +4,20 @@ from __future__ import annotations
 
 from datetime import UTC, datetime
 from types import SimpleNamespace
+from typing import TYPE_CHECKING, Any, cast
 from uuid import uuid4
 
 from roboco.api.schemas.messages import message_to_response
 
+if TYPE_CHECKING:
+    from roboco.db.tables import MessageTable
 
-def _stub_message(*, edit_history: list | None = None, edited_at=None):
+
+def _stub_message(
+    *, edit_history: list[Any] | None = None, edited_at: datetime | None = None
+) -> MessageTable:
     """Build a MessageTable-shaped object."""
-    return SimpleNamespace(
+    obj = SimpleNamespace(
         id=uuid4(),
         agent_id=uuid4(),
         channel_id=uuid4(),
@@ -29,6 +35,7 @@ def _stub_message(*, edit_history: list | None = None, edited_at=None):
         edited_at=edited_at,
         edit_history=edit_history,
     )
+    return cast("MessageTable", obj)
 
 
 def test_message_to_response_was_edited_true_when_history_present() -> None:

tests/unit/api/test_schemas_provider.py

@@ -3,20 +3,27 @@
 from __future__ import annotations
 
 from types import SimpleNamespace
+from typing import TYPE_CHECKING, cast
 from uuid import uuid4
 
 from roboco.api.schemas.provider import assignment_to_response
 from roboco.models.base import AssignmentScope, ModelProvider
 
+if TYPE_CHECKING:
+    from roboco.db.tables import ModelAssignmentTable
+
 
 def test_assignment_to_response_round_trip() -> None:
     provider = SimpleNamespace(type=ModelProvider.ANTHROPIC)
-    row = SimpleNamespace(
-        id=uuid4(),
-        scope=AssignmentScope.GLOBAL,
-        scope_value=None,
-        provider=provider,
-        model_name="opus",
+    row = cast(
+        "ModelAssignmentTable",
+        SimpleNamespace(
+            id=uuid4(),
+            scope=AssignmentScope.GLOBAL,
+            scope_value=None,
+            provider=provider,
+            model_name="opus",
+        ),
     )
     response = assignment_to_response(row)
     assert response.scope == AssignmentScope.GLOBAL

tests/unit/api/test_schemas_tasks.py

@@ -341,7 +341,7 @@ def test_task_list_to_response_returns_list() -> None:
 # ---------------------------------------------------------------------------
 
 
-def _stub_response():
+def _stub_response() -> Any:
     """Build a TaskResponse-like object that supports model_dump."""
     fake_inspector = MagicMock()
     fake_inspector.unloaded = {"project"}

tests/unit/api/test_schemas_v1_flow.py

@@ -19,16 +19,18 @@ def test_delegate_request_requires_task_type() -> None:
     HTTP boundary with a clear 422.
     """
     with pytest.raises(ValidationError) as exc:
-        DelegateRequest(
-            parent_task_id=uuid4(),
-            title="t",
-            description="add the new endpoint plus tests",
-            assigned_to="be-dev-1",
-            team="backend",
-            nature="technical",
-            estimated_complexity="medium",
-            acceptance_criteria=["returns 200"],
-            # task_type intentionally omitted
+        DelegateRequest.model_validate(
+            {
+                "parent_task_id": uuid4(),
+                "title": "t",
+                "description": "add the new endpoint plus tests",
+                "assigned_to": "be-dev-1",
+                "team": "backend",
+                "nature": "technical",
+                "estimated_complexity": "medium",
+                "acceptance_criteria": ["returns 200"],
+                # task_type intentionally omitted
+            }
         )
     assert "task_type" in str(exc.value)
 

tests/unit/api/test_websocket_bridge.py

@@ -101,6 +101,7 @@ async def test_handle_notification_sent_broadcasts_when_connected() -> None:
         mgr.notification_connections = {rid: {"socket-1"}}  # Has a connection.
         await _handle_notification_sent(event)
     bcast.assert_awaited_once()
+    assert bcast.await_args is not None
     call_kwargs = bcast.await_args.kwargs
     assert call_kwargs["notification_id"] == nid
     assert call_kwargs["agent_ids"] == [rid]
@@ -125,6 +126,7 @@ async def test_handle_notification_acked_broadcasts_using_agent_id() -> None:
         mgr.notification_connections = {aid: {"socket-1"}}
         await _handle_notification_sent(event)
     bcast.assert_awaited_once()
+    assert bcast.await_args is not None
     call_kwargs = bcast.await_args.kwargs
     assert call_kwargs["notification_id"] == nid
     assert call_kwargs["agent_ids"] == [aid]