External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

[beb8cae1] Type-gate tests/ under mypy — fix all errors and flip quality gate (#156) (#157)

Browse Source 
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154)

* [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py

- Create tests/__init__.py as empty package marker
- Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py
- Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py
- Add return type annotations to _stub_get_optimal, _source, and factory functions
- Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin
- Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub
- Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py
- Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object
- All 487 source files pass mypy with 0 errors; 2312 unit tests pass

* [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/

Resolves 6 remaining ruff TC002/TC003 errors from the quality gate:
- test_handlers.py: Iterator → TYPE_CHECKING
- test_quality_gate.py: pathlib → TYPE_CHECKING
- test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING
- test_streaming.py: Iterator → TYPE_CHECKING
- test_notification.py: AsyncIterator → TYPE_CHECKING

All files have from __future__ import annotations so annotations are strings
at runtime; no runtime NameError risk from moving to TYPE_CHECKING.

* [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files

* [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets

---------



* [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155)

* [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/

- Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.)
- Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches
- Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py
- Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/
- No runtime logic changed — annotations and cast() only

* [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate

- Quote all cast() type arguments per ruff TC006 rule (cast("T", x))
- Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form)
- Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.)
- No runtime logic changed — annotation-only changeset

* [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only)

The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy
roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing
tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast
targets already check `roboco/ tests/` — the lint target now matches gate scope.

---------



---------

Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev>
Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
This commit is contained in:
Renzo F
2026-06-14 13:43:46 +02:00
committed by GitHub
co-authored by Backend Developer 1 Backend Developer 2
parent 08abefddb3
commit 6cf99a1b0a
101 changed files with 821 additions and 631 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/test_journal_routes.py
+28 -20
View File
@@ -8,7 +8,7 @@ mapping) is exercised end-to-end.
from __future__ import annotations
from http import HTTPStatus
from typing import TYPE_CHECKING
from typing import TYPE_CHECKING, cast
from unittest.mock import patch
from uuid import UUID, uuid4
@@ -30,7 +30,7 @@ from roboco.models.base import JournalEntryType, TaskNature, TaskStatus, TaskTyp
from roboco.models.permissions import AgentContext
if TYPE_CHECKING:
from collections.abc import AsyncIterator
from collections.abc import AsyncGenerator, AsyncIterator
from sqlalchemy.ext.asyncio import AsyncSession
@@ -58,12 +58,12 @@ async def journal_client(
app = FastAPI()
app.include_router(journals_router, prefix="/api/journals")
async def _override_db():
async def _override_db() -> AsyncGenerator[AsyncSession]:
yield db_session
async def _override_agent() -> AgentContext:
return AgentContext(
agent_id=agent.id,
agent_id=cast("UUID", agent.id),
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
slug=agent.slug,
@@ -264,12 +264,12 @@ async def journal_setup_with_task(
app = FastAPI()
app.include_router(journals_router, prefix="/api/journals")
async def _override_db():
async def _override_db() -> AsyncGenerator[AsyncSession]:
yield db_session
async def _override_agent() -> AgentContext:
return AgentContext(
agent_id=agent.id,
agent_id=cast("UUID", agent.id),
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
slug=agent.slug,
@@ -280,12 +280,14 @@ async def journal_setup_with_task(
transport = ASGITransport(app=app)
async with AsyncClient(transport=transport, base_url="http://test") as client:
yield client, agent, task.id
yield client, agent, cast("UUID", task.id)
app.dependency_overrides.clear()
@pytest.mark.asyncio
async def test_add_task_reflection(journal_setup_with_task) -> None:
async def test_add_task_reflection(
journal_setup_with_task: tuple[AsyncClient, AgentTable, UUID],
) -> None:
client, _, task_id = journal_setup_with_task
response = await client.post(
"/api/journals/me/reflections",
@@ -303,7 +305,9 @@ async def test_add_task_reflection(journal_setup_with_task) -> None:
@pytest.mark.asyncio
async def test_add_decision_log(journal_setup_with_task) -> None:
async def test_add_decision_log(
journal_setup_with_task: tuple[AsyncClient, AgentTable, UUID],
) -> None:
client, _, task_id = journal_setup_with_task
response = await client.post(
"/api/journals/me/decisions",
@@ -325,7 +329,9 @@ async def test_add_decision_log(journal_setup_with_task) -> None:
@pytest.mark.asyncio
async def test_add_learning(journal_setup_with_task) -> None:
async def test_add_learning(
journal_setup_with_task: tuple[AsyncClient, AgentTable, UUID],
) -> None:
client, _, task_id = journal_setup_with_task
response = await client.post(
"/api/journals/me/learnings",
@@ -340,7 +346,9 @@ async def test_add_learning(journal_setup_with_task) -> None:
@pytest.mark.asyncio
async def test_add_struggle(journal_setup_with_task) -> None:
async def test_add_struggle(
journal_setup_with_task: tuple[AsyncClient, AgentTable, UUID],
) -> None:
client, _, task_id = journal_setup_with_task
response = await client.post(
"/api/journals/me/struggles",
@@ -418,7 +426,7 @@ async def test_list_agent_entries_for_self(
@pytest.mark.asyncio
async def test_search_my_entries_returns_list(
journal_setup_with_task,
journal_setup_with_task: tuple[AsyncClient, AgentTable, UUID],
) -> None:
"""Search route — may 200 with empty list or 500 if RAG isn't configured."""
client, _, _ = journal_setup_with_task
@@ -438,7 +446,7 @@ async def test_search_my_entries_returns_list(
@pytest.mark.asyncio
async def test_add_general_entry(
journal_setup_with_task,
journal_setup_with_task: tuple[AsyncClient, AgentTable, UUID],
) -> None:
client, _, task_id = journal_setup_with_task
response = await client.post(
@@ -678,12 +686,12 @@ async def test_get_entry_full_success_with_slug(db_session: AsyncSession) -> Non
app = FastAPI()
app.include_router(journals_router, prefix="/api/journals")
async def _override_db():
async def _override_db() -> AsyncGenerator[AsyncSession]:
yield db_session
async def _override_agent() -> AgentContext:
return AgentContext(
agent_id=agent.id,
agent_id=cast("UUID", agent.id),
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
slug=agent.slug,
@@ -754,12 +762,12 @@ async def test_delete_entry_other_agent_forbidden(
app = FastAPI()
app.include_router(journals_router, prefix="/api/journals")
async def _override_db():
async def _override_db() -> AsyncGenerator[AsyncSession]:
yield db_session
async def _override_agent_owner() -> AgentContext:
return AgentContext(
agent_id=owner.id,
agent_id=cast("UUID", owner.id),
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
slug=owner.slug,
@@ -785,7 +793,7 @@ async def test_delete_entry_other_agent_forbidden(
# Switch to the intruder.
async def _override_agent_intruder() -> AgentContext:
return AgentContext(
agent_id=intruder.id,
agent_id=cast("UUID", intruder.id),
role=AgentRole.DEVELOPER,
team=Team.BACKEND,
slug=intruder.slug,
@@ -907,12 +915,12 @@ async def _make_cross_agent_app(
app = FastAPI()
app.include_router(journals_router, prefix="/api/journals")
async def _override_db():
async def _override_db() -> AsyncGenerator[AsyncSession]:
yield db_session
async def _override_agent() -> AgentContext:
return AgentContext(
agent_id=reader.id,
agent_id=cast("UUID", reader.id),
role=reader.role,
team=reader.team,
slug=reader.slug,