test: lift coverage 41% → 76% (+1068 tests across 36 files)

Service-level tests now exercise provider, permissions, project, journal,
messaging, work_session, metrics, kanban, extraction, learning, notification,
dashboard, llm_routing, a2a, task, repository_base, audit, db_seed,
branch_name, indexed_document, query_helpers, agent. API route tests cover
provider, journal, project, sessions, dashboard, work_session, tasks, a2a,
groups, notifications, agents, channels, messages, kanban, api_resources.
Pure-function helpers covered: handlers, deps_helpers, middleware,
middleware_docs, transcription, pr templates, agents_config, errors,
logging, journal/notification/channel/a2a access, task_lifecycle,
streaming, converters, crypto, schemas (common + websocket), events,
permissions extras.

pyproject ruff per-file-ignores extended for tests so PLR2004 (status code
magic values), PLC0415 (lazy imports), PLR0913 (fixture params), ARG001
(unused fixture deps), SIM105, and E501 don't fight test idioms.
This commit is contained in:
Renn F
2026-05-06 00:32:52 +02:00
parent b6903490f1
commit 64c48356d0
46 changed files with 2994 additions and 206 deletions
@@ -0,0 +1,67 @@
"""enforcement.notification_perms coverage."""
from __future__ import annotations
import pytest
from roboco.enforcement.notification_perms import (
NotificationPermissionError,
get_notification_scope,
validate_notification_permission,
)
def test_developer_cannot_send_notifications() -> None:
with pytest.raises(NotificationPermissionError, match="cannot send"):
validate_notification_permission("be-dev-1", ["be-pm"])
def test_main_pm_can_send_to_anyone() -> None:
assert validate_notification_permission("main-pm", ["be-dev-1"]) is True
def test_cell_pm_can_notify_cell_member() -> None:
assert validate_notification_permission("be-pm", ["be-dev-1"]) is True
def test_cell_pm_can_notify_other_cell_pm() -> None:
assert validate_notification_permission("be-pm", ["fe-pm"]) is True
def test_cell_pm_can_notify_main_pm() -> None:
assert validate_notification_permission("be-pm", ["main-pm"]) is True
def test_cell_pm_cannot_notify_other_cell_dev() -> None:
with pytest.raises(NotificationPermissionError):
validate_notification_permission("be-pm", ["fe-dev-1"])
def test_get_notification_scope_for_main_pm() -> None:
scope = get_notification_scope("main-pm")
assert scope.get("can_send") is True
def test_get_notification_scope_for_developer() -> None:
scope = get_notification_scope("be-dev-1")
assert scope.get("can_send") is False
def test_get_notification_scope_for_unknown() -> None:
scope = get_notification_scope("ghost-agent")
assert scope.get("can_send") is False
def test_validate_with_multiple_recipients() -> None:
"""Validate succeeds when all recipients are reachable."""
assert validate_notification_permission("main-pm", ["be-dev-1", "fe-dev-1"]) is True
def test_validate_fails_on_first_unreachable() -> None:
"""Validation halts at the first unreachable recipient."""
with pytest.raises(NotificationPermissionError):
validate_notification_permission("be-pm", ["be-dev-1", "fe-dev-1"])
def test_unknown_agent_cannot_send() -> None:
with pytest.raises(NotificationPermissionError):
validate_notification_permission("ghost-agent", ["be-pm"])