External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore(agnosticism): close the audit residue — B6/B8/B10 + three MAJORs (#587)

Browse Source 
Thread the deployer's product name through the X reply + feature-spotlight
prompts (B6 leftover; release/video paths shipped in #570); make the
docs-site repo/URL config (ROBOCO_DOCS_SITE_*, defaults unchanged) instead
of a roboco-website hardcode (B8); de-assert our repo from the Main PM
prompt (B10); derive PR labels from the real target branch instead of
literal to-master/to-slave; drop the stale headcount from base.md; and
make the bash-guard's Makefile check require an actual quality/gate/lint/
test target before denying raw package-manager commands (no more
false-remediation loop on Go/Rust Makefiles).

Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
Renzo F
2026-07-19 17:52:17 +02:00
committed by GitHub
co-authored by Renn F
parent 29f7082030
commit 5b27a443e9
15 changed files with 234 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/runtime/test_bash_guard_makefile_guardrail.py
+25 -5
View File
@@ -2,11 +2,13 @@
CEO item: force agents to the Makefile. The existing hook deliberately allowed
bare ``uv run`` (workspace .venv, cwd-relative); this guard overrides that by
CEO direction when a ``Makefile`` is present, denying raw package-manager /
test-runner commands and remediating to the make targets. Skipped when no
Makefile exists so Makefile-less projects aren't blocked. On the grok path
(``ROBOCO_GUARD_SKIP_PM=1``) a deny cancels the whole run, so it nudges (exit 0)
instead.
CEO direction when a ``Makefile`` is present AND declares at least one of the
quality/gate/lint/test targets, denying raw package-manager / test-runner
commands and remediating to the make targets. Skipped when no Makefile exists,
or when one exists but declares none of those targets (a Go/Rust Makefile with
only build/run — existence alone would remediate into a dead end). On the grok
path (``ROBOCO_GUARD_SKIP_PM=1``) a deny cancels the whole run, so it nudges
(exit 0) instead.
"""
from __future__ import annotations
@@ -79,6 +81,24 @@ def test_skips_deny_without_makefile(tmp_path: Path) -> None:
assert rc != _DENIED
def test_skips_deny_when_makefile_lacks_remediation_targets(tmp_path: Path) -> None:
"""A Go/Rust-style Makefile with only build/run targets — existence alone
must not deny+remediate to a `make quality`/`gate`/`lint`/`test` that
doesn't exist (the false-remediation dead-end loop the content check
closes)."""
(tmp_path / "Makefile").write_text("build:\n\tgo build ./...\nrun:\n\tgo run .\n")
rc, _ = _run_hook("uv run pytest", tmp_path)
assert rc != _DENIED
def test_denies_when_makefile_has_only_one_remediation_target(tmp_path: Path) -> None:
"""Just one of quality/gate/lint/test is enough to arm the deny — the
guard doesn't require all four."""
(tmp_path / "Makefile").write_text("lint:\n\truff check .\n")
rc, _ = _run_hook("uv run pytest", tmp_path)
assert rc == _DENIED
def test_grok_path_nudges_not_denies() -> None:
"""ROBOCO_GUARD_SKIP_PM=1 (grok) -> exit 0 nudge, not run-canceling exit 2."""
rc, err = _run_hook("uv run pytest", REPO_ROOT, {"ROBOCO_GUARD_SKIP_PM": "1"})