chore(agnosticism): close the audit residue — B6/B8/B10 + three MAJORs (#587)

Thread the deployer's product name through the X reply + feature-spotlight
prompts (B6 leftover; release/video paths shipped in #570); make the
docs-site repo/URL config (ROBOCO_DOCS_SITE_*, defaults unchanged) instead
of a roboco-website hardcode (B8); de-assert our repo from the Main PM
prompt (B10); derive PR labels from the real target branch instead of
literal to-master/to-slave; drop the stale headcount from base.md; and
make the bash-guard's Makefile check require an actual quality/gate/lint/
test target before denying raw package-manager commands (no more
false-remediation loop on Go/Rust Makefiles).

Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
Renzo F
2026-07-19 17:52:17 +02:00
committed by GitHub
co-authored by Renn F
parent 29f7082030
commit 5b27a443e9
15 changed files with 234 additions and 76 deletions
+36
View File
@@ -14,6 +14,7 @@ from roboco.foundation.policy.pr_labels import (
def test_root_master_megatask_main_pm() -> None:
# submit_root on a MegaTask root-subtask: root->master, main_pm, batch member.
labels = derive_pr_labels(
base_branch="master",
is_root_pr=True,
task_team=Team.MAIN_PM,
batch_id=uuid4(),
@@ -24,6 +25,7 @@ def test_root_master_megatask_main_pm() -> None:
def test_root_master_main_pm_no_batch() -> None:
labels = derive_pr_labels(
base_branch="master",
is_root_pr=True,
task_team=Team.MAIN_PM,
batch_id=None,
@@ -35,6 +37,7 @@ def test_root_master_main_pm_no_batch() -> None:
def test_cell_to_root_assembled() -> None:
# submit_up: cell->root PR, base is the integration branch (not default).
labels = derive_pr_labels(
base_branch="slave",
is_root_pr=False,
task_team=Team.BACKEND,
batch_id=None,
@@ -45,6 +48,7 @@ def test_cell_to_root_assembled() -> None:
def test_leaf_dev_pr() -> None:
labels = derive_pr_labels(
base_branch="slave",
is_root_pr=False,
task_team=Team.FRONTEND,
batch_id=None,
@@ -56,6 +60,7 @@ def test_leaf_dev_pr() -> None:
def test_freeform_pr_no_task() -> None:
# task_id None: no team, no batch — just the tree + root flags.
labels = derive_pr_labels(
base_branch="slave",
is_root_pr=False,
task_team=None,
batch_id=None,
@@ -66,6 +71,7 @@ def test_freeform_pr_no_task() -> None:
def test_freeform_root_pr_no_task() -> None:
labels = derive_pr_labels(
base_branch="master",
is_root_pr=True,
task_team=None,
batch_id=None,
@@ -77,6 +83,7 @@ def test_freeform_root_pr_no_task() -> None:
def test_accepts_string_team_value() -> None:
# callers pass ORM enum members OR their .value strings (mirrors batch.py).
labels = derive_pr_labels(
base_branch="slave",
is_root_pr=False,
task_team="main_pm",
batch_id=None,
@@ -92,9 +99,38 @@ def test_conventions_pr_labels_static() -> None:
def test_no_duplicates() -> None:
# a shape that could repeat a label still yields a unique list.
labels = derive_pr_labels(
base_branch="master",
is_root_pr=True,
task_team=Team.MAIN_PM,
batch_id=uuid4(),
has_children=True,
)
assert len(labels) == len(set(labels))
def test_label_reflects_real_base_branch_not_is_root_pr() -> None:
"""The ``to {base}`` label is driven entirely by the PR's actual target,
not derived from ``is_root_pr`` — a non-root PR whose real base happens to
be "master" (or any project-specific env-ladder rung) must say so, not
hardcode "to slave" just because it isn't a root PR."""
labels = derive_pr_labels(
base_branch="main",
is_root_pr=False,
task_team=Team.BACKEND,
batch_id=None,
has_children=False,
)
assert labels[0] == "to main"
def test_label_reflects_project_specific_env_ladder_rung() -> None:
# A root PR targeting a project's own env-ladder head rung, not literal
# "master" — the deployer's real prod-branch name flows through verbatim.
labels = derive_pr_labels(
base_branch="production",
is_root_pr=True,
task_team=Team.MAIN_PM,
batch_id=None,
has_children=True,
)
assert labels == ["to production", "root", "main-pm"]