[fix] resolve 16 mypy errors across 9 test files (make quality gate)

type-clean the test files so make quality (mypy roboco/ tests/) is green:
- Any-typed locals for the two TypeError-asserting scoping tests (bypass
  the required-arg check without getattr/ruff B009)
- Any-typed view for the shutdown-drain _drain_bg_tasks override (bypass
  mypy method-assign without setattr/ruff B010)
- cast("uuid.UUID", ...) / cast("UUID", ...) for SQLAlchemy UUID[Any]
  returns (TC006-quoted), config=None for AgentInstance stubs, None-narrowed
  await_args, Iterator return on a yielding fixture, UUID annotation on the
  _task helper. No type:ignore / noqa.
This commit is contained in:
Renn F
2026-06-29 02:33:09 +02:00
parent 041d0694d3
commit 592c84da5d
9 changed files with 44 additions and 20 deletions
@@ -71,7 +71,7 @@ async def _seed_project(db: AsyncSession, slug: str) -> ProjectTable:
return project
def _task(project_id, *, branch: str, status: TaskStatus) -> TaskTable:
def _task(project_id: UUID, *, branch: str, status: TaskStatus) -> TaskTable:
return TaskTable(
id=uuid4(),
title=f"task {branch}",
@@ -102,8 +102,10 @@ async def test_branch_owned_only_by_its_own_project(db_session: AsyncSession) ->
proj_b = await _seed_project(db_session, "gca-collide-b")
db_session.add_all(
[
_task(proj_a.id, branch=_BRANCH, status=TaskStatus.IN_PROGRESS),
_task(proj_b.id, branch=_BRANCH, status=TaskStatus.COMPLETED),
_task(
cast("UUID", proj_a.id), branch=_BRANCH, status=TaskStatus.IN_PROGRESS
),
_task(cast("UUID", proj_b.id), branch=_BRANCH, status=TaskStatus.COMPLETED),
]
)
await db_session.flush()
+11 -5
View File
@@ -1170,14 +1170,20 @@ async def _seed_messages_same_timestamp(
timestamp so the equal-timestamp pagination skip is reproducible. Returns
``(session_id, message_ids)``."""
ch = await svc.create_channel(_channel_req(uuid4().hex[:6]))
grp = await svc.create_group(GroupCreateRequest(name="g1", channel_id=ch.id))
sess = await svc.create_session(SessionCreateRequest(group_id=grp.id))
grp = await svc.create_group(
GroupCreateRequest(name="g1", channel_id=cast("uuid.UUID", ch.id))
)
sess = await svc.create_session(
SessionCreateRequest(group_id=cast("uuid.UUID", grp.id))
)
ids: list[UUID] = []
for i in range(count):
m = await svc.send_message(
MessageCreateRequest(agent_id=aid, session_id=sess.id, content=f"m-{i}")
MessageCreateRequest(
agent_id=aid, session_id=cast("uuid.UUID", sess.id), content=f"m-{i}"
)
)
ids.append(m.id)
ids.append(cast("uuid.UUID", m.id))
fixed = datetime.now(UTC)
rows = (
(
@@ -1191,7 +1197,7 @@ async def _seed_messages_same_timestamp(
for row in rows:
row.timestamp = fixed
await session.flush()
return sess.id, ids
return cast("uuid.UUID", sess.id), ids
@pytest.mark.asyncio
@@ -8,7 +8,7 @@ SQLAlchemy ``after_commit`` events and a recording bus stand-in.
from __future__ import annotations
import asyncio
from typing import TYPE_CHECKING
from typing import TYPE_CHECKING, cast
from uuid import UUID, uuid4
import pytest
@@ -99,7 +99,7 @@ async def _seed_agents_and_notification(
metrics={},
)
db.add(r)
recipient_ids.append(r.id)
recipient_ids.append(cast("UUID", r.id))
await db.flush()
notification = NotificationTable(
@@ -113,7 +113,7 @@ async def _seed_agents_and_notification(
)
db.add(notification)
await db.flush()
return notification.id, notification
return cast("UUID", notification.id), notification
@pytest.mark.asyncio