External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat(roles): add the read-only pr_reviewer role end-to-end

Browse Source 
A global, read-only PR reviewer agent (pr-reviewer-1) that reviews inbound
external/fork PRs and posts one change-request. Wired end-to-end:

- identity: Role.PR_REVIEWER + agent + ROLE_LEVEL (QA-peer) + REVIEWER_ROLES
- lifecycle: CLAIM_RULES + ROLE_TEAM_RULES + a dedicated claim_pr_review /
  post_pr_review verb pair (distinct from QA's) + the pr_review_done action and
  its in_progress->completed transition; give_me_work / i_am_idle gain the role
- role_config: a read-only RoleConfig (allows_write=False)
- journaling: ALL_CELLS read tier so it can read internal intent like QA
- tracing: post_pr_review requires a learning entry; claim_pr_review is waived
- seeds presentation + factory prompt layer + builtin tools + the agentrole
  enum migration (037) + regenerated verb/lifecycle artifacts

Read-only at /app like QA/auditor; default-off — nothing dispatches review work
until external_pr_enabled. Foundation + role-config + enum suites green; ruff +
mypy clean; orchestrator boots.
This commit is contained in:
Renn F
2026-06-16 10:37:06 +02:00
parent beb2287316
commit 5902c0fe38
18 changed files with 294 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/rag/lifecycle/intent-verbs.md
+20 -2
View File
@@ -9,6 +9,15 @@ Claim awaiting_documentation. Returns evidence inline.
**Composes:** (no atomic actions)
## claim_pr_review
Claim an inbound external-PR review task and start work. pending -> claimed -> in_progress.
**Allowed roles:** pr_reviewer
**Composes:** claim → start
## claim_review
Claim a task in awaiting_qa for review. Returns evidence inline.
@@ -69,7 +78,7 @@ Fail QA with concrete issues. Transitions to needs_revision.
Return your most-actionable task or signal idle.
**Allowed roles:** cell_pm, developer, documenter, main_pm, qa
**Allowed roles:** cell_pm, developer, documenter, main_pm, pr_reviewer, qa
**Composes:** (no atomic actions)
@@ -98,7 +107,7 @@ Submit work for QA. Auto-runs in_progress->verifying then verifying->awaiting_qa
Signal you have no active work. PMs auto-pause owned in_progress tasks.
**Allowed roles:** auditor, cell_pm, developer, documenter, head_marketing, main_pm, product_owner, prompter, qa, secretary
**Allowed roles:** auditor, cell_pm, developer, documenter, head_marketing, main_pm, pr_reviewer, product_owner, prompter, qa, secretary
**Composes:** (no atomic actions)
@@ -156,6 +165,15 @@ Pass QA. Transitions awaiting_qa -> awaiting_documentation.
**Composes:** qa_pass
## post_pr_review
Post one complete change-request to the external PR and finish the review task. in_progress -> completed.
**Allowed roles:** pr_reviewer
**Composes:** pr_review_done
## reassign
Hand a claimed/in_progress task to another developer in your own cell. The branch is keyed to the task (not the agent), so it is preserved — the new developer continues the work-in-progress. No status change.