mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
fix: journals/learnings never reached the RAG corpus + git-readonly slug 404s (#339)
* fix(rag): per-index chunk floors — journals and learnings were never indexed The global 200-char garbage floor (sized for code/doc chunks) discarded every templated journal note and most distilled org-memory lessons, silently: ingest returned success with zero chunks, so agent journals and learnings were never retrievable via RAG. IndexConfig now carries a per-type min_chunk_length (journals 40, learnings 80, others unchanged). * fix(mcp): git-readonly tools default project_slug from the container env Agents 404ed /api/git/status with 'Project not found: roboco' — the tools made the LLM supply the slug and six doc examples taught a slug that matches no registered project. The tools now fall back to the ROBOCO_PROJECT_SLUG the orchestrator already injects, and the stale examples are corrected. * feat(rag): startup backfill re-ingests zero-chunk journals and learnings Before the per-index chunk-floor fix, ingest() returned success with chunk_count=0 for undersized content: every historical journal entry and distilled learning below the (then-global) 200-char floor was durably recorded in journal_entries but silently never got a chunks_journals / chunks_learnings row, and no exception meant the existing dead-letter (rag_index_failures) never saw it either. Extends the startup reconcile (roboco/api/app.py _reconcile_rag_indexes) with a new pass: backfill_unindexed_journals (roboco/services/ rag_index_failures.py) queries journal_entries for rows missing from each vector table and re-ingests them through the same live code paths (_reindex_journal_entry / record_learning). Journals and learnings are backfilled independently since a LEARNING entry can clear the (lower) JOURNALS floor while still failing the (higher) LEARNINGS floor — a learning's doc_source is a content hash, not the entry id, so presence there is checked by hashing each candidate the same way LearningsIndexPlugin.record_learning does and batch-querying chunks_learnings for those exact sources. Bounded to 200 rows per pass per boot (converges over restarts on a larger backlog) and best-effort per row (one failure never aborts the pass). Rows still under the current floor are excluded by a length filter in the SELECT so they are never retried forever, and private entries are excluded from the JOURNALS pass exactly like the live indexing path. * test(rag): scope backfill assertions to their own rows --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
@@ -12,10 +12,13 @@ There is **no** "roboco_git_commit / _push / _create_pr / _merge_pr / _checkout"
|
||||
| `roboco_git_diff` | View changes |
|
||||
|
||||
```python
|
||||
status = roboco_git_status(project_slug="roboco")
|
||||
diff = roboco_git_diff(project_slug="roboco")
|
||||
log = roboco_git_log(project_slug="roboco", branch="feature/backend/a1b2c3d4")
|
||||
branches = roboco_git_branch_list(project_slug="roboco")
|
||||
# project_slug is optional — omit it and your own project is used
|
||||
# (from this agent's environment). Pass it explicitly only to inspect
|
||||
# a different project than the one you're assigned to.
|
||||
status = roboco_git_status()
|
||||
diff = roboco_git_diff()
|
||||
log = roboco_git_log(branch="feature/backend/a1b2c3d4")
|
||||
branches = roboco_git_branch_list()
|
||||
```
|
||||
|
||||
## Branch Lifecycle — automatic
|
||||
|
||||
@@ -15,7 +15,7 @@
|
||||
roboco_kb_search(
|
||||
query="rate limiting redis",
|
||||
top_k=5,
|
||||
project="roboco",
|
||||
project="roboco-api",
|
||||
index_types=["code", "docs"]
|
||||
)
|
||||
```
|
||||
@@ -71,14 +71,14 @@ roboco_docs_read(path="backend/api/endpoints.md")
|
||||
# Index code (PM, Developer)
|
||||
roboco_kb_index_code(
|
||||
sources=["src/**/*.py"],
|
||||
project="roboco"
|
||||
project="roboco-api"
|
||||
)
|
||||
|
||||
# Index docs (PM, Documenter) - for bulk/explicit indexing
|
||||
# Note: roboco_docs_write() auto-indexes when writing
|
||||
roboco_kb_index_docs(
|
||||
sources=["docs/**/*.md"],
|
||||
project="roboco"
|
||||
project="roboco-api"
|
||||
)
|
||||
```
|
||||
|
||||
|
||||
@@ -16,10 +16,12 @@ A task carries its project linkage; you don't look it up with a tool. The task o
|
||||
Read-only git inspection is available through the `roboco-git-readonly` MCP server (developers and QA):
|
||||
|
||||
```python
|
||||
roboco_git_status(project_slug="roboco")
|
||||
roboco_git_log(project_slug="roboco")
|
||||
roboco_git_diff(project_slug="roboco")
|
||||
roboco_git_branch_list(project_slug="roboco")
|
||||
# project_slug is optional on all four — omit it and your own project
|
||||
# is used (from this agent's environment).
|
||||
roboco_git_status()
|
||||
roboco_git_log()
|
||||
roboco_git_diff()
|
||||
roboco_git_branch_list()
|
||||
```
|
||||
|
||||
There is **no** `roboco_git_commit / _push / _checkout / _create_pr / _merge_pr` tool. Commits go through the `commit` content tool (auto- prefixed with `[task-id]`, auto-pushed by the choreographer); PRs open at `open_pr` time; merges are a PM `complete` operation.
|
||||
@@ -29,7 +31,7 @@ There is **no** `roboco_git_commit / _push / _checkout / _create_pr / _merge_pr`
|
||||
To learn how a project's codebase is laid out or how a subsystem works, query the knowledge base rather than a project tool:
|
||||
|
||||
```python
|
||||
roboco_kb_search(query="rate limiting redis", project="roboco",
|
||||
roboco_kb_search(query="rate limiting redis", project="roboco-api",
|
||||
index_types=["code", "documentation"])
|
||||
roboco_ask_mentor(question="How is auth wired up in this project?")
|
||||
```
|
||||
|
||||
@@ -57,8 +57,9 @@ You don't push or create a PR yourself. The choreographer pushed the commit duri
|
||||
|
||||
```python
|
||||
# Read-only inspection (any role) — roboco-git-readonly MCP
|
||||
status = roboco_git_status(project_slug="roboco")
|
||||
log = roboco_git_log(project_slug="roboco", branch="feature/backend/a1b2c3d4--def67890")
|
||||
diff = roboco_git_diff(project_slug="roboco")
|
||||
branches = roboco_git_branch_list(project_slug="roboco")
|
||||
# project_slug is optional — omit it and your own project is used.
|
||||
status = roboco_git_status()
|
||||
log = roboco_git_log(branch="feature/backend/a1b2c3d4--def67890")
|
||||
diff = roboco_git_diff()
|
||||
branches = roboco_git_branch_list()
|
||||
```
|
||||
|
||||
@@ -26,7 +26,7 @@ It searches ALL knowledge sources and supports follow-up questions.
|
||||
roboco_kb_search(
|
||||
query="rate limiting redis implementation",
|
||||
top_k=5, # Results to return
|
||||
project="roboco", # Optional project filter
|
||||
project="roboco-api", # Optional project filter
|
||||
index_types=["code", "docs"] # Filter by type
|
||||
)
|
||||
```
|
||||
|
||||
@@ -17,9 +17,10 @@ give_me_work()
|
||||
# guard at pass/fail time)
|
||||
claim_review(task_id="<task>")
|
||||
|
||||
# 3. Inspect the diff
|
||||
roboco_git_diff(project_slug="roboco")
|
||||
roboco_git_log(project_slug="roboco", branch="<dev's branch>")
|
||||
# 3. Inspect the diff (project_slug is optional — omit it and your
|
||||
# own project is used)
|
||||
roboco_git_diff()
|
||||
roboco_git_log(branch="<dev's branch>")
|
||||
|
||||
# 4. Run the relevant suite
|
||||
# Backend: uv run pytest && uv run ruff check . && uv run mypy roboco/
|
||||
|
||||
Reference in New Issue
Block a user