mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[chore] clear all 64 pre-existing mypy errors in tests/ (no type:ignore)
Convention: no type:ignore/noqa, and pre-existing violations still violate. The make-quality gate runs 'mypy roboco/ tests/', but the prior commits' gates only ran mypy on production files, masking 64 type errors across 15 test files (method-assign, unused-ignore, no-untyped-def, attr-defined, union-attr, has-type, index, misc). Fixed without any type:ignore: - method-assign (svc.session.X = / svc.method = AsyncMock()): hold a local 'session: MagicMock'/'AsyncMock' and assert on it, or stub via object.__setattr__ / monkeypatch / a typed '_bind' helper returning Any, or alias 'cc: Any = c' (the pattern the file already used). - unused 'type: ignore[assignment]' (real code was method-assign): removed; replaced with the no-suppression patterns above. - 'Callable[...] has no attribute assert_*': keep a typed local ref to the AsyncMock and assert on the local, not the method-typed attr. - no-untyped-def: annotate helper params (Any / pytest.MonkeyPatch). - attr-defined / index / union-attr: type the helper as Any, narrow with an 'is not None' assert, or add the missing attr to a fake. - has-type / return-value: fix the declared return type to the tuple the function actually returns. - PLC0415 inline imports: hoisted to top-level. test_pr_gate_notifies_pm._stub_gate_path converted fully to the 'cc: Any = c' alias (it already used it for one attr) so its five '# type: ignore[method-assign]' suppressions are gone. mypy tests/: 64 errors -> 0 (538 files). ruff check tests/: clean. All 84 tests in the touched files pass.
This commit is contained in:
@@ -62,6 +62,7 @@ def orch(monkeypatch: pytest.MonkeyPatch) -> AgentOrchestrator:
|
||||
class _FakeTracker:
|
||||
def __init__(self) -> None:
|
||||
self.activated_with: dict[str, object] | None = None
|
||||
self.clear = AsyncMock()
|
||||
|
||||
async def activate(
|
||||
self, *, retry_after: float, affected_agents: list[str], kind: str
|
||||
@@ -141,9 +142,7 @@ async def test_agent_writing_about_error_500_does_not_park(
|
||||
orch, "_tail_container_logs", AsyncMock(return_value=agent_note)
|
||||
)
|
||||
monkeypatch.setattr(orch, "_transcript_tail_text", lambda _a, _lines=80: "")
|
||||
assert (
|
||||
await orch._provider_overload_park_target("be-dev-1", _instance()) is None
|
||||
)
|
||||
assert await orch._provider_overload_park_target("be-dev-1", _instance()) is None
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
@@ -245,7 +244,7 @@ async def test_probe_success_respawns_parked_agent(
|
||||
)
|
||||
}
|
||||
tracker = _FakeTracker()
|
||||
tracker.clear = AsyncMock() # type: ignore[method-assign]
|
||||
tracker.clear = AsyncMock()
|
||||
monkeypatch.setattr(orch, "_make_tracker", lambda _p: tracker)
|
||||
monkeypatch.setattr(orch, "_delete_waiting_record", AsyncMock())
|
||||
monkeypatch.setattr(orch, "_generate_resume_prompt", lambda _r, _res: "resume")
|
||||
|
||||
Reference in New Issue
Block a user