fix(gateway): unblock task claim; full Phase 0/1/2 remediation

Resolves the 100% claim-failure rate introduced by the gateway rewrite
  (commit 62bda0c plus 78 follow-ups). Live smoke runs hit
  `404 /api/v2/flow/developer/...` on every dev verb plus a manifest
  fallback that silently exposed off-role verbs to PMs — confirmed
  firing simultaneously in NAS agent logs (be-dev-1, be-pm, main-pm).

  Audit reports under docs/internal/audit_2026_05_04/ catalogue 49
  defects across gateway, services, prompts, MCP transport, substrate,
  and tests (8 detail reports + master synthesis). Six smoking guns;
  three proven in production logs.

  Phase 0 — unblock claim:
  - URL prefix /api/v2/flow/dev → /developer; slug-map board roles
    (product_owner, head_marketing) → /board (D-01)
  - _i_will_work_on AttributeError on None across pending /
    needs_revision / claimed re-entry branches (D-02)
  - Seed last_heartbeat_at in _qa_or_doc_claim (D-03)
  - Drop misleading i_have_committed verb; dev flow uses commit() (D-04)
  - Manifest mount via compose; flow_server + do_server fail loud
    instead of exposing all-verbs fallback (D-12)
  - MCP _post() surfaces envelope body on 4xx so agents see remediate
    hints (D-13)
    on git failure so retries aren't blocked by half-state (S-01)

  Phase 1 — lifecycle stability:
  - _resolve_skill falls back to AgentTable.capabilities (D-06)
  - main_pm_complete uses kwargs for escalate_to_ceo (D-07)
  - i_am_done auto-runs submit_verification when in_progress (D-08)
  - active_claimant_id wired in claim/unclaim paths — single-claimant
    invariant now functional (D-05)
  - qa_pass/qa_fail assert claimed_by parity with qa_agent_id (D-18)
  - Prompt-drift sweep: fail() shape, i_am_done(task_id, notes),
    subtask cap (12 hard / 8 soft), error-code symbology rewritten in
    base.md + per-role anti-patterns (D-10/11/29/30/31, D-37)

  Phase 2 — invariants + architecture:
  - Real-DB integration test exercising claim → in_progress → commit
    → submit_for_qa → i_am_done → awaiting_qa (P2-1)
  - choreographer.py → package; 3 of 6 role mixins extracted
    (board, doc, qa). _impl.py 2,526 → 2,080 lines (-18%). Continuation
    plan in docs/internal/audit_2026_05_04/p2_2_decompose_plan.md (P2-2)
  - Closure guards consolidated via _subtasks_not_terminal_envelope (P2-3)
  - TaskService.unclaim_for_reaper routed through canonical
    _validate_and_set_status; in_progress → pending added to
    VALID_TRANSITIONS (P2-4)
  - Dead code removed: i_am_done_with_catchup verb, _run_catch_up helper
    (P2-5)
  - 6 state-machine invariants asserted via property test (P2-6)
  - attempt_id (uuid4) stamped on every gateway.rejected audit row (P2-7)
  - _reconcile_orphan_claims_on_startup rolls back tasks left CLAIMED
    with branch_name=NULL from prior crashes (P2-8)
  - scripts/regenerate_verb_tables.py introspects Pydantic schemas +
    role_config; compose_prompt injects per-role tables as a layer.
    Eliminates the prompt-drift class structurally (P2-9)

  Other:
  - D-48: orchestrator mounts host's ~/.claude.json when present so
    agents don't boot from backup recovery on every spawn
  - D-49: dev dispatcher rejects role-mismatched spawns (e.g. doc task
    assigned to dev agent)

  Tests: 553 pass · ruff + mypy clean. Live NAS smoke verification
  pending — needs the stack brought back up.

tests/unit/gateway/test_audit_on_rejection.py

@@ -96,64 +96,6 @@ async def test_pm_cannot_execute_code_writes_audit_row() -> None:
     assert args.kwargs["details"]["reason"] == "not_authorized"
 
 
-# ---------------------------------------------------------------------------
-# tracing_gap path: i_have_committed with no plan
-# ---------------------------------------------------------------------------
-
-
-@pytest.mark.asyncio
-async def test_i_have_committed_missing_plan_writes_audit_row() -> None:
-    """Tracing-gap rejection (missing plan) should also be audited."""
-    aid = uuid4()
-    tid = uuid4()
-    task_with_no_plan = MagicMock(
-        id=tid,
-        status="in_progress",
-        assigned_to=aid,
-        plan=None,
-    )
-    task_svc = AsyncMock()
-    task_svc.get_active_task_for_agent.return_value = task_with_no_plan
-    audit_svc = AsyncMock()
-    deps = _make_deps(task=task_svc, audit=audit_svc)
-    c = Choreographer(deps)
-
-    env = await c.i_have_committed(aid, "wip")
-
-    assert env.error == "tracing_gap"
-    audit_svc.log_event.assert_awaited()
-    args = audit_svc.log_event.await_args
-    assert args.kwargs["event_type"] == "gateway.rejected"
-    assert args.kwargs["details"]["verb"] == "i_have_committed"
-    assert args.kwargs["details"]["reason"] == "tracing_gap"
-    assert "plan" in args.kwargs["details"]["missing"]
-
-
-# ---------------------------------------------------------------------------
-# invalid_state path: i_have_committed with no active task
-# ---------------------------------------------------------------------------
-
-
-@pytest.mark.asyncio
-async def test_i_have_committed_no_active_task_writes_audit_row() -> None:
-    """invalid_state rejection (no active task) is audited."""
-    aid = uuid4()
-    task_svc = AsyncMock()
-    task_svc.get_active_task_for_agent.return_value = None
-    audit_svc = AsyncMock()
-    deps = _make_deps(task=task_svc, audit=audit_svc)
-    c = Choreographer(deps)
-
-    env = await c.i_have_committed(aid, "wip")
-
-    assert env.error == "invalid_state"
-    audit_svc.log_event.assert_awaited()
-    args = audit_svc.log_event.await_args
-    assert args.kwargs["event_type"] == "gateway.rejected"
-    assert args.kwargs["details"]["verb"] == "i_have_committed"
-    assert args.kwargs["details"]["reason"] == "invalid_state"
-
-
 # ---------------------------------------------------------------------------
 # not_found path: unknown task id
 # ---------------------------------------------------------------------------
@@ -212,15 +154,17 @@ async def test_successful_verb_does_not_write_audit_row() -> None:
 async def test_audit_log_event_failure_does_not_propagate() -> None:
     """If log_event raises, the verb still returns the rejection envelope."""
     aid = uuid4()
+    tid = uuid4()
     task_svc = AsyncMock()
-    task_svc.get_active_task_for_agent.return_value = None
+    # Unknown task id triggers not_found rejection on i_am_done.
+    task_svc.get.return_value = None
     audit_svc = AsyncMock()
     audit_svc.log_event.side_effect = RuntimeError("audit DB down")
     deps = _make_deps(task=task_svc, audit=audit_svc)
     c = Choreographer(deps)
 
     # Must not raise; the rejection envelope should still come back.
-    env = await c.i_have_committed(aid, "wip")
+    env = await c.i_am_done(aid, tid, notes="x")
 
-    assert env.error == "invalid_state"
+    assert env.error == "not_found"
     audit_svc.log_event.assert_awaited()