External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(gateway): unblock task claim; full Phase 0/1/2 remediation

Browse Source 
Resolves the 100% claim-failure rate introduced by the gateway rewrite
  (commit 62bda0c plus 78 follow-ups). Live smoke runs hit
  `404 /api/v2/flow/developer/...` on every dev verb plus a manifest
  fallback that silently exposed off-role verbs to PMs — confirmed
  firing simultaneously in NAS agent logs (be-dev-1, be-pm, main-pm).

  Audit reports under docs/internal/audit_2026_05_04/ catalogue 49
  defects across gateway, services, prompts, MCP transport, substrate,
  and tests (8 detail reports + master synthesis). Six smoking guns;
  three proven in production logs.

  Phase 0 — unblock claim:
  - URL prefix /api/v2/flow/dev → /developer; slug-map board roles
    (product_owner, head_marketing) → /board (D-01)
  - _i_will_work_on AttributeError on None across pending /
    needs_revision / claimed re-entry branches (D-02)
  - Seed last_heartbeat_at in _qa_or_doc_claim (D-03)
  - Drop misleading i_have_committed verb; dev flow uses commit() (D-04)
  - Manifest mount via compose; flow_server + do_server fail loud
    instead of exposing all-verbs fallback (D-12)
  - MCP _post() surfaces envelope body on 4xx so agents see remediate
    hints (D-13)
    on git failure so retries aren't blocked by half-state (S-01)

  Phase 1 — lifecycle stability:
  - _resolve_skill falls back to AgentTable.capabilities (D-06)
  - main_pm_complete uses kwargs for escalate_to_ceo (D-07)
  - i_am_done auto-runs submit_verification when in_progress (D-08)
  - active_claimant_id wired in claim/unclaim paths — single-claimant
    invariant now functional (D-05)
  - qa_pass/qa_fail assert claimed_by parity with qa_agent_id (D-18)
  - Prompt-drift sweep: fail() shape, i_am_done(task_id, notes),
    subtask cap (12 hard / 8 soft), error-code symbology rewritten in
    base.md + per-role anti-patterns (D-10/11/29/30/31, D-37)

  Phase 2 — invariants + architecture:
  - Real-DB integration test exercising claim → in_progress → commit
    → submit_for_qa → i_am_done → awaiting_qa (P2-1)
  - choreographer.py → package; 3 of 6 role mixins extracted
    (board, doc, qa). _impl.py 2,526 → 2,080 lines (-18%). Continuation
    plan in docs/internal/audit_2026_05_04/p2_2_decompose_plan.md (P2-2)
  - Closure guards consolidated via _subtasks_not_terminal_envelope (P2-3)
  - TaskService.unclaim_for_reaper routed through canonical
    _validate_and_set_status; in_progress → pending added to
    VALID_TRANSITIONS (P2-4)
  - Dead code removed: i_am_done_with_catchup verb, _run_catch_up helper
    (P2-5)
  - 6 state-machine invariants asserted via property test (P2-6)
  - attempt_id (uuid4) stamped on every gateway.rejected audit row (P2-7)
  - _reconcile_orphan_claims_on_startup rolls back tasks left CLAIMED
    with branch_name=NULL from prior crashes (P2-8)
  - scripts/regenerate_verb_tables.py introspects Pydantic schemas +
    role_config; compose_prompt injects per-role tables as a layer.
    Eliminates the prompt-drift class structurally (P2-9)

  Other:
  - D-48: orchestrator mounts host's ~/.claude.json when present so
    agents don't boot from backup recovery on every spawn
  - D-49: dev dispatcher rejects role-mismatched spawns (e.g. doc task
    assigned to dev agent)

  Tests: 553 pass · ruff + mypy clean. Live NAS smoke verification
  pending — needs the stack brought back up.
This commit is contained in:
Renn F
2026-05-04 23:43:55 +02:00
parent 0a3c963923
commit 4829f93a68
55 changed files with 2470 additions and 1279 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/integration/v2/test_full_pending_to_completed.py
+16 -16
View File
@@ -208,29 +208,29 @@ async def test_pending_to_awaiting_ceo_approval(stateful_app: tuple) -> None:
# 1. Dev: give_me_work -> i_will_work_on -> note -> i_am_done
# ------------------------------------------------------------------
r = client.post(
"/api/v2/flow/dev/give_me_work",
headers={"X-Agent-ID": dev_id},
"/api/v2/flow/developer/give_me_work",
headers={"X-Agent-ID": dev_id, "X-Agent-Role": "developer"},
json={},
)
assert r.status_code == _HTTP_200
r = client.post(
"/api/v2/flow/dev/i_will_work_on",
headers={"X-Agent-ID": dev_id},
"/api/v2/flow/developer/i_will_work_on",
headers={"X-Agent-ID": dev_id, "X-Agent-Role": "developer"},
json={"task_id": str(uuid4()), "plan": "edit x then y"},
)
assert r.json()["status"] == "in_progress"
r = client.post(
"/api/v2/do/note",
headers={"X-Agent-ID": dev_id},
headers={"X-Agent-ID": dev_id, "X-Agent-Role": "developer"},
json={"text": "Reflected: did the work as planned.", "scope": "reflect"},
)
assert r.json()["error"] is None
r = client.post(
"/api/v2/flow/dev/i_am_done",
headers={"X-Agent-ID": dev_id},
"/api/v2/flow/developer/i_am_done",
headers={"X-Agent-ID": dev_id, "X-Agent-Role": "developer"},
json={"task_id": str(uuid4()), "notes": "all done"},
)
assert r.json()["status"] == "awaiting_qa"
@@ -242,14 +242,14 @@ async def test_pending_to_awaiting_ceo_approval(stateful_app: tuple) -> None:
# ------------------------------------------------------------------
r = client.post(
"/api/v2/flow/qa/claim_review",
headers={"X-Agent-ID": qa_id},
headers={"X-Agent-ID": qa_id, "X-Agent-Role": "qa"},
json={"task_id": str(uuid4())},
)
assert r.json()["evidence"]["pr_number"] == _PR_NUMBER
r = client.post(
"/api/v2/do/note",
headers={"X-Agent-ID": qa_id},
headers={"X-Agent-ID": qa_id, "X-Agent-Role": "developer"},
json={
"text": "Reviewed; all acceptance criteria addressed.",
"scope": "learning",
@@ -263,7 +263,7 @@ async def test_pending_to_awaiting_ceo_approval(stateful_app: tuple) -> None:
)
r = client.post(
"/api/v2/flow/qa/pass",
headers={"X-Agent-ID": qa_id},
headers={"X-Agent-ID": qa_id, "X-Agent-Role": "qa"},
json={"task_id": str(uuid4()), "notes": long_notes},
)
assert r.json()["status"] == "awaiting_documentation"
@@ -273,14 +273,14 @@ async def test_pending_to_awaiting_ceo_approval(stateful_app: tuple) -> None:
# ------------------------------------------------------------------
r = client.post(
"/api/v2/flow/documenter/claim_doc_task",
headers={"X-Agent-ID": doc_id},
headers={"X-Agent-ID": doc_id, "X-Agent-Role": "documenter"},
json={"task_id": str(uuid4())},
)
assert r.status_code == _HTTP_200
r = client.post(
"/api/v2/flow/documenter/i_documented",
headers={"X-Agent-ID": doc_id},
headers={"X-Agent-ID": doc_id, "X-Agent-Role": "documenter"},
json={
"task_id": str(uuid4()),
"notes": "Wrote backend/guides/feature-x.md covering usage and config.",
@@ -294,14 +294,14 @@ async def test_pending_to_awaiting_ceo_approval(stateful_app: tuple) -> None:
# ------------------------------------------------------------------
r = client.post(
"/api/v2/do/note",
headers={"X-Agent-ID": cell_pm_id},
headers={"X-Agent-ID": cell_pm_id, "X-Agent-Role": "developer"},
json={"text": "Decision: approve and merge.", "scope": "decision"},
)
assert r.json()["error"] is None
r = client.post(
"/api/v2/flow/cell_pm/complete",
headers={"X-Agent-ID": cell_pm_id},
headers={"X-Agent-ID": cell_pm_id, "X-Agent-Role": "cell_pm"},
json={"task_id": str(uuid4()), "notes": "Approved and merged"},
)
assert r.json()["status"] == "completed"
@@ -311,14 +311,14 @@ async def test_pending_to_awaiting_ceo_approval(stateful_app: tuple) -> None:
# ------------------------------------------------------------------
r = client.post(
"/api/v2/do/note",
headers={"X-Agent-ID": main_pm_id},
headers={"X-Agent-ID": main_pm_id, "X-Agent-Role": "developer"},
json={"text": "Root task ready for prod.", "scope": "decision"},
)
assert r.json()["error"] is None
r = client.post(
"/api/v2/flow/main_pm/complete",
headers={"X-Agent-ID": main_pm_id},
headers={"X-Agent-ID": main_pm_id, "X-Agent-Role": "main_pm"},
json={"task_id": str(uuid4()), "notes": "Ready for prod"},
)
assert r.json()["status"] == "awaiting_ceo_approval"