mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
feat(gateway): add submit_for_qa verb so devs can open PRs
Gate E made i_am_done strict (requires pr_number set), but the only verb that opened PRs was i_am_done_with_catchup which lives off the dev manifest. Devs hit NO_PR with no escape. Adds submit_for_qa as the explicit push+PR step, leaving i_am_done to do the strict submit.
This commit is contained in:
@@ -21,7 +21,8 @@ You write code; you do not coordinate. If you find yourself thinking "let me als
|
||||
| `i_will_work_on(task_id, plan=None)` | Claims a `pending`/`needs_revision` task; resumes a `claimed`/`in_progress` task you own. Auto-creates branch on first claim. | Task assigned to you (or unassigned and matches your role/team); for `claimed` resumption, plan and branch must exist. |
|
||||
| `commit(message)` | Auto-prefixes `[task-id]`; records a progress entry. | Task in `in_progress`; on your branch. |
|
||||
| `i_have_committed(message)` | Quick alias for `commit()`. | Same as `commit`. |
|
||||
| `i_am_done(notes)` | Runs verify -> push -> create PR -> submit_for_qa. | At least one commit; progress entry; journal `reflect`; every acceptance criterion addressed. |
|
||||
| `submit_for_qa(task_id)` | Push your branch and open a PR. Run after your last commit, before `i_am_done`. | Task assigned to you; at least one commit; no PR yet. |
|
||||
| `i_am_done(notes)` | Strict submit for QA. Requires PR already open — run `submit_for_qa` first. | Self-verified; at least one commit; PR open; progress entry; journal `reflect`; every acceptance criterion addressed. |
|
||||
| `i_am_blocked(reason)` | Records the blocker, escalates to your PM, idles you. | Task is yours and active. |
|
||||
| `note(text, scope?)` | Journal entry (`scope ∈ note|decision|reflect|learning|struggle`). | None. |
|
||||
| `say(channel, text)` / `dm(recipient, text, skill?)` | Channel post / direct message. | Channel slug without `#`. |
|
||||
@@ -36,12 +37,13 @@ You write code; you do not coordinate. If you find yourself thinking "let me als
|
||||
4. Edit / Write your changes inside the workspace. Run tests via `Bash` if needed.
|
||||
5. `commit(message)` after each meaningful change. Repeat 4-5 until the criteria are met.
|
||||
6. `note(scope='reflect', text="<what you did + why>")` before submitting.
|
||||
7. `i_am_done(notes)` -> the gateway pushes, opens the PR, submits for QA. Read the envelope: if it returns an error, the `remediate` field tells you which preconditions are missing.
|
||||
8. After `i_am_done` succeeds you are finished with this task. `i_am_idle()`. Documenter writes docs; PM merges. You will only be respawned on `needs_revision`.
|
||||
7. `submit_for_qa(task_id="<your-task>")` -> pushes your branch and opens the PR up to your cell PM's branch. The response includes the PR number.
|
||||
8. `i_am_done(notes)` -> strict submit for QA against the PR you just opened. Read the envelope: if it returns an error, the `remediate` field tells you which preconditions are missing.
|
||||
9. After `i_am_done` succeeds you are finished with this task. `i_am_idle()`. Documenter writes docs; PM merges. You will only be respawned on `needs_revision`.
|
||||
|
||||
## Anti-patterns
|
||||
|
||||
- ❌ Calling `i_am_done` without commits / PR-able state / self-verify / progress entry. The gateway will reject with `NO_COMMITS`, `NO_PR`, `NOT_SELF_VERIFIED`, or `NO_PROGRESS` — fix the missing piece, do not retry blindly.
|
||||
- ❌ Calling `i_am_done` without commits / open PR / self-verify / progress entry. The gateway will reject with `NO_COMMITS`, `NO_PR`, `NOT_SELF_VERIFIED`, or `NO_PROGRESS` — fix the missing piece, do not retry blindly. For `NO_PR`, call `submit_for_qa(task_id)` to push and open the PR, then retry `i_am_done`.
|
||||
- ❌ Editing files outside your assigned task's branch. Your workspace is per-task; touching another agent's files is a layer-separation violation.
|
||||
- ❌ Trying to merge your own PR. Merging is a PM verb — you have no merge tool. If you call `Bash gh pr merge`, the orchestrator denies it.
|
||||
- ❌ Running `Bash git commit` or `Bash git push`. The gateway covers commit/push and records traces; raw git is denied at the bash-guard layer.
|
||||
|
||||
Reference in New Issue
Block a user