mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -75,12 +75,11 @@ async def test_create_notification_suppresses_same_purpose_duplicate() -> None:
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_informational_knowledge_share_not_deduped() -> None:
|
||||
"""F010: KNOWLEDGE_SHARE (informational, requires_ack=False) must NOT be
|
||||
deduped. Each learning broadcast carries distinct content (a new learning);
|
||||
a recipient who never acks the prior one (acking is voluntary for
|
||||
informational types) would permanently suppress every subsequent
|
||||
knowledge-share from the same sender → silent learning-broadcast data loss.
|
||||
The dedup's anti-loop rationale only applies to action-required types."""
|
||||
"""KNOWLEDGE_SHARE (informational, requires_ack=False) must NOT be deduped:
|
||||
a recipient who never acks the prior one would permanently suppress every
|
||||
subsequent knowledge-share from the same sender → silent learning-broadcast
|
||||
data loss. The dedup's anti-loop rationale only applies to action-required
|
||||
types."""
|
||||
db = MagicMock()
|
||||
# A same-purpose unacked KNOWLEDGE_SHARE prior exists — but it must NOT
|
||||
# suppress the new one.
|
||||
|
||||
Reference in New Issue
Block a user