mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
[sweep] strip Fxxx audit-ID tokens + trim bloated comments/docstrings + add behavior-change docs
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
This commit is contained in:
@@ -1,17 +1,6 @@
|
||||
"""F058: the FIRST release (no prior ``chore(release):`` commit) must still
|
||||
produce a non-empty version-bump plan.
|
||||
|
||||
``_canonical_bump_files`` derived the bump-target set from the previous
|
||||
``chore(release):`` commit's touched files. On the first release ever there is
|
||||
no such commit, so it returned ``[]`` → ``assess`` set
|
||||
``version_bump_plan=[]`` → ``ReleaseExecutor.apply_version_bumps`` bumped NO
|
||||
files and published a tag masquerading as X.Y.Z with nothing actually changed.
|
||||
|
||||
The fix: when no prior release commit exists, fall back to the version-
|
||||
reference scan — the files currently embedding the version string are exactly
|
||||
the set a first release must bump (and the set a subsequent release's
|
||||
``chore(release):`` commit would record as canonical). This is read-only
|
||||
derivation only; the CEO-approval gate and fail-closed executor are untouched.
|
||||
"""The FIRST release (no prior ``chore(release):`` commit) must still produce a
|
||||
non-empty version-bump plan: ``_canonical_bump_files`` falls back to the
|
||||
version-reference scan when no prior release commit exists.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
@@ -60,7 +49,7 @@ def _first_release_repo(tmp_path: Path) -> Path:
|
||||
|
||||
def test_canonical_bump_files_falls_back_on_first_release(tmp_path: Path) -> None:
|
||||
"""No prior ``chore(release):`` commit ⇒ the canonical set is the version-
|
||||
reference scan, NOT empty (the F058 regression: it returned ``[]``)."""
|
||||
reference scan, NOT empty."""
|
||||
root = _first_release_repo(tmp_path)
|
||||
files = _canonical_bump_files(root, "0.1.0")
|
||||
assert files # non-empty
|
||||
|
||||
Reference in New Issue
Block a user